You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/01/09 17:45:12 UTC

[GitHub] [activemq-artemis] jbertram commented on issue #2913: ARTEMIS-2571 Remove synchronization of ActiveMQServerImpl#getSessions()

jbertram commented on issue #2913: ARTEMIS-2571 Remove synchronization of ActiveMQServerImpl#getSessions()
URL: https://github.com/apache/activemq-artemis/pull/2913#issuecomment-572673809
 
 
   I think this change looks good. Even if there was no performance testing (which there is on the JIRA) static analysis is enough for me given that (as @sebthom already pointed out) there is a lot of unsynchronized access to the `sessions` map and the map is *already* a `ConcurrentHashMap`. I don't see any good reason for those `getSessions` methods to use `synchronized`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services