You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/10/04 15:13:47 UTC
Review Request 71581: Made `CHECK` in sorter print out more info upon
failure.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71581/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Repository: mesos
Description
-------
Made `CHECK` in sorter print out more info upon failure.
Diffs
-----
src/master/allocator/mesos/sorter/drf/sorter.hpp ab20a86ddca91211fb6e9d145350be0aab1cc956
src/master/allocator/mesos/sorter/random/sorter.hpp 06362cea1b81095f623d058a024e8713106cdc04
Diff: https://reviews.apache.org/r/71581/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 71581: Made `CHECK` in sorter print out more info
upon failure.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71581/#review218075
-----------------------------------------------------------
src/master/allocator/mesos/sorter/drf/sorter.hpp
Line 336 (original), 336 (patched)
<https://reviews.apache.org/r/71581/#comment305594>
Should we also print the resource argument for these?
- Benjamin Mahler
On Oct. 4, 2019, 3:13 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71581/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2019, 3:13 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made `CHECK` in sorter print out more info upon failure.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/sorter/drf/sorter.hpp ab20a86ddca91211fb6e9d145350be0aab1cc956
> src/master/allocator/mesos/sorter/random/sorter.hpp 06362cea1b81095f623d058a024e8713106cdc04
>
>
> Diff: https://reviews.apache.org/r/71581/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 71581: Made `CHECK` in sorter print out more info
upon failure.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71581/#review218074
-----------------------------------------------------------
Ship it!
Can you link in the related ticket?
- Benjamin Mahler
On Oct. 4, 2019, 3:13 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71581/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2019, 3:13 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made `CHECK` in sorter print out more info upon failure.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/sorter/drf/sorter.hpp ab20a86ddca91211fb6e9d145350be0aab1cc956
> src/master/allocator/mesos/sorter/random/sorter.hpp 06362cea1b81095f623d058a024e8713106cdc04
>
>
> Diff: https://reviews.apache.org/r/71581/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>