[jira] [Commented] (CB-8252) Prep core plugins for CSP by removing eval()s (Android only)

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-8252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14269979#comment-14269979 ] 

ASF GitHub Bot commented on CB-8252:
------------------------------------

GitHub user jpchase opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/41

    CB-8252 Fire audio events from native via message channel

    - Add startup logic to initialize a message channel for native -> Javascript
    - Applies only to android and amazon-fireos (as this reuses the android native code)
    - Change audio status events to send via plugin message channel, instead
    using eval() (i.e. webView.sendJavascript())

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jpchase/cordova-plugin-media CB-8252

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #41
    
----
commit c3880f377f3c7737f3d3282701c8e0e6f8109c68
Author: Jason Chase <ja...@gmail.com>
Date:   2015-01-08T20:04:51Z

    CB-8252 Fire audio events from native via message channel
    - Add startup logic to initialize a message channel for native -> Javascript
    - Applies only to android and amazon-fireos (as this reuses the android native code)
    - Change audio status events to send via plugin message channel, instead
    using eval() (i.e. webView.sendJavascript())

----


> Prep core plugins for CSP by removing eval()s (Android only)
> ------------------------------------------------------------
>
>                 Key: CB-8252
>                 URL: https://issues.apache.org/jira/browse/CB-8252
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugins
>    Affects Versions: Master
>            Reporter: Jason Chase
>            Assignee: Jason Chase
>
> In preparation for CSP, remove any native Android code in the core plugins that is using inline javascript/eval()s.
> Other platforms with native code (i.e. iOS) are out of scope for now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org