[GitHub] [lucene-solr] dweiss commented on a change in pull request #1779: LUCENE-9478: Prevent DWPTDeleteQueue from referencing itself and leaking memory

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #1779:
URL: https://github.com/apache/lucene-solr/pull/1779#discussion_r475744657



##########
File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterDeleteQueue.java
##########
@@ -573,6 +573,10 @@ long getMaxCompletedSeqNo() {
     }
   }
 
+  private static LongSupplier getPrevMaxSeqIdSupplier(AtomicLong nextSeqNo) {

Review comment:
       Maybe add a comment to this method referencing the issue, Simon? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org