You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jack (JIRA)" <ji...@apache.org> on 2019/01/13 07:03:00 UTC

[jira] [Commented] (AIRFLOW-3690) Fix api.common.experimental.mark_tasks.set_state for the manually-triggered DAG Runs

    [ https://issues.apache.org/jira/browse/AIRFLOW-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741477#comment-16741477 ] 

jack commented on AIRFLOW-3690:
-------------------------------

Is this related to https://issues.apache.org/jira/browse/AIRFLOW-419 ? 

> Fix api.common.experimental.mark_tasks.set_state for the manually-triggered DAG Runs
> ------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-3690
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3690
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: api
>            Reporter: Xiaodong DENG
>            Assignee: Xiaodong DENG
>            Priority: Major
>
> Line [https://github.com/apache/airflow/pull/2085/files#diff-4a8a799d7af166d79e74a8a3587e6171R75|https://github.com/apache/airflow/pull/2085/files#diff-4a8a799d7af166d79e74a8a3587e6171R75,]  removes millisecond information from the execution_date in the set_state function. But this will fail the query when it tries to look for all th valid execution_dates in the database, because millisecond is stored in the database.
>  
> The result is: for all the manually-triggered DAG Runs, if users try to mark state of a task instance, it will fail because no corresponding records can be found. 
>  
> This doesn't impact any scheduled DAG Runs since the millisecond in their execution_date is 0.
>  
> Actually someone already reported this in the original GitHub PR: https://github.com/apache/airflow/pull/2085#issuecomment-297713635



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)