You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HeartSaVioR <gi...@git.apache.org> on 2018/08/21 23:58:08 UTC

[GitHub] spark pull request #22178: [MINOR] Fix build failure due to non-direct confl...

GitHub user HeartSaVioR opened a pull request:

    https://github.com/apache/spark/pull/22178

    [MINOR] Fix build failure due to non-direct conflict: removing import affects others

    ## What changes were proposed in this pull request?
    
    Fix the build failure on master branch: some PR removed import which #21469 referred to. They were not making direct conflict so cannot find the issue until running build after merging twos.
    
    ## How was this patch tested?
    
    Ran `maven clean install -DskipTests`. For tests I'd like to defer to CI build cause it will take hours.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HeartSaVioR/spark fix-build-failure-on-master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22178
    
----
commit 533a53637ead10a8b8432cfd960947b218088ced
Author: Jungtaek Lim <ka...@...>
Date:   2018-08-21T23:53:06Z

    Fix build failure due to non-direct conflict: removing import affects others

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22178: [MINOR] Fix build failure due to non-direct conflict: re...

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/spark/pull/22178
  
    a998e9d829bd499dd7c65f973ea4389e0401b001 resolved this. @tdas was faster :) Closing.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22178: [MINOR] Fix build failure due to non-direct conflict: re...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22178
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22178: [MINOR] Fix build failure due to non-direct conflict: re...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22178
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95062/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22178: [MINOR] Fix build failure due to non-direct conflict: re...

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/spark/pull/22178
  
    cc. @tdas 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22178: [MINOR] Fix build failure due to non-direct conflict: re...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22178
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22178: [MINOR] Fix build failure due to non-direct conflict: re...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22178
  
    **[Test build #95062 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95062/testReport)** for PR 22178 at commit [`533a536`](https://github.com/apache/spark/commit/533a53637ead10a8b8432cfd960947b218088ced).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22178: [MINOR] Fix build failure due to non-direct conflict: re...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22178
  
    **[Test build #95062 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95062/testReport)** for PR 22178 at commit [`533a536`](https://github.com/apache/spark/commit/533a53637ead10a8b8432cfd960947b218088ced).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org