You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@airavata.apache.org by vaglomangirish <gi...@git.apache.org> on 2016/05/26 04:05:34 UTC
[GitHub] airavata pull request: Reusing existing unused floating IPs instea...
GitHub user vaglomangirish opened a pull request:
https://github.com/apache/airavata/pull/34
Reusing existing unused floating IPs instead of requesting new every time.
Floating iP association logic in cloud-provisioning always creates a new floating IP in the pool and associates to the VM. Even though the VM deletion handles removing and deleting the associated floating IP, there might have been cases that the machine gets an floating IP associated and then the machine is deleted through some other flow, leaving the floating IP unused in the pool.
I have now modified the code to reuse any existing floating IPs in the pool, instead of requesting a new one every time. Now the logic would request a new floating ip only if the available floating IP list is empty, or all the floating IPs are associated to VMs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vaglomangirish/airavata develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/airavata/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
----
commit 84913b59677ffde19e80d07820b0a205007898d4
Author: Mangirish Wagle <va...@gmail.com>
Date: 2016-04-23T16:41:29Z
Merge pull request #2 from apache/develop
Accepting latest changes
commit 4708005efe8013c280b6d91dfc511d805b8317fe
Author: Mangirish Wagle <va...@gmail.com>
Date: 2016-05-24T22:19:03Z
Merge pull request #3 from apache/develop
Develop
commit a69c789e205eff1f27020de8c1fb3185be39af21
Author: Mangirish Wagle <va...@gmail.com>
Date: 2016-05-26T03:59:06Z
Reuse existing floating IPs if present instead of requesting new every time.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata pull request #34: Reusing existing unused floating IPs instead of r...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/airavata/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---