[GitHub] [airflow] EliMor commented on issue #17489: Helm chart converts ' ' to '+' in passwords (and username)

[GitBox <gi...@apache.org>]

EliMor commented on issue #17489:
URL: https://github.com/apache/airflow/issues/17489#issuecomment-899289298


   So... 
   Some questions I had lingering in my head, no response expected on my end. Please keep in mind I'm very naive/lacking any context and there are extra implicit assumptions here but...
   
   - **Whats the rationale for constructing and encoding the URL to be saved and putting it in the Secret?** This is as opposed to plopping the secret as provided by the user in the values.yaml and then building and encoding the URL inside the containers using some standard encoding & url construction strategy. Is it because this seemed like wasted work done on every pod reboot?
   - **Do we think that a preconnect check should happen in the migration pod?** I thought it was strange that it passed just fine and I didn't see connection errors until we were to the worker-pods this is why I initially assumed that some extra funky encoding was happening again behind the scenes and why using spaces raw seemed to work. I also thought it was strange that I did not see any of the other pods in a crashloop as well. Please correct me if I'm wrong about this.
   
   Cheers.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org