You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/10/24 14:44:20 UTC
[GitHub] [iotdb] ZhanGHanG9991 opened a new pull request #4220: ustzh complete session unsetSchemaTemplate method
ZhanGHanG9991 opened a new pull request #4220:
URL: https://github.com/apache/iotdb/pull/4220
## Description
complete session unsetSchemaTemplate method
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design
(or naming) decision point and compare the alternatives with the designs that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list),
link to that discussion from this PR description and explain what have changed in your final design
compared to your original proposal or the consensus version in the end of the discussion.
If something hasn't changed since the original discussion, you can omit a detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items
apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items
from the checklist above are strictly necessary, but it would be very helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4220: ustzh complete session unsetSchemaTemplate method
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4220:
URL: https://github.com/apache/iotdb/pull/4220#issuecomment-950344802
[](https://coveralls.io/builds/43741997)
Coverage decreased (-0.3%) to 66.94% when pulling **929179e6e8cc002933ad412e1bdcc945026df77f on ZhanGHanG9991:ustzh** into **d2e4d734caa3695d78501e888e32aac0a2cf22f2 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SilverNarcissus commented on a change in pull request #4220: ustzh complete session unsetSchemaTemplate method
Posted by GitBox <gi...@apache.org>.
SilverNarcissus commented on a change in pull request #4220:
URL: https://github.com/apache/iotdb/pull/4220#discussion_r735202952
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/crud/UnsetSchemaTemplatePlan.java
##########
@@ -0,0 +1,80 @@
+package org.apache.iotdb.db.qp.physical.crud;
+
+import org.apache.iotdb.db.metadata.PartialPath;
+import org.apache.iotdb.db.qp.logical.Operator;
+import org.apache.iotdb.db.qp.physical.PhysicalPlan;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.List;
+
+/**
+ * @author zhanghang
+ * @date 2021/10/22 16:34
+ */
+public class UnsetSchemaTemplatePlan extends PhysicalPlan {
+
+ String prefixPath;
Review comment:
Should it be private?
##########
File path: session/src/test/java/org/apache/iotdb/session/SessionTest.java
##########
@@ -288,4 +288,122 @@ public void testBuilder() {
fail();
}
}
+
+ @Test
+ public void testUnsetSchemaTemplate() throws IoTDBConnectionException, StatementExecutionException {
+ session = new Session("127.0.0.1", 6667, "root", "root", ZoneId.of("+05:00"));
+ session.open();
+
+ List<List<String>> measurementList = new ArrayList<>();
+ measurementList.add(Collections.singletonList("s1"));
+ measurementList.add(Collections.singletonList("s2"));
+ measurementList.add(Collections.singletonList("s3"));
+
+ List<List<TSDataType>> dataTypeList = new ArrayList<>();
+ dataTypeList.add(Collections.singletonList(TSDataType.INT64));
+ dataTypeList.add(Collections.singletonList(TSDataType.INT64));
+ dataTypeList.add(Collections.singletonList(TSDataType.INT64));
+
+ List<List<TSEncoding>> encodingList = new ArrayList<>();
+ encodingList.add(Collections.singletonList(TSEncoding.RLE));
+ encodingList.add(Collections.singletonList(TSEncoding.RLE));
+ encodingList.add(Collections.singletonList(TSEncoding.RLE));
+
+ List<CompressionType> compressionTypes = new ArrayList<>();
+ for (int i = 0; i < 3; i++) {
+ compressionTypes.add(CompressionType.SNAPPY);
+ }
+ List<String> schemaNames = new ArrayList<>();
+ schemaNames.add("s1");
+ schemaNames.add("s2");
+ schemaNames.add("s3");
+
+ // template create test
+ session.createSchemaTemplate(
+ "template1", schemaNames, measurementList, dataTypeList, encodingList, compressionTypes);
+ System.out.println("template1 already created");
+
+ // path does not exist test
+ try {
+ session.unsetSchemaTemplate("root.sg.1", "template1");
+ } catch (Exception e) {
+ System.out.println("304: Path [root.sg.1] does not exist");
+ e.printStackTrace();
+ }
+
+ // set template test
+ session.setSchemaTemplate("template1", "root.sg.1");
+ System.out.println("template1 already set on root.sg.1");
+
+ // template already exists test
+ try {
+ session.setSchemaTemplate("template1", "root.sg.1");
+ } catch (Exception e) {
+ System.out.println("303: Template already exists on root.sg.1");
+ e.printStackTrace();
+ }
+
+ // template unset test
+ session.unsetSchemaTemplate("root.sg.1", "template1");
+ System.out.println("template1 already unset from root.sg.1");
+
+ session.setSchemaTemplate("template1", "root.sg.1");
+ System.out.println("template1 already set on root.sg.1");
+
+ // no template on path test
+ session.unsetSchemaTemplate("root.sg.1", "template1");
+ System.out.println("template1 already unset from root.sg.1");
Review comment:
You may use some method to test this statement("template1 already unset from root.sg.1") automatically. This print can only be read by human.
##########
File path: session/src/test/java/org/apache/iotdb/session/SessionTest.java
##########
@@ -288,4 +288,122 @@ public void testBuilder() {
fail();
}
}
+
+ @Test
+ public void testUnsetSchemaTemplate() throws IoTDBConnectionException, StatementExecutionException {
+ session = new Session("127.0.0.1", 6667, "root", "root", ZoneId.of("+05:00"));
+ session.open();
+
+ List<List<String>> measurementList = new ArrayList<>();
+ measurementList.add(Collections.singletonList("s1"));
+ measurementList.add(Collections.singletonList("s2"));
+ measurementList.add(Collections.singletonList("s3"));
+
+ List<List<TSDataType>> dataTypeList = new ArrayList<>();
+ dataTypeList.add(Collections.singletonList(TSDataType.INT64));
+ dataTypeList.add(Collections.singletonList(TSDataType.INT64));
+ dataTypeList.add(Collections.singletonList(TSDataType.INT64));
+
+ List<List<TSEncoding>> encodingList = new ArrayList<>();
+ encodingList.add(Collections.singletonList(TSEncoding.RLE));
+ encodingList.add(Collections.singletonList(TSEncoding.RLE));
+ encodingList.add(Collections.singletonList(TSEncoding.RLE));
+
+ List<CompressionType> compressionTypes = new ArrayList<>();
+ for (int i = 0; i < 3; i++) {
+ compressionTypes.add(CompressionType.SNAPPY);
+ }
+ List<String> schemaNames = new ArrayList<>();
+ schemaNames.add("s1");
+ schemaNames.add("s2");
+ schemaNames.add("s3");
+
+ // template create test
+ session.createSchemaTemplate(
+ "template1", schemaNames, measurementList, dataTypeList, encodingList, compressionTypes);
+ System.out.println("template1 already created");
Review comment:
We should use logger rather than System.out.println
##########
File path: server/src/main/java/org/apache/iotdb/db/exception/metadata/DifferentTemplateException.java
##########
@@ -0,0 +1,17 @@
+package org.apache.iotdb.db.exception.metadata;
Review comment:
This file has no apache license, please add the license~
##########
File path: session/src/test/java/org/apache/iotdb/session/SessionTest.java
##########
@@ -288,4 +288,122 @@ public void testBuilder() {
fail();
}
}
+
+ @Test
+ public void testUnsetSchemaTemplate() throws IoTDBConnectionException, StatementExecutionException {
+ session = new Session("127.0.0.1", 6667, "root", "root", ZoneId.of("+05:00"));
+ session.open();
+
+ List<List<String>> measurementList = new ArrayList<>();
+ measurementList.add(Collections.singletonList("s1"));
+ measurementList.add(Collections.singletonList("s2"));
+ measurementList.add(Collections.singletonList("s3"));
+
+ List<List<TSDataType>> dataTypeList = new ArrayList<>();
+ dataTypeList.add(Collections.singletonList(TSDataType.INT64));
+ dataTypeList.add(Collections.singletonList(TSDataType.INT64));
+ dataTypeList.add(Collections.singletonList(TSDataType.INT64));
+
+ List<List<TSEncoding>> encodingList = new ArrayList<>();
+ encodingList.add(Collections.singletonList(TSEncoding.RLE));
+ encodingList.add(Collections.singletonList(TSEncoding.RLE));
+ encodingList.add(Collections.singletonList(TSEncoding.RLE));
+
+ List<CompressionType> compressionTypes = new ArrayList<>();
+ for (int i = 0; i < 3; i++) {
+ compressionTypes.add(CompressionType.SNAPPY);
+ }
+ List<String> schemaNames = new ArrayList<>();
+ schemaNames.add("s1");
+ schemaNames.add("s2");
+ schemaNames.add("s3");
+
+ // template create test
+ session.createSchemaTemplate(
+ "template1", schemaNames, measurementList, dataTypeList, encodingList, compressionTypes);
+ System.out.println("template1 already created");
+
+ // path does not exist test
+ try {
+ session.unsetSchemaTemplate("root.sg.1", "template1");
Review comment:
you should add a fail() in Unit test after this line. Because you expect this line will throw an exception.
##########
File path: session/src/test/java/org/apache/iotdb/session/SessionTest.java
##########
@@ -288,4 +288,122 @@ public void testBuilder() {
fail();
}
}
+
+ @Test
+ public void testUnsetSchemaTemplate() throws IoTDBConnectionException, StatementExecutionException {
+ session = new Session("127.0.0.1", 6667, "root", "root", ZoneId.of("+05:00"));
+ session.open();
+
+ List<List<String>> measurementList = new ArrayList<>();
+ measurementList.add(Collections.singletonList("s1"));
+ measurementList.add(Collections.singletonList("s2"));
+ measurementList.add(Collections.singletonList("s3"));
+
+ List<List<TSDataType>> dataTypeList = new ArrayList<>();
+ dataTypeList.add(Collections.singletonList(TSDataType.INT64));
+ dataTypeList.add(Collections.singletonList(TSDataType.INT64));
+ dataTypeList.add(Collections.singletonList(TSDataType.INT64));
+
+ List<List<TSEncoding>> encodingList = new ArrayList<>();
+ encodingList.add(Collections.singletonList(TSEncoding.RLE));
+ encodingList.add(Collections.singletonList(TSEncoding.RLE));
+ encodingList.add(Collections.singletonList(TSEncoding.RLE));
+
+ List<CompressionType> compressionTypes = new ArrayList<>();
+ for (int i = 0; i < 3; i++) {
+ compressionTypes.add(CompressionType.SNAPPY);
+ }
+ List<String> schemaNames = new ArrayList<>();
+ schemaNames.add("s1");
+ schemaNames.add("s2");
+ schemaNames.add("s3");
+
+ // template create test
+ session.createSchemaTemplate(
+ "template1", schemaNames, measurementList, dataTypeList, encodingList, compressionTypes);
+ System.out.println("template1 already created");
+
+ // path does not exist test
+ try {
+ session.unsetSchemaTemplate("root.sg.1", "template1");
+ } catch (Exception e) {
+ System.out.println("304: Path [root.sg.1] does not exist");
+ e.printStackTrace();
+ }
+
+ // set template test
+ session.setSchemaTemplate("template1", "root.sg.1");
+ System.out.println("template1 already set on root.sg.1");
+
+ // template already exists test
+ try {
+ session.setSchemaTemplate("template1", "root.sg.1");
+ } catch (Exception e) {
+ System.out.println("303: Template already exists on root.sg.1");
+ e.printStackTrace();
+ }
+
+ // template unset test
+ session.unsetSchemaTemplate("root.sg.1", "template1");
+ System.out.println("template1 already unset from root.sg.1");
+
+ session.setSchemaTemplate("template1", "root.sg.1");
+ System.out.println("template1 already set on root.sg.1");
+
+ // no template on path test
+ session.unsetSchemaTemplate("root.sg.1", "template1");
+ System.out.println("template1 already unset from root.sg.1");
+
+ try {
+ session.unsetSchemaTemplate("root.sg.1", "template1");
+ } catch (Exception e) {
+ System.out.println("324: NO template on root.sg.1");
+ e.printStackTrace();
+ }
+
+ // template is in use test
+ session.setSchemaTemplate("template1", "root.sg.1");
+ System.out.println("template1 already set on root.sg.1");
+
+ String deviceId = "root.sg.1.cd";
+ List<String> measurements = new ArrayList<>();
+ List<TSDataType> types = new ArrayList<>();
+ measurements.add("s1");
+ measurements.add("s2");
+ measurements.add("s3");
+ types.add(TSDataType.INT64);
+ types.add(TSDataType.INT64);
+ types.add(TSDataType.INT64);
+
+ for (long time = 0; time < 5; time++) {
+ List<Object> values = new ArrayList<>();
+ values.add(1L);
+ values.add(2L);
+ values.add(3L);
+ session.insertRecord(deviceId, time, measurements, types, values);
+ System.out.println("insert record");
+ }
+
+ try {
+ session.unsetSchemaTemplate("root.sg.1", "template1");
+ } catch (Exception e) {
+ System.out.println("326: Template is in use on root.sg.1.cd");
+ e.printStackTrace();
+ }
+
+ // TODO lower node templated data has been deleted, unset template test no way to get node has already deleted all timeseries which use template
+ session.deleteTimeseries("root.sg.1.cd.s1");
+ session.deleteTimeseries("root.sg.1.cd.s2");
+ session.deleteTimeseries("root.sg.1.cd.s3");
+ try {
+ session.unsetSchemaTemplate("root.sg.1", "template1");
+ } catch (Exception e) {
+ System.out.println("template1 already unset from root.sg.1");
+ e.printStackTrace();
+ }
+
+ session.setSchemaTemplate("template1", "root.sg.1");
+ System.out.println("template1 already set on root.sg.1");
Review comment:
You should also add some unit test in MManager.
##########
File path: session/src/test/java/org/apache/iotdb/session/SessionTest.java
##########
@@ -288,4 +288,122 @@ public void testBuilder() {
fail();
}
}
+
+ @Test
+ public void testUnsetSchemaTemplate() throws IoTDBConnectionException, StatementExecutionException {
+ session = new Session("127.0.0.1", 6667, "root", "root", ZoneId.of("+05:00"));
+ session.open();
+
+ List<List<String>> measurementList = new ArrayList<>();
+ measurementList.add(Collections.singletonList("s1"));
+ measurementList.add(Collections.singletonList("s2"));
+ measurementList.add(Collections.singletonList("s3"));
+
+ List<List<TSDataType>> dataTypeList = new ArrayList<>();
+ dataTypeList.add(Collections.singletonList(TSDataType.INT64));
+ dataTypeList.add(Collections.singletonList(TSDataType.INT64));
+ dataTypeList.add(Collections.singletonList(TSDataType.INT64));
+
+ List<List<TSEncoding>> encodingList = new ArrayList<>();
+ encodingList.add(Collections.singletonList(TSEncoding.RLE));
+ encodingList.add(Collections.singletonList(TSEncoding.RLE));
+ encodingList.add(Collections.singletonList(TSEncoding.RLE));
+
+ List<CompressionType> compressionTypes = new ArrayList<>();
+ for (int i = 0; i < 3; i++) {
+ compressionTypes.add(CompressionType.SNAPPY);
+ }
+ List<String> schemaNames = new ArrayList<>();
+ schemaNames.add("s1");
+ schemaNames.add("s2");
+ schemaNames.add("s3");
+
+ // template create test
+ session.createSchemaTemplate(
+ "template1", schemaNames, measurementList, dataTypeList, encodingList, compressionTypes);
+ System.out.println("template1 already created");
+
+ // path does not exist test
+ try {
+ session.unsetSchemaTemplate("root.sg.1", "template1");
+ } catch (Exception e) {
+ System.out.println("304: Path [root.sg.1] does not exist");
+ e.printStackTrace();
+ }
+
+ // set template test
+ session.setSchemaTemplate("template1", "root.sg.1");
+ System.out.println("template1 already set on root.sg.1");
+
+ // template already exists test
+ try {
+ session.setSchemaTemplate("template1", "root.sg.1");
Review comment:
you should add a fail() in Unit test after this line. Because you expect this line will throw an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4220: ustzh complete session unsetSchemaTemplate method
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4220:
URL: https://github.com/apache/iotdb/pull/4220#issuecomment-950344802
[](https://coveralls.io/builds/43734776)
Coverage decreased (-0.2%) to 67.017% when pulling **53fbdbd99dd8e687c2b615d94227ae181249262e on ZhanGHanG9991:ustzh** into **d2e4d734caa3695d78501e888e32aac0a2cf22f2 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ZhanGHanG9991 commented on a change in pull request #4220: ustzh complete session unsetSchemaTemplate method
Posted by GitBox <gi...@apache.org>.
ZhanGHanG9991 commented on a change in pull request #4220:
URL: https://github.com/apache/iotdb/pull/4220#discussion_r735233888
##########
File path: server/src/main/java/org/apache/iotdb/db/exception/metadata/DifferentTemplateException.java
##########
@@ -0,0 +1,17 @@
+package org.apache.iotdb.db.exception.metadata;
Review comment:
I have already added apache license in four new files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4220: ustzh complete session unsetSchemaTemplate method
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4220:
URL: https://github.com/apache/iotdb/pull/4220#issuecomment-950344802
[](https://coveralls.io/builds/43736771)
Coverage decreased (-0.3%) to 66.914% when pulling **ec5665c4d4cf122b9d24d7f32250f0f8f65de403 on ZhanGHanG9991:ustzh** into **d2e4d734caa3695d78501e888e32aac0a2cf22f2 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SilverNarcissus commented on a change in pull request #4220: ustzh complete session unsetSchemaTemplate method
Posted by GitBox <gi...@apache.org>.
SilverNarcissus commented on a change in pull request #4220:
URL: https://github.com/apache/iotdb/pull/4220#discussion_r735347368
##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##########
@@ -2133,6 +2140,30 @@ public synchronized void setSchemaTemplate(SetSchemaTemplatePlan plan) throws Me
}
}
+ public synchronized void unsetSchemaTemplate(UnsetSchemaTemplatePlan plan)
+ throws MetadataException {
+ // get mnode should be atomic
+ try {
+ PartialPath path = new PartialPath(plan.getPrefixPath());
+ IMNode node = mtree.getNodeByPath(path);
+ if (node.getSchemaTemplate() == null) {
Review comment:
You can use ```mvn spotless:apply``` to reformat your code~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ZhanGHanG9991 commented on a change in pull request #4220: ustzh complete session unsetSchemaTemplate method
Posted by GitBox <gi...@apache.org>.
ZhanGHanG9991 commented on a change in pull request #4220:
URL: https://github.com/apache/iotdb/pull/4220#discussion_r735226956
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/crud/UnsetSchemaTemplatePlan.java
##########
@@ -0,0 +1,80 @@
+package org.apache.iotdb.db.qp.physical.crud;
+
+import org.apache.iotdb.db.metadata.PartialPath;
+import org.apache.iotdb.db.qp.logical.Operator;
+import org.apache.iotdb.db.qp.physical.PhysicalPlan;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.List;
+
+/**
+ * @author zhanghang
+ * @date 2021/10/22 16:34
+ */
+public class UnsetSchemaTemplatePlan extends PhysicalPlan {
+
+ String prefixPath;
Review comment:
I have a look at other plan classes. They are all public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #4220: ustzh complete session unsetSchemaTemplate method
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4220:
URL: https://github.com/apache/iotdb/pull/4220#issuecomment-950344802
[](https://coveralls.io/builds/43724745)
Coverage increased (+0.01%) to 67.25% when pulling **4f397ceaab05d30a68220d1ce0d03d855b07c29f on ZhanGHanG9991:ustzh** into **d2e4d734caa3695d78501e888e32aac0a2cf22f2 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4220: ustzh complete session unsetSchemaTemplate method
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4220:
URL: https://github.com/apache/iotdb/pull/4220#issuecomment-950344802
[](https://coveralls.io/builds/43730821)
Coverage decreased (-0.2%) to 67.039% when pulling **aa278126fb464a85487076ce6131d4fcc6c169e6 on ZhanGHanG9991:ustzh** into **d2e4d734caa3695d78501e888e32aac0a2cf22f2 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SilverNarcissus merged pull request #4220: ustzh complete session unsetSchemaTemplate method
Posted by GitBox <gi...@apache.org>.
SilverNarcissus merged pull request #4220:
URL: https://github.com/apache/iotdb/pull/4220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org