You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/31 16:53:26 UTC
[GitHub] [tvm] rkimball opened a new pull request, #12664: Add methods to get and set late-bound constants.
rkimball opened a new pull request, #12664:
URL: https://github.com/apache/tvm/pull/12664
This PR adds methods to both get and set late-bound constants.
The current approach for saving and restoring a model's late-bound constants is via the either `MoveLateBoundConstantsToFile` and then this file can be reloaded to the Executable by calling `LoadLateBoundConstantsFromFile`. These methods save the constants to a file `consts`.
I have a need to save and restore the constants in a pre-existing format. In order to write these I added `GetLateBoundConstants` which returns a Map of all late-bound contants. To restore the constants back to the Executable `LoadLateBoundConstantsFromMap` was added.
The PR arranges the code so that both `GetLateBoundConstants` and `LoadLateBoundConstantsFromMap` are used in the existing methods to write and read late-bound constants. This means there is minimal code change, functions were mostly just rearranged to expose the two new entry points.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #12664: Add methods to get and set late-bound constants.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on PR #12664:
URL: https://github.com/apache/tvm/pull/12664#issuecomment-1234477071
This is now merged, thanks @rkimball!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm merged pull request #12664: Add methods to get and set late-bound constants.
Posted by GitBox <gi...@apache.org>.
jwfromm merged PR #12664:
URL: https://github.com/apache/tvm/pull/12664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] rkimball commented on pull request #12664: Add methods to get and set late-bound constants.
Posted by GitBox <gi...@apache.org>.
rkimball commented on PR #12664:
URL: https://github.com/apache/tvm/pull/12664#issuecomment-1233376288
Thank you Josh. I added some tests. Much of this new code is already tested as it is an integral part of the normal save/load. I added tests for the new API functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #12664: Add methods to get and set late-bound constants.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on PR #12664:
URL: https://github.com/apache/tvm/pull/12664#issuecomment-1233340528
Thanks @rkimball, this overall looks like a solid change. The one thing I'd like to see is the addition of some tests to make sure this works as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org