[jira] [Commented] (HBASE-23832) Old config hbase.hstore.compactionThreshold is ignored

["Anoop Sam John (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-23832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101621#comment-17101621 ] 

Anoop Sam John commented on HBASE-23832:
----------------------------------------

This is a BC break for the config name. Old configs will not get honored.  We should apply this patch to all active 2.x versions.  ping [~zhangduo], [~stack], [~zghao]

> Old config hbase.hstore.compactionThreshold is ignored
> ------------------------------------------------------
>
>                 Key: HBASE-23832
>                 URL: https://issues.apache.org/jira/browse/HBASE-23832
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Anoop Sam John
>            Assignee: Sambit Mohapatra
>            Priority: Major
>
> In 2.x we added new name 'hbase.hstore.compaction.min' for this.  Still for compatibility we allow the old config name and honor that in code
> {code}
> minFilesToCompact = Math.max(2, conf.getInt(HBASE_HSTORE_COMPACTION_MIN_KEY,
>           /*old name*/ conf.getInt("hbase.hstore.compactionThreshold", 3)));
> {code}
> But if hbase.hstore.compactionThreshold alone is configured by user, there is no impact of that.
> This is because in hbase-default.xml we have the new config with a value of 3. So the call conf.getInt(HBASE_HSTORE_COMPACTION_MIN_KEY) always return a value 3 even if it is not explicitly configured by customer and instead used the old key.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)