[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40353: [SPARK-42732][PYSPARK][CONNECT] Support spark connect session getActiveSession method

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #40353:
URL: https://github.com/apache/spark/pull/40353#discussion_r1135033374


##########
python/pyspark/sql/connect/session.py:
##########
@@ -427,7 +436,7 @@ def stop(self) -> None:
 
     @classmethod
     def getActiveSession(cls) -> Any:
-        raise NotImplementedError("getActiveSession() is not implemented.")

Review Comment:
   Can we don't expose this but use `_active_spark_session` in ML instead? The behaviour of this implementation is different from regular Spark (e.g., 1. actions like `collect` should set the active Spark Session but this PR doesn't. 2. options provided should be set even when there's an active session)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org