[GitHub] [incubator-doris] morningman commented on a diff in pull request #8903: [improvement](log) make compaction no suitable version log more friendly

[GitBox <gi...@apache.org>]

morningman commented on code in PR #8903:
URL: https://github.com/apache/incubator-doris/pull/8903#discussion_r845127727


##########
be/src/olap/olap_server.cpp:
##########
@@ -399,8 +399,16 @@ void StorageEngine::_compaction_tasks_producer_callback() {
             for (const auto& tablet : tablets_compaction) {
                 Status st = _submit_compaction_task(tablet, compaction_type);
                 if (!st.ok()) {
-                    LOG(WARNING) << "failed to submit compaction task for tablet: " << tablet->tablet_id()
-                        << ", err: " << st.get_error_msg();
+                    if (st.precise_code() == OLAP_ERR_BE_NO_SUITABLE_VERSION ||
+                        st.precise_code() == OLAP_ERR_CUMULATIVE_NO_SUITABLE_VERSION) {
+                        LOG(INFO) << "no suitable version for "

Review Comment:
   There will still be a lot of LOG in be.INFO.
   I modified this in #8887, FYI



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org