You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "airborne12 (via GitHub)" <gi...@apache.org> on 2026/10/01 08:15:06 UTC
[PR] [fix](be) Restore segment index expression unit tests [doris]
airborne12 opened a new pull request, #68695:
URL: https://github.com/apache/doris/pull/68695
### What problem does this PR solve?
Related PR: #61092
Problem Summary:
`SegmentIteratorApplyIndexExprTest` has been excluded from the BE unit test build since it was introduced. Its fixture creates a 100-row segment but leaves the candidate row bitmap empty. `_apply_index_expr()` skips virtual column index expressions when no rows remain, so seven cases never exercise their downgrade and error-propagation assertions.
This PR initializes the fixture bitmap with all segment rows and removes the test file from the CMake exclusion list. With only the CMake change, 7 of 11 cases failed locally. With both changes, all 11 pass.
### Release note
None
### Check List (For Author)
- Test
- [x] Unit Test: `GLIBC_COMPATIBILITY=OFF ./run-be-ut.sh -j64 --run -f 'SegmentIteratorApplyIndexExprTest.*'` (11 passed under ASAN).
- Behavior changed:
- [x] No. This restores BE unit test coverage.
- Does this need documentation?
- [x] No.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #68695:
URL: https://github.com/apache/doris/pull/68695#issuecomment-5927606643
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68695:
URL: https://github.com/apache/doris/pull/68695#issuecomment-5930633098
<details>
<summary>TPC-H: <b>Total hot run time: 27766 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0a99989e4d0fa1b3720bf8fbc5e8416515367d58, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17861 4196 3939 3939
q2 2162 376 295 295
q3 10098 1415 777 777
q4 4683 473 351 351
q5 7455 841 549 549
q6 179 172 138 138
q7 734 769 591 591
q8 9321 1466 1560 1466
q9 5410 4183 4160 4160
q10 6816 1309 1033 1033
q11 434 267 235 235
q12 636 406 288 288
q13 18094 2605 2029 2029
q14 263 260 235 235
q15 q16 728 718 662 662
q17 1730 1138 950 950
q18 6455 5575 5540 5540
q19 1149 1198 1018 1018
q20 476 388 268 268
q21 5373 3117 2951 2951
q22 425 367 291 291
Total cold run time: 100482 ms
Total hot run time: 27766 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4735 4606 4504 4504
q2 713 586 527 527
q3 4741 5211 4666 4666
q4 2186 2296 1449 1449
q5 4529 4534 4431 4431
q6 221 164 121 121
q7 1939 1736 1516 1516
q8 2284 2097 1943 1943
q9 7379 6882 6842 6842
q10 3633 3536 3047 3047
q11 507 369 337 337
q12 704 699 495 495
q13 2272 2620 1966 1966
q14 276 284 259 259
q15 q16 658 681 603 603
q17 7210 6688 6580 6580
q18 11899 10987 11770 10987
q19 1088 1047 1055 1047
q20 2218 2188 1901 1901
q21 4911 4043 4228 4043
q22 492 484 412 412
Total cold run time: 64595 ms
Total hot run time: 57676 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68695:
URL: https://github.com/apache/doris/pull/68695#issuecomment-5928079321
<details>
<summary>ClickBench: <b>Total hot run time: 24.07 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b781d9aa6127ccf0416205c6f09ff5c9e134e1b4, data reload: false
query1 0.01 0.00 0.01
query2 0.09 0.05 0.05
query3 0.26 0.13 0.13
query4 1.61 0.15 0.14
query5 0.25 0.22 0.23
query6 1.16 0.93 0.95
query7 0.04 0.01 0.01
query8 0.05 0.04 0.04
query9 0.39 0.34 0.33
query10 0.57 0.54 0.55
query11 0.21 0.14 0.14
query12 0.19 0.15 0.15
query13 0.47 0.46 0.45
query14 0.98 0.93 0.97
query15 0.60 0.60 0.58
query16 0.33 0.33 0.32
query17 1.10 1.06 1.06
query18 0.21 0.20 0.20
query19 2.03 1.97 1.96
query20 0.02 0.02 0.01
query21 15.48 0.21 0.15
query22 4.82 0.06 0.05
query23 16.15 0.31 0.14
query24 2.94 0.41 0.32
query25 0.11 0.06 0.04
query26 0.72 0.21 0.15
query27 0.04 0.03 0.03
query28 3.56 0.80 0.35
query29 12.51 4.13 3.25
query30 0.28 0.15 0.16
query31 2.77 0.56 0.31
query32 3.22 0.60 0.48
query33 3.16 3.19 3.22
query34 15.52 3.94 3.28
query35 3.24 3.21 3.22
query36 0.56 0.44 0.41
query37 0.09 0.06 0.07
query38 0.05 0.04 0.04
query39 0.04 0.03 0.03
query40 0.17 0.15 0.15
query41 0.08 0.03 0.03
query42 0.04 0.03 0.03
query43 0.05 0.03 0.03
Total cold run time: 96.17 s
Total hot run time: 24.07 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68695:
URL: https://github.com/apache/doris/pull/68695#issuecomment-5933469627
<details>
<summary>TPC-DS: <b>Total hot run time: 152399 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f397e66ecf0d299ebba36e51d96912685d43aa46, data reload: false
query5 4304 598 464 464
query6 423 207 205 205
query7 4841 563 299 299
query8 330 180 165 165
query9 8811 3959 3909 3909
query10 478 315 267 267
query11 5854 3553 3247 3247
query12 150 92 86 86
query13 1273 588 431 431
query14 6554 4533 4201 4201
query14_1 3950 3949 3986 3949
query15 202 212 178 178
query16 988 454 445 445
query17 927 675 543 543
query18 2438 465 331 331
query19 203 179 147 147
query20 84 80 79 79
query21 213 133 115 115
query22 12973 12961 12784 12784
query23 13988 12964 12506 12506
query23_1 12497 12541 12618 12541
query24 7298 1130 652 652
query24_1 694 731 724 724
query25 564 429 364 364
query26 1272 311 169 169
query27 2682 557 331 331
query28 4567 1953 1952 1952
query29 1658 741 529 529
query30 298 224 183 183
query31 896 771 647 647
query32 151 96 100 96
query33 500 311 240 240
query34 1202 1121 653 653
query35 720 749 633 633
query36 787 795 723 723
query37 143 108 93 93
query38 1829 1753 1674 1674
query39 719 702 672 672
query39_1 659 650 678 650
query40 223 123 102 102
query41 71 67 70 67
query42 96 96 94 94
query43 335 345 295 295
query44 1376 702 712 702
query45 201 184 162 162
query46 1063 1155 745 745
query47 1492 1518 1435 1435
query48 416 431 290 290
query49 581 399 289 289
query50 997 343 252 252
query51 10596 10451 10421 10421
query52 91 87 75 75
query53 248 263 171 171
query54 242 203 201 201
query55 80 72 67 67
query56 224 207 208 207
query57 1529 1457 1426 1426
query58 285 253 247 247
query59 1992 2066 1880 1880
query60 290 249 222 222
query61 165 143 136 136
query62 393 316 258 258
query63 211 175 170 170
query64 2771 972 791 791
query65 3487 3381 3422 3381
query66 1813 426 294 294
query67 20244 20159 19915 19915
query68 3174 1515 898 898
query69 460 305 262 262
query70 878 816 776 776
query71 305 225 212 212
query72 2634 2593 2232 2232
query73 823 762 429 429
query74 4643 4525 4311 4311
query75 2270 2273 1930 1930
query76 2302 1112 732 732
query77 360 396 297 297
query78 9048 9085 8426 8426
query79 1365 1219 745 745
query80 595 451 352 352
query81 544 323 279 279
query82 622 173 125 125
query83 306 219 186 186
query84 317 138 114 114
query85 844 447 370 370
query86 322 241 228 228
query87 2011 1996 1831 1831
query88 3597 2703 2680 2680
query89 367 285 243 243
query90 1927 181 175 175
query91 167 150 122 122
query92 101 91 91 91
query93 1513 1411 871 871
query94 528 325 283 283
query95 663 379 334 334
query96 1029 769 349 349
query97 2446 2402 2307 2307
query98 160 147 142 142
query99 719 732 607 607
Total cold run time: 236291 ms
Total hot run time: 152399 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #68695:
URL: https://github.com/apache/doris/pull/68695#discussion_r4153397500
##########
be/test/storage/segment/segment_iterator_apply_index_expr_test.cpp:
##########
@@ -119,6 +119,7 @@ class SegmentIteratorApplyIndexExprTest : public testing::Test {
// Read schema covers all tablet columns in order, so ordinal == tablet cid.
_read_schema = std::make_shared<ReadSchema>(_tablet_schema->columns());
_iter = std::make_unique<SegmentIterator>(_segment, _read_schema);
+ _iter->_row_bitmap.addRange(0, _segment->num_rows());
Review Comment:
[P2] Initialize the mock node type before enabling its evaluation. This bitmap now sends nine mock-backed cases through `evaluate_with_candidate_policy()`, which calls `root->is_virtual_slot_ref()` before the mock's `evaluate_inverted_index()`. `MockEvalExpr` sets only `_data_type`; the default `VExpr` constructor leaves `_node_type` uninitialized, so this comparison reads an indeterminate enum and may take the virtual-slot cast branch. Set a concrete nonvirtual node type in the mock constructor (for example, `TExprNodeType::MATCH_PRED`) so these enabled tests have defined behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68695:
URL: https://github.com/apache/doris/pull/68695#issuecomment-5933554911
<details>
<summary>ClickBench: <b>Total hot run time: 23.9 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f397e66ecf0d299ebba36e51d96912685d43aa46, data reload: false
query1 0.00 0.00 0.01
query2 0.10 0.04 0.05
query3 0.25 0.13 0.14
query4 1.61 0.15 0.14
query5 0.25 0.22 0.22
query6 1.16 0.93 0.94
query7 0.04 0.01 0.00
query8 0.05 0.04 0.03
query9 0.39 0.33 0.34
query10 0.60 0.54 0.59
query11 0.21 0.15 0.14
query12 0.19 0.15 0.15
query13 0.45 0.46 0.46
query14 0.96 0.97 0.95
query15 0.60 0.59 0.58
query16 0.30 0.30 0.31
query17 1.04 1.07 1.08
query18 0.22 0.20 0.19
query19 1.96 1.94 1.91
query20 0.03 0.01 0.01
query21 15.48 0.20 0.14
query22 4.87 0.06 0.04
query23 16.16 0.31 0.12
query24 3.03 0.43 0.32
query25 0.13 0.05 0.04
query26 0.72 0.20 0.15
query27 0.03 0.03 0.03
query28 3.50 0.78 0.33
query29 12.54 4.08 3.22
query30 0.30 0.17 0.15
query31 2.77 0.54 0.31
query32 3.22 0.59 0.48
query33 3.10 3.26 3.21
query34 15.57 3.94 3.27
query35 3.23 3.23 3.19
query36 0.54 0.42 0.42
query37 0.09 0.06 0.07
query38 0.06 0.04 0.04
query39 0.04 0.03 0.03
query40 0.18 0.15 0.14
query41 0.09 0.03 0.03
query42 0.03 0.02 0.03
query43 0.04 0.04 0.04
Total cold run time: 96.13 s
Total hot run time: 23.9 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #68695:
URL: https://github.com/apache/doris/pull/68695#issuecomment-5932734724
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 merged PR #68695:
URL: https://github.com/apache/doris/pull/68695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68695:
URL: https://github.com/apache/doris/pull/68695#issuecomment-5935954658
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/68695_f397e66ecf0d299ebba36e51d96912685d43aa46_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/68695_f397e66ecf0d299ebba36e51d96912685d43aa46_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 76.69% (35105/45778) |
| Line Coverage | 61.90% (396810/641054) |
| Region Coverage | 58.37% (335061/574038) |
| Branch Coverage | 59.19% (153874/259947) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68695:
URL: https://github.com/apache/doris/pull/68695#issuecomment-5944985680
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/68695_f397e66ecf0d299ebba36e51d96912685d43aa46_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/68695_f397e66ecf0d299ebba36e51d96912685d43aa46_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 76.69% (35105/45778) |
| Line Coverage | 61.90% (396810/641054) |
| Region Coverage | 58.37% (335061/574038) |
| Branch Coverage | 59.19% (153874/259947) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #68695:
URL: https://github.com/apache/doris/pull/68695#issuecomment-5932726646
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #68695:
URL: https://github.com/apache/doris/pull/68695#issuecomment-5927605476
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #68695:
URL: https://github.com/apache/doris/pull/68695#issuecomment-5930246439
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #68695:
URL: https://github.com/apache/doris/pull/68695#issuecomment-5930251740
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68695:
URL: https://github.com/apache/doris/pull/68695#issuecomment-5928006223
<details>
<summary>TPC-DS: <b>Total hot run time: 152568 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b781d9aa6127ccf0416205c6f09ff5c9e134e1b4, data reload: false
query5 4313 603 477 477
query6 426 207 201 201
query7 4881 586 298 298
query8 323 197 162 162
query9 8808 4000 3996 3996
query10 445 309 255 255
query11 5799 3548 3221 3221
query12 145 92 85 85
query13 1263 592 381 381
query14 6483 4565 4244 4244
query14_1 3971 4006 3944 3944
query15 204 203 186 186
query16 990 454 430 430
query17 904 666 546 546
query18 2453 484 320 320
query19 199 172 155 155
query20 82 76 79 76
query21 217 131 112 112
query22 13013 13005 12876 12876
query23 13881 12999 12551 12551
query23_1 12540 12552 12461 12461
query24 7207 1134 623 623
query24_1 637 740 761 740
query25 529 407 349 349
query26 1253 304 154 154
query27 2738 563 330 330
query28 4592 1953 1929 1929
query29 1629 704 508 508
query30 294 207 188 188
query31 884 746 628 628
query32 153 89 97 89
query33 526 311 235 235
query34 1200 1094 618 618
query35 712 784 639 639
query36 807 782 775 775
query37 140 105 88 88
query38 1814 1762 1696 1696
query39 698 710 668 668
query39_1 678 649 652 649
query40 219 121 97 97
query41 65 63 61 61
query42 100 99 93 93
query43 341 341 295 295
query44 1362 737 714 714
query45 179 178 163 163
query46 1086 1239 703 703
query47 1480 1496 1384 1384
query48 398 420 294 294
query49 592 411 287 287
query50 994 340 254 254
query51 10525 10236 10446 10236
query52 92 87 81 81
query53 254 261 175 175
query54 252 219 197 197
query55 83 77 68 68
query56 226 212 212 212
query57 1568 1345 1401 1345
query58 274 273 254 254
query59 1962 2059 1875 1875
query60 284 238 226 226
query61 151 151 153 151
query62 399 322 271 271
query63 217 177 173 173
query64 2795 1020 884 884
query65 3495 3391 3427 3391
query66 1856 432 334 334
query67 20144 20228 19872 19872
query68 3234 1501 909 909
query69 411 307 277 277
query70 911 852 857 852
query71 301 238 220 220
query72 2803 2634 2425 2425
query73 862 767 430 430
query74 4617 4504 4292 4292
query75 2291 2276 1942 1942
query76 2301 1112 743 743
query77 361 392 295 295
query78 9037 9040 8423 8423
query79 1370 1181 692 692
query80 574 455 356 356
query81 534 323 282 282
query82 640 163 119 119
query83 298 226 189 189
query84 312 148 111 111
query85 831 473 375 375
query86 328 234 232 232
query87 1978 1965 1830 1830
query88 3658 2727 2700 2700
query89 362 286 242 242
query90 1965 186 186 186
query91 171 154 129 129
query92 107 87 89 87
query93 1421 1373 812 812
query94 521 364 297 297
query95 677 434 429 429
query96 1060 800 362 362
query97 2459 2415 2349 2349
query98 164 151 143 143
query99 731 754 629 629
Total cold run time: 236120 ms
Total hot run time: 152568 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #68695:
URL: https://github.com/apache/doris/pull/68695#discussion_r4154908521
##########
be/test/storage/segment/segment_iterator_apply_index_expr_test.cpp:
##########
@@ -119,6 +122,7 @@ class SegmentIteratorApplyIndexExprTest : public testing::Test {
// Read schema covers all tablet columns in order, so ordinal == tablet cid.
_read_schema = std::make_shared<ReadSchema>(_tablet_schema->columns());
_iter = std::make_unique<SegmentIterator>(_segment, _read_schema);
+ _iter->_row_bitmap.addRange(0, _segment->num_rows());
Review Comment:
[P2] Make the null-context case prove that evaluation was skipped. Populating the bitmap now reaches the virtual-column loop, but this case gives its mock `Status::OK()` and only expects OK. If the `get_index_context() == nullptr` guard were removed, the mock would be evaluated and return OK, so the test would still pass. Configure that mock to return an unhandled error if called, or assert that its evaluation count remains zero.
##########
be/test/storage/segment/segment_iterator_apply_index_expr_test.cpp:
##########
@@ -119,6 +122,7 @@ class SegmentIteratorApplyIndexExprTest : public testing::Test {
// Read schema covers all tablet columns in order, so ordinal == tablet cid.
_read_schema = std::make_shared<ReadSchema>(_tablet_schema->columns());
_iter = std::make_unique<SegmentIterator>(_segment, _read_schema);
+ _iter->_row_bitmap.addRange(0, _segment->num_rows());
Review Comment:
[P2] Verify continuation after a handled downgrade. The mixed-results case puts an OK mock after the BYPASS mock, but checks only final OK and one downgrade. If the handled-error `continue` became `break`, the last virtual column would never be evaluated and both assertions would still pass. Assert an invocation of the last mock, or give it a second handled downgrade and expect a count of two.
##########
be/test/storage/segment/segment_iterator_apply_index_expr_test.cpp:
##########
@@ -119,6 +122,7 @@ class SegmentIteratorApplyIndexExprTest : public testing::Test {
// Read schema covers all tablet columns in order, so ordinal == tablet cid.
_read_schema = std::make_shared<ReadSchema>(_tablet_schema->columns());
_iter = std::make_unique<SegmentIterator>(_segment, _read_schema);
+ _iter->_row_bitmap.addRange(0, _segment->num_rows());
Review Comment:
[P2] Cover the disabled-fallback missing-index branch. This fixture sets `enable_fallback_on_missing_inverted_index` to true for every case, so the FILE_NOT_FOUND test only checks the downgrade path. If `&& is_fallback` were removed from `_downgrade_without_index`, a query with fallback disabled would silently downgrade, yet all 11 tests would still pass. Add a case with the option false that expects FILE_NOT_FOUND and zero downgrades.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68695:
URL: https://github.com/apache/doris/pull/68695#issuecomment-5933292246
<details>
<summary>TPC-H: <b>Total hot run time: 27973 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f397e66ecf0d299ebba36e51d96912685d43aa46, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17817 3948 3964 3948
q2 2193 389 305 305
q3 10042 1404 769 769
q4 4682 472 354 354
q5 7472 826 554 554
q6 176 166 136 136
q7 729 792 585 585
q8 9296 1523 1531 1523
q9 5383 4219 4179 4179
q10 6811 1313 1025 1025
q11 421 266 254 254
q12 635 419 300 300
q13 18051 2625 2028 2028
q14 254 251 241 241
q15 q16 732 714 678 678
q17 1793 1157 1003 1003
q18 6421 5558 5517 5517
q19 1160 1233 1068 1068
q20 492 385 255 255
q21 5373 3211 2940 2940
q22 424 351 311 311
Total cold run time: 100357 ms
Total hot run time: 27973 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4650 4513 4493 4493
q2 713 560 539 539
q3 4725 5252 4591 4591
q4 2247 2322 1468 1468
q5 4597 4537 4489 4489
q6 243 180 136 136
q7 1783 1712 1457 1457
q8 2331 2042 2020 2020
q9 7324 6843 6861 6843
q10 3625 3534 3069 3069
q11 514 368 337 337
q12 715 698 500 500
q13 2276 2583 2009 2009
q14 264 279 246 246
q15 q16 654 677 610 610
q17 7279 6692 6630 6630
q18 11896 11001 11811 11001
q19 1147 1035 1028 1028
q20 2200 2181 1904 1904
q21 5021 4097 4274 4097
q22 508 446 394 394
Total cold run time: 64712 ms
Total hot run time: 57861 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68695:
URL: https://github.com/apache/doris/pull/68695#issuecomment-5930791427
<details>
<summary>TPC-DS: <b>Total hot run time: 151477 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0a99989e4d0fa1b3720bf8fbc5e8416515367d58, data reload: false
query5 4304 582 490 490
query6 423 207 195 195
query7 4807 559 281 281
query8 318 176 181 176
query9 8820 3983 3969 3969
query10 452 297 253 253
query11 5856 3527 3215 3215
query12 159 87 85 85
query13 1259 603 418 418
query14 6507 4481 4203 4203
query14_1 3953 3888 3928 3888
query15 201 202 184 184
query16 994 476 462 462
query17 930 668 552 552
query18 2431 475 327 327
query19 209 187 142 142
query20 84 81 80 80
query21 235 138 115 115
query22 13371 12996 12739 12739
query23 13925 13110 12269 12269
query23_1 12679 12517 12616 12517
query24 7303 1104 643 643
query24_1 702 698 672 672
query25 571 437 370 370
query26 1275 317 161 161
query27 2688 536 331 331
query28 4537 1959 1941 1941
query29 1624 738 537 537
query30 303 221 185 185
query31 908 774 644 644
query32 151 99 102 99
query33 529 313 254 254
query34 1200 1110 617 617
query35 715 820 646 646
query36 766 801 735 735
query37 147 111 96 96
query38 1828 1757 1681 1681
query39 679 703 635 635
query39_1 655 655 647 647
query40 234 129 105 105
query41 73 69 68 68
query42 100 99 96 96
query43 338 343 297 297
query44 1381 734 745 734
query45 179 176 160 160
query46 1076 1283 709 709
query47 1489 1492 1417 1417
query48 392 413 274 274
query49 585 398 287 287
query50 963 348 251 251
query51 10561 10236 10302 10236
query52 88 87 74 74
query53 237 248 179 179
query54 248 209 185 185
query55 77 71 68 68
query56 218 209 203 203
query57 1485 1504 1281 1281
query58 282 258 244 244
query59 1969 2022 1858 1858
query60 272 246 208 208
query61 143 145 143 143
query62 402 317 265 265
query63 216 173 174 173
query64 2844 1002 808 808
query65 3477 3388 3396 3388
query66 1783 427 309 309
query67 20102 19986 19852 19852
query68 3080 1509 834 834
query69 423 300 259 259
query70 893 826 795 795
query71 293 229 212 212
query72 2682 2475 2249 2249
query73 825 730 400 400
query74 4620 4485 4274 4274
query75 2306 2258 1917 1917
query76 2312 1115 757 757
query77 350 402 292 292
query78 9054 8950 8402 8402
query79 1432 1118 749 749
query80 912 463 365 365
query81 576 320 276 276
query82 612 166 125 125
query83 296 215 193 193
query84 310 142 116 116
query85 879 475 378 378
query86 366 247 225 225
query87 1957 1968 1819 1819
query88 3626 2701 2718 2701
query89 363 281 242 242
query90 1813 186 181 181
query91 166 155 127 127
query92 93 89 86 86
query93 1524 1488 858 858
query94 617 337 303 303
query95 670 365 340 340
query96 1113 754 373 373
query97 2432 2420 2285 2285
query98 158 146 145 145
query99 723 731 624 624
Total cold run time: 236752 ms
Total hot run time: 151477 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68695:
URL: https://github.com/apache/doris/pull/68695#issuecomment-5930895218
<details>
<summary>ClickBench: <b>Total hot run time: 23.96 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0a99989e4d0fa1b3720bf8fbc5e8416515367d58, data reload: false
query1 0.00 0.00 0.01
query2 0.09 0.05 0.05
query3 0.26 0.14 0.13
query4 1.60 0.14 0.14
query5 0.24 0.22 0.22
query6 1.16 0.93 0.89
query7 0.04 0.01 0.01
query8 0.05 0.04 0.04
query9 0.39 0.34 0.33
query10 0.55 0.58 0.59
query11 0.20 0.15 0.14
query12 0.18 0.14 0.14
query13 0.47 0.47 0.47
query14 0.95 0.92 0.95
query15 0.59 0.59 0.58
query16 0.31 0.32 0.33
query17 1.10 1.11 1.10
query18 0.20 0.19 0.20
query19 2.08 1.90 1.88
query20 0.02 0.01 0.01
query21 15.48 0.18 0.13
query22 4.90 0.06 0.06
query23 16.13 0.30 0.12
query24 3.00 0.41 0.34
query25 0.11 0.04 0.04
query26 0.74 0.21 0.16
query27 0.04 0.04 0.03
query28 3.54 0.75 0.33
query29 12.50 4.04 3.23
query30 0.28 0.15 0.15
query31 2.77 0.55 0.31
query32 3.22 0.58 0.48
query33 3.09 3.17 3.14
query34 15.52 3.91 3.28
query35 3.24 3.23 3.23
query36 0.57 0.43 0.43
query37 0.10 0.07 0.06
query38 0.05 0.04 0.04
query39 0.04 0.03 0.03
query40 0.17 0.15 0.15
query41 0.08 0.02 0.02
query42 0.04 0.03 0.03
query43 0.04 0.03 0.04
Total cold run time: 96.13 s
Total hot run time: 23.96 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Restore segment index expression unit tests [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68695:
URL: https://github.com/apache/doris/pull/68695#issuecomment-5927854327
<details>
<summary>TPC-H: <b>Total hot run time: 28206 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b781d9aa6127ccf0416205c6f09ff5c9e134e1b4, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17601 4122 4033 4033
q2 2201 382 317 317
q3 10022 1445 804 804
q4 4688 478 357 357
q5 7547 840 553 553
q6 190 172 141 141
q7 754 776 606 606
q8 9309 1545 1548 1545
q9 5556 4234 4264 4234
q10 6826 1342 1044 1044
q11 430 273 234 234
q12 635 416 298 298
q13 18102 2602 2012 2012
q14 259 266 241 241
q15 q16 715 710 656 656
q17 1706 1054 993 993
q18 6467 5588 5577 5577
q19 1166 1322 1003 1003
q20 532 396 257 257
q21 5427 3381 2992 2992
q22 470 379 309 309
Total cold run time: 100603 ms
Total hot run time: 28206 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4758 4718 4758 4718
q2 714 575 549 549
q3 4799 5142 4601 4601
q4 2244 2326 1445 1445
q5 4829 4424 4653 4424
q6 226 177 130 130
q7 1798 1700 1566 1566
q8 2422 2081 2011 2011
q9 7326 7289 7304 7289
q10 3714 3610 3085 3085
q11 526 396 400 396
q12 710 711 529 529
q13 2278 2590 2021 2021
q14 267 284 262 262
q15 q16 663 684 603 603
q17 7289 6738 6679 6679
q18 11907 11030 11796 11030
q19 1126 1032 1009 1009
q20 2217 2192 1918 1918
q21 5005 4300 4620 4300
q22 518 448 414 414
Total cold run time: 65336 ms
Total hot run time: 58979 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org