[jira] [Commented] (OAK-6304) Cyclic dependency between oak.spi.query an oak.query.*

["angela (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-6304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034788#comment-16034788 ] 

angela commented on OAK-6304:
-----------------------------

another example: {{o.a.j.oak.spi.query.QueryIndex.FulltextQueryIndex}} defines {{NodeAggregator getNodeAggregator();}} but the {{NodeAggregator}} is not part of the query spi but rather defined in the {{o.a.j.oak.plugins.index.aggregate}} package space which additionally contains implementations which i would assume are not intended for public consumption.

> Cyclic dependency between oak.spi.query an oak.query.*
> ------------------------------------------------------
>
>                 Key: OAK-6304
>                 URL: https://issues.apache.org/jira/browse/OAK-6304
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: core, indexing, query
>            Reporter: angela
>
> while working on OAK-6069 i noticed that there exist IMO troublesome dependencies from _o.a.j.oak.spi.query_ back to _o.a.j.oak.query.*_. While i don't know the historical reasons that led to this setup it feels wrong to me that the interfaces and classes in _o.a.j.oak.spi.query_ would have dependencies to packages that from my understanding are supposed to contain implementations.
> while utilities like {{o.a.j.oak.spi.query.Cursors}} may simply have ended up in the wrong bucket and could possibly moved to e.g _o.a.j.query.index_, i couldn't find an easy solution for an interface like  {{o.a.j.oak.spi.query.Filter}} that defines methods returning {{o.a.j.query.fulltext.FullTextExpression}} and {{o.a.j.query.QueryEngineSettings}}, while at the same time being tied to the {{o.a.j.oak.spi.query.QueryIndex}} interface.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)