You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by zh...@gmail.com on 2010/06/15 02:48:15 UTC

Adding hostname configuration option for Concat and Proxy rewriters (issue1672041)

http://codereview.appspot.com/1672041/diff/2001/3005
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java
(right):

http://codereview.appspot.com/1672041/diff/2001/3005#newcode110
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java:110:
uriBuilder.setScheme(getReqVal(ctx.getContainer(),
CONCAT_SCHEME_PARAM));
I don't think you want to add schema to rewrited url.
By default the browser will use the current page schema for any url in
the page.
This way if the served page is using https scheme, all internal
pages/links will be too.
Same comment applied to proxy too.

http://codereview.appspot.com/1672041/show