[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments

[GitBox <gi...@apache.org>]

sunithabeeram commented on a change in pull request #4229: Emit freshnessLag metric from broker for queries hitting consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4229#discussion_r286309018
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
 ##########
 @@ -170,11 +170,13 @@ public DataTable processQuery(ServerQueryRequest queryRequest, ExecutorService e
       }
     }
 
-    long minConsumingFreshnessTimeMs = Long.MAX_VALUE;
+    long minConsumingFreshnessTimeMs = -1;
 
 Review comment:
   I thought I was logging it regardless, but it does go through the dataTable between the ServerV1Impl and QueryScheduler where it is logged. Will remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org