[GitHub] tflobbe commented on a change in pull request #444: SOLR-12708: Aggregate failures from downstream async jobs; add error …

[GitBox <gi...@apache.org>]

tflobbe commented on a change in pull request #444: SOLR-12708: Aggregate failures from downstream async jobs; add error …
URL: https://github.com/apache/lucene-solr/pull/444#discussion_r256251868
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/cloud/api/collections/RestoreCmd.java
 ##########
 @@ -271,7 +278,37 @@ public void call(ClusterState state, ZkNodeProps message, NamedList results) thr
           propMap.put(ASYNC, asyncId);
         }
         ocmh.addPropertyParams(message, propMap);
-        ocmh.addReplica(clusterState, new ZkNodeProps(propMap), new NamedList(), null);
+        final NamedList addResult = new NamedList();
+        ocmh.addReplica(clusterState, new ZkNodeProps(propMap), addResult, () -> {
+          countDownLatch.countDown();
 
 Review comment:
   I think we should move this to the end of the callback, or there can be a race condition

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org