You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2026/08/31 12:20:57 UTC
[PR] SOLR-17995: Deprecate "core URL" SolrStream constructors [solr]
gerlowskija opened a new pull request, #4830:
URL: https://github.com/apache/solr/pull/4830
# Description
Due to some recent additions, SolrStream currently has 4 different constructors in order to support taking in either "base" URLs or "core" URLs. This is a bit ugly.
# Solution
This PR streamlines this by deprecating the "core URL" constructors and switching usages over to using the "base URL" constructors instead. The "core URLs" aren't removed entirely, though this can be done (on `main` only) in a subsequent PR.
# Tests
Existing tests continue to pass.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17995: Deprecate "core URL" SolrStream constructors [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #4830:
URL: https://github.com/apache/solr/pull/4830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17995: Deprecate "core URL" SolrStream constructors [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on code in PR #4830:
URL: https://github.com/apache/solr/pull/4830#discussion_r3894714039
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/SolrStream.java:
##########
@@ -69,13 +69,13 @@ public class SolrStream extends TupleStream {
private transient SolrClientCache clientCache;
private transient boolean doCloseCache;
- // TODO SOLR-17995 proposes that we should deprecate this constructor in favor of one of the other
- // constructors that requires users to provide the core as an explicit parameter
/**
* @param collectionOrCoreUrl URL of the Solr core or collection to query, typically of the form
* "http://host:8983/solr/myCore".
* @param params query-parameters sent with the streaming request
+ * @deprecated since 10.1. Use base URL constructor instead.
*/
+ @Deprecated
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17995: Deprecate "core URL" SolrStream constructors [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #4830:
URL: https://github.com/apache/solr/pull/4830#issuecomment-5478839389
FYI @dsmiley - I believe you asked about consolidating some of these ctors on a QT-removal PR...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17995: Deprecate "core URL" SolrStream constructors [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #4830:
URL: https://github.com/apache/solr/pull/4830#discussion_r3894391194
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/SolrStream.java:
##########
@@ -69,13 +69,13 @@ public class SolrStream extends TupleStream {
private transient SolrClientCache clientCache;
private transient boolean doCloseCache;
- // TODO SOLR-17995 proposes that we should deprecate this constructor in favor of one of the other
- // constructors that requires users to provide the core as an explicit parameter
/**
* @param collectionOrCoreUrl URL of the Solr core or collection to query, typically of the form
* "http://host:8983/solr/myCore".
* @param params query-parameters sent with the streaming request
+ * @deprecated since 10.1. Use base URL constructor instead.
*/
+ @Deprecated
Review Comment:
I think we shold use the `since` annotation on the `@Deprecated`instead of int he text...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org