[GitHub] [incubator-teaclave] mssun commented on a diff in pull request #665: Bugfix of leveldb and rust sdk

[GitBox <gi...@apache.org>]

mssun commented on code in PR #665:
URL: https://github.com/apache/incubator-teaclave/pull/665#discussion_r1017405969


##########
common/rusty_leveldb_sgx/src/db_impl.rs:
##########
@@ -310,6 +314,10 @@ impl DB {
         let files = self.vset.borrow().live_files();
         let filenames = self.opt.env.children(Path::new(&self.path))?;
         for name in filenames {
+            if name.to_str().unwrap().ends_with(SGX_RECOVERY_FILE_SUFFIX) {

Review Comment:
   Can you use `?` here to propagate the error?



##########
common/rusty_leveldb_sgx/src/db_impl.rs:
##########
@@ -191,6 +191,10 @@ impl DB {
         let mut log_files = vec![];
 
         for file in &filenames {
+            if file.to_str().unwrap().ends_with(SGX_RECOVERY_FILE_SUFFIX) {

Review Comment:
   Can you use `?` here to propagate the error?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org