You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dkim010 (via GitHub)" <gi...@apache.org> on 2023/09/06 04:14:29 UTC
[GitHub] [airflow] dkim010 opened a new pull request, #34127: Remove duplicated logs by reusing PodLogsConsumer
dkim010 opened a new pull request, #34127:
URL: https://github.com/apache/airflow/pull/34127
* reuse the kubernetes connection not to re-consume the logs
* If a failure occurs while consuming logs through `PodLogsConsumer`, a new `PodLogsConsumer` is created.
* But, at this time there are duplicated logs even though they have already been consumed.
* To fix the duplicated logs, `PodLogsConsumer` instance is created initially at once and is to reused
when a failure occurs to prevent duplicate logs from occurring.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dkim010 commented on a diff in pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "dkim010 (via GitHub)" <gi...@apache.org>.
dkim010 commented on code in PR #34127:
URL: https://github.com/apache/airflow/pull/34127#discussion_r1334905412
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -403,16 +407,17 @@ def consume_logs(
"""
last_captured_timestamp = None
try:
- logs = self.read_pod_logs(
- pod=pod,
- container_name=container_name,
- timestamps=True,
- since_seconds=(
- math.ceil((pendulum.now() - since_time).total_seconds()) if since_time else None
- ),
- follow=follow,
- post_termination_timeout=termination_timeout,
- )
+ if not logs:
Review Comment:
I am still waiting! Would you review again? @hussein-awala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dkim010 commented on pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "dkim010 (via GitHub)" <gi...@apache.org>.
dkim010 commented on PR #34127:
URL: https://github.com/apache/airflow/pull/34127#issuecomment-1733839586
@hussein-awala Hussein, I am still waiting~~!!
If this pull request should have more supplements, please tell me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dkim010 commented on a diff in pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "dkim010 (via GitHub)" <gi...@apache.org>.
dkim010 commented on code in PR #34127:
URL: https://github.com/apache/airflow/pull/34127#discussion_r1328604893
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -403,16 +407,17 @@ def consume_logs(
"""
last_captured_timestamp = None
try:
- logs = self.read_pod_logs(
- pod=pod,
- container_name=container_name,
- timestamps=True,
- since_seconds=(
- math.ceil((pendulum.now() - since_time).total_seconds()) if since_time else None
- ),
- follow=follow,
- post_termination_timeout=termination_timeout,
- )
+ if not logs:
Review Comment:
Okay, I will request again after writing a unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #34127:
URL: https://github.com/apache/airflow/pull/34127#discussion_r1323743308
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -388,7 +388,7 @@ def fetch_container_logs(
before=before_log(self.log, logging.INFO),
)
def consume_logs(
- *, since_time: DateTime | None = None, follow: bool = True, termination_timeout: int = 120
+ *, logs: PodLogsConsumer
Review Comment:
> It's an internal method in "fetch_container_logs" - it can't be used from outside :)
But my point is different @hussein-awala ... the modified method is an internal method of another method. If you reveal what's before, you will see something lke that:
```
def fetch_container_logs( # <-- THIS IS THE "external" method that "consume_logs" is defined insde of
self,
pod: V1Pod,
container_name: str,
*,
follow=False,
since_time: DateTime | None = None,
post_termination_timeout: int = 120,
) -> PodLoggingStatus:
"""
Follows the logs of container and streams to airflow logging.
Returns when container exits.
Between when the pod starts and logs being available, there might be a delay due to CSR not approved
and signed yet. In such situation, ApiException is thrown. This is why we are retrying on this
specific exception.
"""
@tenacity.retry(
retry=tenacity.retry_if_exception_type(ApiException),
stop=tenacity.stop_after_attempt(10),
wait=tenacity.wait_fixed(1),
before=before_log(self.log, logging.INFO),
)
def consume_logs( # <---- THIS IS THE METHOD WE MODIFY (it's internal method of "fetch_container_logs"
*,
since_time: DateTime | None = None,
follow: bool = True,
termination_timeout: int = 120,
logs: PodLogsConsumer | None,
) -> tuple[DateTime | None, PodLogsConsumer | None]:
```
There is no way you can call "consume_logs" from outside. It only makes sense if you call it as part of "fetch_consume_logs". So this is really not even an interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #34127:
URL: https://github.com/apache/airflow/pull/34127#discussion_r1323744552
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -388,7 +388,7 @@ def fetch_container_logs(
before=before_log(self.log, logging.INFO),
)
def consume_logs(
- *, since_time: DateTime | None = None, follow: bool = True, termination_timeout: int = 120
+ *, logs: PodLogsConsumer
Review Comment:
See the indentation above @hussein-awala - maybe you just missed it :) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #34127:
URL: https://github.com/apache/airflow/pull/34127#discussion_r1319605126
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -388,7 +388,7 @@ def fetch_container_logs(
before=before_log(self.log, logging.INFO),
)
def consume_logs(
- *, since_time: DateTime | None = None, follow: bool = True, termination_timeout: int = 120
+ *, logs: PodLogsConsumer
Review Comment:
Cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #34127:
URL: https://github.com/apache/airflow/pull/34127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dkim010 commented on a diff in pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "dkim010 (via GitHub)" <gi...@apache.org>.
dkim010 commented on code in PR #34127:
URL: https://github.com/apache/airflow/pull/34127#discussion_r1328819350
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -403,16 +407,17 @@ def consume_logs(
"""
last_captured_timestamp = None
try:
- logs = self.read_pod_logs(
- pod=pod,
- container_name=container_name,
- timestamps=True,
- since_seconds=(
- math.ceil((pendulum.now() - since_time).total_seconds()) if since_time else None
- ),
- follow=follow,
- post_termination_timeout=termination_timeout,
- )
+ if not logs:
Review Comment:
> Did you have the opportunity to test it?
Yes, I am using the airflow applied this patch and checked that there is no duplicated logs.
---
I added a test case to check whether the PodLogsConsumer is reused correctly and there are no duplicated logs both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #34127:
URL: https://github.com/apache/airflow/pull/34127#discussion_r1323743308
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -388,7 +388,7 @@ def fetch_container_logs(
before=before_log(self.log, logging.INFO),
)
def consume_logs(
- *, since_time: DateTime | None = None, follow: bool = True, termination_timeout: int = 120
+ *, logs: PodLogsConsumer
Review Comment:
> the public interface documentation is only valid for Airflow core, but for the providers, from what I've seen, all public classes/methods should be updated without any breaking change, except if we want to create a new major version.
But my point is different @hussein-awala ... the modified method is an internal method of another method. If you reveal what's before, you will see something lke that:
```
def fetch_container_logs( # <-- THIS IS THE "external" method that "consume_logs" is defined insde of
self,
pod: V1Pod,
container_name: str,
*,
follow=False,
since_time: DateTime | None = None,
post_termination_timeout: int = 120,
) -> PodLoggingStatus:
"""
Follows the logs of container and streams to airflow logging.
Returns when container exits.
Between when the pod starts and logs being available, there might be a delay due to CSR not approved
and signed yet. In such situation, ApiException is thrown. This is why we are retrying on this
specific exception.
"""
@tenacity.retry(
retry=tenacity.retry_if_exception_type(ApiException),
stop=tenacity.stop_after_attempt(10),
wait=tenacity.wait_fixed(1),
before=before_log(self.log, logging.INFO),
)
def consume_logs( # <---- THIS IS THE METHOD WE MODIFY (it's internal method of "fetch_container_logs"
*,
since_time: DateTime | None = None,
follow: bool = True,
termination_timeout: int = 120,
logs: PodLogsConsumer | None,
) -> tuple[DateTime | None, PodLogsConsumer | None]:
```
There is no way you can call "consume_logs" from outside. It only makes sense if you call it as part of "fetch_consume_logs". So this is really not even an interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on a diff in pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #34127:
URL: https://github.com/apache/airflow/pull/34127#discussion_r1328128806
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -388,7 +388,7 @@ def fetch_container_logs(
before=before_log(self.log, logging.INFO),
)
def consume_logs(
- *, since_time: DateTime | None = None, follow: bool = True, termination_timeout: int = 120
+ *, logs: PodLogsConsumer
Review Comment:
> See the indentation above @hussein-awala - maybe you just missed it :) ?
You're right, it's internal and the change should be safe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #34127:
URL: https://github.com/apache/airflow/pull/34127#issuecomment-1707628845
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on a diff in pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #34127:
URL: https://github.com/apache/airflow/pull/34127#discussion_r1328130663
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -403,16 +407,17 @@ def consume_logs(
"""
last_captured_timestamp = None
try:
- logs = self.read_pod_logs(
- pod=pod,
- container_name=container_name,
- timestamps=True,
- since_seconds=(
- math.ceil((pendulum.now() - since_time).total_seconds()) if since_time else None
- ),
- follow=follow,
- post_termination_timeout=termination_timeout,
- )
+ if not logs:
Review Comment:
I'm not sure if reusing the same `PodLogsConsumer` would fix the issue.
The next time when you reuse it, it will call the method `__iter__` and then all the other methods as if it's a new `PodLogsConsumer` instance.
Did you have the opportunity to test it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dkim010 commented on pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "dkim010 (via GitHub)" <gi...@apache.org>.
dkim010 commented on PR #34127:
URL: https://github.com/apache/airflow/pull/34127#issuecomment-1741924836
@jedcunningham Would you review this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #34127:
URL: https://github.com/apache/airflow/pull/34127#issuecomment-1742016883
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on a diff in pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #34127:
URL: https://github.com/apache/airflow/pull/34127#discussion_r1320219097
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -388,7 +388,7 @@ def fetch_container_logs(
before=before_log(self.log, logging.INFO),
)
def consume_logs(
- *, since_time: DateTime | None = None, follow: bool = True, termination_timeout: int = 120
+ *, logs: PodLogsConsumer
Review Comment:
I disagree with @potiuk, the public interface documentation is only valid for Airflow core, but for the providers, from what I've seen, all public classes/methods should be updated without any breaking change, except if we want to create a new major version.
IMHO this is a breaking change, and the bug could (and should) be fixed in a backward compatible way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #34127:
URL: https://github.com/apache/airflow/pull/34127#discussion_r1319588813
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -388,7 +388,7 @@ def fetch_container_logs(
before=before_log(self.log, logging.INFO),
)
def consume_logs(
- *, since_time: DateTime | None = None, follow: bool = True, termination_timeout: int = 120
+ *, logs: PodLogsConsumer
Review Comment:
It's an internal method in "fetch_container_logs" - it can't be used from outside :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #34127:
URL: https://github.com/apache/airflow/pull/34127#discussion_r1319397360
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -388,7 +388,7 @@ def fetch_container_logs(
before=before_log(self.log, logging.INFO),
)
def consume_logs(
- *, since_time: DateTime | None = None, follow: bool = True, termination_timeout: int = 120
+ *, logs: PodLogsConsumer
Review Comment:
I'm not sure if `pod_manager.py` is part of our public API? cc @hussein-awala ?
should we consider this as a breaking change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dkim010 commented on a diff in pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "dkim010 (via GitHub)" <gi...@apache.org>.
dkim010 commented on code in PR #34127:
URL: https://github.com/apache/airflow/pull/34127#discussion_r1331126620
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -403,16 +407,17 @@ def consume_logs(
"""
last_captured_timestamp = None
try:
- logs = self.read_pod_logs(
- pod=pod,
- container_name=container_name,
- timestamps=True,
- since_seconds=(
- math.ceil((pendulum.now() - since_time).total_seconds()) if since_time else None
- ),
- follow=follow,
- post_termination_timeout=termination_timeout,
- )
+ if not logs:
Review Comment:
@hussein-awala I am waiting again :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dkim010 commented on pull request #34127: Remove duplicated logs by reusing PodLogsConsumer
Posted by "dkim010 (via GitHub)" <gi...@apache.org>.
dkim010 commented on PR #34127:
URL: https://github.com/apache/airflow/pull/34127#issuecomment-1722538127
I am waiting! Would you review this pull request? @hussein-awala @jedcunningham
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org