You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/11 04:56:47 UTC
[GitHub] [incubator-shardingsphere] sunbufu opened a new pull request #3933:
rename new orchestration module.
sunbufu opened a new pull request #3933: rename new orchestration module.
URL: https://github.com/apache/incubator-shardingsphere/pull/3933
Fixes #3185.
Changes proposed in this pull request:
- Rename new orchestration module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl merged pull request #3933: rename
new orchestration module.
Posted by GitBox <gi...@apache.org>.
dongzl merged pull request #3933: rename new orchestration module.
URL: https://github.com/apache/incubator-shardingsphere/pull/3933
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull
request #3933: rename new orchestration module.
Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #3933: rename new orchestration module.
URL: https://github.com/apache/incubator-shardingsphere/pull/3933#discussion_r365552814
##########
File path: sharding-jdbc/sharding-jdbc-orchestration/src/test/java/org/apache/shardingsphere/shardingjdbc/orchestration/util/TestConfigCenter2.java
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.shardingjdbc.orchestration.util;
+
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Properties;
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.shardingsphere.orchestration.center.api.ConfigCenter;
+import org.apache.shardingsphere.orchestration.center.configuration.InstanceConfiguration;
+import org.apache.shardingsphere.orchestration.center.listener.DataChangedEventListener;
+
+public final class TestConfigCenter2 implements ConfigCenter {
Review comment:
The same to above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] wgy8283335 commented on a change in pull
request #3933: rename new orchestration module.
Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #3933: rename new orchestration module.
URL: https://github.com/apache/incubator-shardingsphere/pull/3933#discussion_r365507084
##########
File path: sharding-orchestration/sharding-orchestration-core/src/test/resources/META-INF/services/org.apache.shardingsphere.orchestration.center.api.DistributedLockManagement
##########
@@ -15,5 +15,6 @@
# limitations under the License.
#
-org.apache.shardingsphere.orchestration.temp.internal.registry.fixture.FirstTestRegistryCenter
-org.apache.shardingsphere.orchestration.temp.internal.registry.fixture.SecondTestRegistryCenter
+org.apache.shardingsphere.orchestration.internal.registry.fixture.FifthTestRegistryCenter
Review comment:
Shall these three TestRegistryCenter be renamed as TestDistributedLockManagement?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] wgy8283335 commented on a change in pull
request #3933: rename new orchestration module.
Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #3933: rename new orchestration module.
URL: https://github.com/apache/incubator-shardingsphere/pull/3933#discussion_r365507082
##########
File path: sharding-orchestration/sharding-orchestration-core/src/test/resources/META-INF/services/org.apache.shardingsphere.orchestration.center.api.DistributedLockManagement
##########
@@ -15,5 +15,6 @@
# limitations under the License.
#
-org.apache.shardingsphere.orchestration.temp.internal.registry.fixture.FirstTestRegistryCenter
-org.apache.shardingsphere.orchestration.temp.internal.registry.fixture.SecondTestRegistryCenter
+org.apache.shardingsphere.orchestration.internal.registry.fixture.FifthTestRegistryCenter
Review comment:
Shall these three TestRegistryCenter be renamed as TestDistributedLockManagement?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] wgy8283335 commented on a change in pull
request #3933: rename new orchestration module.
Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #3933: rename new orchestration module.
URL: https://github.com/apache/incubator-shardingsphere/pull/3933#discussion_r365506921
##########
File path: sharding-jdbc/sharding-jdbc-orchestration/src/test/resources/META-INF/services/org.apache.shardingsphere.orchestration.center.api.ConfigCenter
##########
@@ -15,6 +15,7 @@
# limitations under the License.
#
-org.apache.shardingsphere.orchestration.temp.internal.registry.fixture.FifthTestRegistryCenter
-org.apache.shardingsphere.orchestration.temp.internal.registry.fixture.ThirdTestRegistryCenter
-org.apache.shardingsphere.orchestration.temp.internal.registry.fixture.ForthTestRegistryCenter
+org.apache.shardingsphere.shardingjdbc.orchestration.util.TestRegistryCenter
Review comment:
As for ConfigCenter, shall these four TestRegistryCenters be renamed as TestConfigCenter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull
request #3933: rename new orchestration module.
Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #3933: rename new orchestration module.
URL: https://github.com/apache/incubator-shardingsphere/pull/3933#discussion_r365552807
##########
File path: sharding-jdbc/sharding-jdbc-orchestration/src/test/java/org/apache/shardingsphere/shardingjdbc/orchestration/util/TestConfigCenter1.java
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.shardingjdbc.orchestration.util;
+
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Properties;
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.shardingsphere.orchestration.center.api.ConfigCenter;
+import org.apache.shardingsphere.orchestration.center.configuration.InstanceConfiguration;
+import org.apache.shardingsphere.orchestration.center.listener.DataChangedEventListener;
+
+public final class TestConfigCenter1 implements ConfigCenter {
Review comment:
I suggest these files name can be `FirstTestConfigCenter`, `SecondTestConfigCenter` and so on, they are
name unification with `RegistryCenter` and `DistributeLockManagement` test class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull
request #3933: rename new orchestration module.
Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #3933: rename new orchestration module.
URL: https://github.com/apache/incubator-shardingsphere/pull/3933#discussion_r365552824
##########
File path: sharding-jdbc/sharding-jdbc-orchestration/src/test/java/org/apache/shardingsphere/shardingjdbc/orchestration/util/TestConfigCenter3.java
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.shardingjdbc.orchestration.util;
+
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Properties;
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.shardingsphere.orchestration.center.api.ConfigCenter;
+import org.apache.shardingsphere.orchestration.center.configuration.InstanceConfiguration;
+import org.apache.shardingsphere.orchestration.center.listener.DataChangedEventListener;
+
+public final class TestConfigCenter3 implements ConfigCenter {
Review comment:
The same to above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] wgy8283335 commented on a change in pull
request #3933: rename new orchestration module.
Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #3933: rename new orchestration module.
URL: https://github.com/apache/incubator-shardingsphere/pull/3933#discussion_r365507082
##########
File path: sharding-orchestration/sharding-orchestration-core/src/test/resources/META-INF/services/org.apache.shardingsphere.orchestration.center.api.DistributedLockManagement
##########
@@ -15,5 +15,6 @@
# limitations under the License.
#
-org.apache.shardingsphere.orchestration.temp.internal.registry.fixture.FirstTestRegistryCenter
-org.apache.shardingsphere.orchestration.temp.internal.registry.fixture.SecondTestRegistryCenter
+org.apache.shardingsphere.orchestration.internal.registry.fixture.FifthTestRegistryCenter
Review comment:
Shall these three TestRegistryCenter be renamed as TestDistributedLockManagement
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services