You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/11/23 16:50:04 UTC

[GitHub] [kafka] cadonna opened a new pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

cadonna opened a new pull request #11532:
URL: https://github.com/apache/kafka/pull/11532


   Log messages were changed in the AssignorConfiguration that are
   also used for verification in system test
   StreamsCooperativeRebalanceUpgradeTest.test_upgrade_to_cooperative_rebalance.
   
   This commit fixes the test and adds comments to the log messages
   that point to the test that needs to be updated in case of
   changes to the log messages.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cadonna commented on pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #11532:
URL: https://github.com/apache/kafka/pull/11532#issuecomment-976843320


   Call for review: @showuon, @ableegoldman


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11532:
URL: https://github.com/apache/kafka/pull/11532#issuecomment-977035425


   @cadonna Could we mention the commit which changed it in the description?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11532:
URL: https://github.com/apache/kafka/pull/11532#issuecomment-977436124


   > @cadonna Could we mention the commit which changed it in the description?
   
   This issue is caused by the PR https://github.com/apache/kafka/pull/11490 changed log message. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cadonna commented on pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #11532:
URL: https://github.com/apache/kafka/pull/11532#issuecomment-979042278


   Cherry-picked to 3.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11532:
URL: https://github.com/apache/kafka/pull/11532#issuecomment-977155971


   @cadonna LGTM. Could you cherry-pick it to 3.1 as well? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cadonna commented on pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #11532:
URL: https://github.com/apache/kafka/pull/11532#issuecomment-976849574


   The system test passes locally with this fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cadonna commented on pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #11532:
URL: https://github.com/apache/kafka/pull/11532#issuecomment-979038595


   Test failures are unrelated since only comments were added to the production code and the system tests are not executed during a build.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cadonna merged pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

Posted by GitBox <gi...@apache.org>.
cadonna merged pull request #11532:
URL: https://github.com/apache/kafka/pull/11532


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11532:
URL: https://github.com/apache/kafka/pull/11532#issuecomment-977433641


   > @cadonna LGTM. Could you cherry-pick it to 3.1 as well? Thanks.
   
   I agree this PR to be cherry-pick into 3.1 branch since it'll also affect 3.1. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cadonna commented on pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #11532:
URL: https://github.com/apache/kafka/pull/11532#issuecomment-978990529


   @showuon It happened to all of us at least once.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cadonna commented on pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #11532:
URL: https://github.com/apache/kafka/pull/11532#issuecomment-978991581


   > 
   
   @dajac Yes, I will cherry-pick it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org