[GitHub] krissterckx commented on a change in pull request #2460: CLOUDSTACK-10298: fix for recreation of an earlier deleted Nuage managed network

[GitBox <gi...@apache.org>]

krissterckx commented on a change in pull request #2460: CLOUDSTACK-10298: fix for recreation of an earlier deleted Nuage managed network
URL: https://github.com/apache/cloudstack/pull/2460#discussion_r169284527
 
 

 ##########
 File path: test/integration/plugins/nuagevsp/test_nuage_vsp_mngd_subnets.py
 ##########
 @@ -175,94 +207,148 @@ def test_01_nuage_mngd_subnets_isonw(self):
         zone1 = self.create_vsd_zone(domain1, "ZoneToBeConsumedByACS")
         subnet1 = self.create_vsd_subnet(zone1, "SubnetToBeConsumedByACS",
                                          "10.0.0.1/24")
+        # self.create_vsd_dhcp_option(subnet1, 6,
+        #                            ["10.0.0.2","128.251.10.25","4.4.4.4"])
 
 Review comment:
   Here and at other places : remove (or uncomment, if applicable) commented lines  (but bottom-line, don't leave commented code in the source).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services