[GitHub] [hadoop] singer-bin commented on a change in pull request #3926: HDFS-16437 ReverseXML processor doesn't accept XML files without the …

[GitBox <gi...@apache.org>]

singer-bin commented on a change in pull request #3926:
URL: https://github.com/apache/hadoop/pull/3926#discussion_r798365362



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
##########
@@ -1174,6 +1174,42 @@ public void testReverseXmlWrongLayoutVersion() throws Throwable {
     }
   }
 
+  /**
+   * Tests that the ReverseXML processor doesn't accept XML files without the SnapshotDiffSection.
+   */
+  @Test
+  public void testReverseXmlWithoutSnapshotDiffSection() throws Throwable {
+    File imageWSDS = new File(tempDir, "imageWithoutSnapshotDiffSection.xml");
+    PrintWriter writer = new PrintWriter(imageWSDS, "UTF-8");
+    try {

Review comment:
       Thanks a lot for your suggestion, I will fix it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org