You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by pa...@apache.org on 2017/08/12 05:58:41 UTC

groovy git commit: Remove unnecessary modifiers (closes #580)

Repository: groovy
Updated Branches:
  refs/heads/master f0d3b52ee -> c46209e14


Remove unnecessary modifiers (closes #580)

Make some minor changes to remove checkstyle issues. No major changes
have been attempted.


Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/c46209e1
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/c46209e1
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/c46209e1

Branch: refs/heads/master
Commit: c46209e1403f7d511740f598e1cc3906031c8307
Parents: f0d3b52
Author: Harsh Gupta <ha...@hotmail.com>
Authored: Thu Aug 10 22:48:41 2017 -0700
Committer: paulk <pa...@asert.com.au>
Committed: Sat Aug 12 15:56:45 2017 +1000

----------------------------------------------------------------------
 .../groovy/macro/matcher/ContextualClassCodeVisitor.java         | 2 +-
 .../groovy/org/codehaus/groovy/macro/matcher/TreeContext.java    | 2 +-
 .../groovy/org/codehaus/groovy/macro/runtime/MacroBuilder.java   | 2 +-
 .../groovy/macro/transform/MacroClassTransformation.java         | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/groovy/blob/c46209e1/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/matcher/ContextualClassCodeVisitor.java
----------------------------------------------------------------------
diff --git a/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/matcher/ContextualClassCodeVisitor.java b/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/matcher/ContextualClassCodeVisitor.java
index a8a6bc2..e39ac05 100644
--- a/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/matcher/ContextualClassCodeVisitor.java
+++ b/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/matcher/ContextualClassCodeVisitor.java
@@ -595,7 +595,7 @@ public abstract class ContextualClassCodeVisitor extends ClassCodeVisitorSupport
     private static class MatchByClass implements ASTNodePredicate {
         private final Class<ASTNode> astNodeClass;
 
-        public MatchByClass(final Class<ASTNode> astNodeClass) {
+        MatchByClass(final Class<ASTNode> astNodeClass) {
             this.astNodeClass = astNodeClass;
         }
 

http://git-wip-us.apache.org/repos/asf/groovy/blob/c46209e1/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/matcher/TreeContext.java
----------------------------------------------------------------------
diff --git a/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/matcher/TreeContext.java b/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/matcher/TreeContext.java
index 741c491..de31c8a 100644
--- a/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/matcher/TreeContext.java
+++ b/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/matcher/TreeContext.java
@@ -32,7 +32,7 @@ import java.util.List;
 import java.util.Map;
 
 public class TreeContext {
-    private static enum TreeContextKey {
+    private enum TreeContextKey {
         expression_replacement
     }
     final TreeContext parent;

http://git-wip-us.apache.org/repos/asf/groovy/blob/c46209e1/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/runtime/MacroBuilder.java
----------------------------------------------------------------------
diff --git a/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/runtime/MacroBuilder.java b/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/runtime/MacroBuilder.java
index 73cb0e2..d864be1 100644
--- a/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/runtime/MacroBuilder.java
+++ b/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/runtime/MacroBuilder.java
@@ -61,7 +61,7 @@ public enum MacroBuilder {
         return macro(compilePhase, false, source, context, resultClass);
     }
 
-    private final static AtomicInteger COUNTER = new AtomicInteger();
+    private static final AtomicInteger COUNTER = new AtomicInteger();
 
     @SuppressWarnings("unchecked")
     public <T> T macro(CompilePhase compilePhase, boolean asIs, String source, final List<Closure<Expression>> context, Class<T> resultClass) {

http://git-wip-us.apache.org/repos/asf/groovy/blob/c46209e1/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/transform/MacroClassTransformation.java
----------------------------------------------------------------------
diff --git a/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/transform/MacroClassTransformation.java b/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/transform/MacroClassTransformation.java
index 6777933..7ffc16b 100644
--- a/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/transform/MacroClassTransformation.java
+++ b/subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/transform/MacroClassTransformation.java
@@ -57,7 +57,7 @@ public class MacroClassTransformation extends MethodCallTransformation {
 
         private final SourceUnit sourceUnit;
 
-        public MacroClassTransformer(SourceUnit sourceUnit) {
+        MacroClassTransformer(SourceUnit sourceUnit) {
             this.sourceUnit = sourceUnit;
         }
 
@@ -82,7 +82,7 @@ public class MacroClassTransformation extends MethodCallTransformation {
 
         private final SourceUnit sourceUnit;
 
-        public MacroClassTransformingCodeVisitor(ClassCodeExpressionTransformer transformer, SourceUnit sourceUnit) {
+        MacroClassTransformingCodeVisitor(ClassCodeExpressionTransformer transformer, SourceUnit sourceUnit) {
             super(transformer);
             this.sourceUnit = sourceUnit;
         }