You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Rene Cordier (JIRA)" <se...@james.apache.org> on 2019/05/09 04:42:00 UTC
[jira] [Commented] (JAMES-2751) Refactoring: add a force restart
policy in Docker Cassandra for some test classes
[ https://issues.apache.org/jira/browse/JAMES-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836072#comment-16836072 ]
Rene Cordier commented on JAMES-2751:
-------------------------------------
After digging again into the issue, I realized that when the DockerCassandraRule got changed from being used as a @ClassRule to a @Rule in https://github.com/linagora/james-project/pull/2313, the restart was not working anymore in fact.
The start() method is never invoked for example in test classes implementing the DockerCassandraRule in mailbox/cassandra module. And maybe that's why our builds are still not stable in this module on the CI. So this is the fix I propose instead :
https://github.com/linagora/james-project/pull/2348
> Refactoring: add a force restart policy in Docker Cassandra for some test classes
> ---------------------------------------------------------------------------------
>
> Key: JAMES-2751
> URL: https://issues.apache.org/jira/browse/JAMES-2751
> Project: James Server
> Issue Type: Bug
> Reporter: Rene Cordier
> Priority: Major
> Fix For: 3.4.0
>
>
> We still can find this kind of errors in the build :
> {code:java}
> [217370df8625d8292821c199b2c2dfd45fb0d0f2] [ERROR] Failures:
> [217370df8625d8292821c199b2c2dfd45fb0d0f2] [ERROR] CassandraMessageIdToImapUidDAOTest.updateShouldUpdateDraftFlag:278
> [217370df8625d8292821c199b2c2dfd45fb0d0f2] Expecting:
> [217370df8625d8292821c199b2c2dfd45fb0d0f2] <[ComposedMessageIdWithMetaData{composedMessageId=ComposedMessageId{mailboxId=CassandraId{id=e3436d61-6a47-11e9-89e1-fdb0c5d8e998}, messageId=CassandraMessageId{uuid=e3436d60-6a47-11e9-89e1-fdb0c5d8e998}, uid=MessageUid{uid=1}}, flags=, modSeq=1}]>
> [217370df8625d8292821c199b2c2dfd45fb0d0f2] to contain only:
> [217370df8625d8292821c199b2c2dfd45fb0d0f2] <[ComposedMessageIdWithMetaData{composedMessageId=ComposedMessageId{mailboxId=CassandraId{id=e3436d61-6a47-11e9-89e1-fdb0c5d8e998}, messageId=CassandraMessageId{uuid=e3436d60-6a47-11e9-89e1-fdb0c5d8e998}, uid=MessageUid{uid=1}}, flags=\Draft, modSeq=2}]>
> [217370df8625d8292821c199b2c2dfd45fb0d0f2] elements not found:
> [217370df8625d8292821c199b2c2dfd45fb0d0f2] <[ComposedMessageIdWithMetaData{composedMessageId=ComposedMessageId{mailboxId=CassandraId{id=e3436d61-6a47-11e9-89e1-fdb0c5d8e998}, messageId=CassandraMessageId{uuid=e3436d60-6a47-11e9-89e1-fdb0c5d8e998}, uid=MessageUid{uid=1}}, flags=\Draft, modSeq=2}]>
> [217370df8625d8292821c199b2c2dfd45fb0d0f2] and elements not expected:
> [217370df8625d8292821c199b2c2dfd45fb0d0f2] <[ComposedMessageIdWithMetaData{composedMessageId=ComposedMessageId{mailboxId=CassandraId{id=e3436d61-6a47-11e9-89e1-fdb0c5d8e998}, messageId=CassandraMessageId{uuid=e3436d60-6a47-11e9-89e1-fdb0c5d8e998}, uid=MessageUid{uid=1}}, flags=, modSeq=1}]>
> {code}
> It seems it reappeared as soon as we put back the fork execution tests. This task is for trying implementing a forced restart of the Docker Cassandra to see if we can avoid those errors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org