You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/29 21:45:00 UTC
[GitHub] [pulsar-client-node] ken-browning opened a new issue, #211: Does Consumer::acknowledge use the network?
ken-browning opened a new issue, #211:
URL: https://github.com/apache/pulsar-client-node/issues/211
According to my mental model, there must be some network activity involved in acknowledging a pulsar message as a consumer. I was surprised to find that the Consumer::acknowledge method does not return a promise. My code which handles application shutdown would want to `await` until the acknowledgement has been successfully sent before ending the process.
Should `acknowledge` be updated to return a Promise?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-node] ken-browning commented on issue #211: Does Consumer::acknowledge use the network?
Posted by GitBox <gi...@apache.org>.
ken-browning commented on issue #211:
URL: https://github.com/apache/pulsar-client-node/issues/211#issuecomment-1113792569
This appears to be fixed in https://github.com/apache/pulsar-client-node/pull/200.
However, the negativeAcknowledge function still doesn't return a promise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-node] ken-browning commented on issue #211: Does Consumer::acknowledge use the network?
Posted by GitBox <gi...@apache.org>.
ken-browning commented on issue #211:
URL: https://github.com/apache/pulsar-client-node/issues/211#issuecomment-1113787706
I see that it does return a promise (i think) https://github.com/apache/pulsar-client-node/blob/11f28a6dace21a248fdf7f6d9d3a4a1de524a020/src/Consumer.cc#L277
So I guess the typescript definitions needs to be updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-node] ken-browning closed issue #211: Does Consumer::acknowledge use the network?
Posted by GitBox <gi...@apache.org>.
ken-browning closed issue #211: Does Consumer::acknowledge use the network?
URL: https://github.com/apache/pulsar-client-node/issues/211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org