[GitHub] [spark] dilipbiswal commented on a change in pull request #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED

[GitBox <gi...@apache.org>]

dilipbiswal commented on a change in pull request #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED
URL: https://github.com/apache/spark/pull/26039#discussion_r332364590
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ExplainUtils.scala
 ##########
 @@ -199,8 +199,8 @@ object ExplainUtils {
               case s: BaseSubqueryExec =>
                 subqueries += ((p, e, s))
                 getSubqueries(s, subqueries)
+              case _ =>
 
 Review comment:
   @cloud-fan We have it in this form : 
   p.expressions.foreach(_.collect {
       ...
       ...
   })
   
   You are suggesting to do : 
   
   p.expressions.foreach(_.foreach {
       ...
       ...
   }
   
   ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org