You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Aaron Bell <aa...@gmail.com> on 2015/03/02 21:55:42 UTC
Review Request 31638: MESOS-2426 developer guide improvements
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31638/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-2426
https://issues.apache.org/jira/browse/MESOS-2426
Repository: mesos
Description
-------
MESOS-2426 developer guide improvements.
1. Add a new line for the user to run 'rbt status' to log into review board.
2. Change 'git co' (technically invalid) to 'git checkout'.
Diffs
-----
docs/mesos-developers-guide.md 0a30587c3d741456e7081ad4c232401b3fb3e938
Diff: https://reviews.apache.org/r/31638/diff/
Testing
-------
Don't know how to test web build.
Thanks,
Aaron Bell
Re: Review Request 31638: MESOS-2426 developer guide improvements
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31638/#review75181
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31638]
All tests passed.
- Mesos ReviewBot
On March 4, 2015, 1:18 a.m., Aaron Bell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31638/
> -----------------------------------------------------------
>
> (Updated March 4, 2015, 1:18 a.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Bugs: MESOS-2426
> https://issues.apache.org/jira/browse/MESOS-2426
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-2426 developer guide improvements.
> 1. Add a new line for the user to run 'rbt status' to log into review board.
> 2. Change 'git co' (technically invalid) to 'git checkout'.
>
>
> Diffs
> -----
>
> docs/mesos-developers-guide.md 0a30587
>
> Diff: https://reviews.apache.org/r/31638/diff/
>
>
> Testing
> -------
>
> Don't know how to test web build.
>
>
> Thanks,
>
> Aaron Bell
>
>
Re: Review Request 31638: MESOS-2426 developer guide improvements
Posted by Aaron Bell <aa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31638/
-----------------------------------------------------------
(Updated March 4, 2015, 1:18 a.m.)
Review request for mesos and Dave Lester.
Bugs: MESOS-2426
https://issues.apache.org/jira/browse/MESOS-2426
Repository: mesos
Description
-------
MESOS-2426 developer guide improvements.
1. Add a new line for the user to run 'rbt status' to log into review board.
2. Change 'git co' (technically invalid) to 'git checkout'.
Diffs (updated)
-----
docs/mesos-developers-guide.md 0a30587
Diff: https://reviews.apache.org/r/31638/diff/
Testing
-------
Don't know how to test web build.
Thanks,
Aaron Bell
Re: Review Request 31638: MESOS-2426 developer guide improvements
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31638/#review74854
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31638]
All tests passed.
- Mesos ReviewBot
On March 2, 2015, 8:55 p.m., Aaron Bell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31638/
> -----------------------------------------------------------
>
> (Updated March 2, 2015, 8:55 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2426
> https://issues.apache.org/jira/browse/MESOS-2426
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-2426 developer guide improvements.
> 1. Add a new line for the user to run 'rbt status' to log into review board.
> 2. Change 'git co' (technically invalid) to 'git checkout'.
>
>
> Diffs
> -----
>
> docs/mesos-developers-guide.md 0a30587c3d741456e7081ad4c232401b3fb3e938
>
> Diff: https://reviews.apache.org/r/31638/diff/
>
>
> Testing
> -------
>
> Don't know how to test web build.
>
>
> Thanks,
>
> Aaron Bell
>
>
Re: Review Request 31638: MESOS-2426 developer guide improvements
Posted by Vinod Kone <vi...@gmail.com>.
> On March 2, 2015, 9:47 p.m., Vinod Kone wrote:
> > docs/mesos-developers-guide.md, line 62
> > <https://reviews.apache.org/r/31638/diff/1/?file=882317#file882317line62>
> >
> > not yours, but can you s/wiki//
>
> Aaron Bell wrote:
> I made this change on my local branch. What now - I have to update the diff attached to this RR I guess? Pointers appreciated.
yup. or i can do it when i commit it. no big deal.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31638/#review74828
-----------------------------------------------------------
On March 2, 2015, 8:55 p.m., Aaron Bell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31638/
> -----------------------------------------------------------
>
> (Updated March 2, 2015, 8:55 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2426
> https://issues.apache.org/jira/browse/MESOS-2426
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-2426 developer guide improvements.
> 1. Add a new line for the user to run 'rbt status' to log into review board.
> 2. Change 'git co' (technically invalid) to 'git checkout'.
>
>
> Diffs
> -----
>
> docs/mesos-developers-guide.md 0a30587c3d741456e7081ad4c232401b3fb3e938
>
> Diff: https://reviews.apache.org/r/31638/diff/
>
>
> Testing
> -------
>
> Don't know how to test web build.
>
>
> Thanks,
>
> Aaron Bell
>
>
Re: Review Request 31638: MESOS-2426 developer guide improvements
Posted by Aaron Bell <aa...@gmail.com>.
> On March 2, 2015, 9:47 p.m., Vinod Kone wrote:
> > docs/mesos-developers-guide.md, line 62
> > <https://reviews.apache.org/r/31638/diff/1/?file=882317#file882317line62>
> >
> > not yours, but can you s/wiki//
I made this change on my local branch. What now - I have to update the diff attached to this RR I guess? Pointers appreciated.
- Aaron
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31638/#review74828
-----------------------------------------------------------
On March 2, 2015, 8:55 p.m., Aaron Bell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31638/
> -----------------------------------------------------------
>
> (Updated March 2, 2015, 8:55 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2426
> https://issues.apache.org/jira/browse/MESOS-2426
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-2426 developer guide improvements.
> 1. Add a new line for the user to run 'rbt status' to log into review board.
> 2. Change 'git co' (technically invalid) to 'git checkout'.
>
>
> Diffs
> -----
>
> docs/mesos-developers-guide.md 0a30587c3d741456e7081ad4c232401b3fb3e938
>
> Diff: https://reviews.apache.org/r/31638/diff/
>
>
> Testing
> -------
>
> Don't know how to test web build.
>
>
> Thanks,
>
> Aaron Bell
>
>
Re: Review Request 31638: MESOS-2426 developer guide improvements
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31638/#review74828
-----------------------------------------------------------
Ship it!
docs/mesos-developers-guide.md
<https://reviews.apache.org/r/31638/#comment121612>
not yours, but can you s/wiki//
- Vinod Kone
On March 2, 2015, 8:55 p.m., Aaron Bell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31638/
> -----------------------------------------------------------
>
> (Updated March 2, 2015, 8:55 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2426
> https://issues.apache.org/jira/browse/MESOS-2426
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-2426 developer guide improvements.
> 1. Add a new line for the user to run 'rbt status' to log into review board.
> 2. Change 'git co' (technically invalid) to 'git checkout'.
>
>
> Diffs
> -----
>
> docs/mesos-developers-guide.md 0a30587c3d741456e7081ad4c232401b3fb3e938
>
> Diff: https://reviews.apache.org/r/31638/diff/
>
>
> Testing
> -------
>
> Don't know how to test web build.
>
>
> Thanks,
>
> Aaron Bell
>
>
Re: Review Request 31638: MESOS-2426 developer guide improvements
Posted by Cody Maloney <co...@mesosphere.io>.
> On March 2, 2015, 9:36 p.m., Timothy Chen wrote:
> > docs/mesos-developers-guide.md, line 58
> > <https://reviews.apache.org/r/31638/diff/1/?file=882317#file882317line58>
> >
> > You can actually create a .reviewboardrc that contains your credentials, then you don't need to login at all.
Then you need all the things in the default reviewboardrc that you get during a bootstrap manually copied into your own (Some of the settings may change as changes are made to reviews.apache.org)...
With the 'rbt status' method you can use the default mesos-provided reviewboardrc, then just have you local authentication credentials picked up.
- Cody
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31638/#review74823
-----------------------------------------------------------
On March 2, 2015, 8:55 p.m., Aaron Bell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31638/
> -----------------------------------------------------------
>
> (Updated March 2, 2015, 8:55 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2426
> https://issues.apache.org/jira/browse/MESOS-2426
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-2426 developer guide improvements.
> 1. Add a new line for the user to run 'rbt status' to log into review board.
> 2. Change 'git co' (technically invalid) to 'git checkout'.
>
>
> Diffs
> -----
>
> docs/mesos-developers-guide.md 0a30587c3d741456e7081ad4c232401b3fb3e938
>
> Diff: https://reviews.apache.org/r/31638/diff/
>
>
> Testing
> -------
>
> Don't know how to test web build.
>
>
> Thanks,
>
> Aaron Bell
>
>
Re: Review Request 31638: MESOS-2426 developer guide improvements
Posted by Aaron Bell <aa...@gmail.com>.
> On March 2, 2015, 9:36 p.m., Timothy Chen wrote:
> > docs/mesos-developers-guide.md, line 58
> > <https://reviews.apache.org/r/31638/diff/1/?file=882317#file882317line58>
> >
> > You can actually create a .reviewboardrc that contains your credentials, then you don't need to login at all.
>
> Cody Maloney wrote:
> Then you need all the things in the default reviewboardrc that you get during a bootstrap manually copied into your own (Some of the settings may change as changes are made to reviews.apache.org)...
>
> With the 'rbt status' method you can use the default mesos-provided reviewboardrc, then just have you local authentication credentials picked up.
Cody's method seems the right tradeoff.
- Aaron
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31638/#review74823
-----------------------------------------------------------
On March 2, 2015, 8:55 p.m., Aaron Bell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31638/
> -----------------------------------------------------------
>
> (Updated March 2, 2015, 8:55 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2426
> https://issues.apache.org/jira/browse/MESOS-2426
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-2426 developer guide improvements.
> 1. Add a new line for the user to run 'rbt status' to log into review board.
> 2. Change 'git co' (technically invalid) to 'git checkout'.
>
>
> Diffs
> -----
>
> docs/mesos-developers-guide.md 0a30587c3d741456e7081ad4c232401b3fb3e938
>
> Diff: https://reviews.apache.org/r/31638/diff/
>
>
> Testing
> -------
>
> Don't know how to test web build.
>
>
> Thanks,
>
> Aaron Bell
>
>
Re: Review Request 31638: MESOS-2426 developer guide improvements
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31638/#review74823
-----------------------------------------------------------
docs/mesos-developers-guide.md
<https://reviews.apache.org/r/31638/#comment121605>
You can actually create a .reviewboardrc that contains your credentials, then you don't need to login at all.
- Timothy Chen
On March 2, 2015, 8:55 p.m., Aaron Bell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31638/
> -----------------------------------------------------------
>
> (Updated March 2, 2015, 8:55 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2426
> https://issues.apache.org/jira/browse/MESOS-2426
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-2426 developer guide improvements.
> 1. Add a new line for the user to run 'rbt status' to log into review board.
> 2. Change 'git co' (technically invalid) to 'git checkout'.
>
>
> Diffs
> -----
>
> docs/mesos-developers-guide.md 0a30587c3d741456e7081ad4c232401b3fb3e938
>
> Diff: https://reviews.apache.org/r/31638/diff/
>
>
> Testing
> -------
>
> Don't know how to test web build.
>
>
> Thanks,
>
> Aaron Bell
>
>