[jira] [Created] (SLING-2928) Wasted work in LaunchpadConfigInstaller.isActive()

["Adrian Nistor (JIRA)" <ji...@apache.org>]

Adrian Nistor created SLING-2928:
------------------------------------

             Summary: Wasted work in LaunchpadConfigInstaller.isActive()
                 Key: SLING-2928
                 URL: https://issues.apache.org/jira/browse/SLING-2928
             Project: Sling
          Issue Type: Bug
          Components: Launchpad
         Environment: any
            Reporter: Adrian Nistor


The problem appears in revision 1495454.  I attached a one-line patch
that fixes it.

In method "LaunchpadConfigInstaller.isActive", the loop over
"runModes" should break immediately after "active" is set to "false".
All the iterations after "active" is set to "false" do not perform any
useful work, at best they just set "active" again to "false".

Method "isLive" in class "ResourceResolverContext" has a similar loop
(over "dynamicProviders"), and this loop breaks immediately after
"result" is set to "false", just like in the proposed patch.  Other
methods (e.g., "FactoryPreconditions.checkPreconditions",
"JspUtil.checkAttributes", "EclipseJavaCompiler.compile",
"SecondPassVisitor.appendPageDirective") also have similar loops with
similar breaks, just like in the proposed patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira