You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/05/12 07:02:59 UTC
[GitHub] [incubator-pegasus] cauchy1988 opened a new pull request, #967: chore: Merge python3 client
cauchy1988 opened a new pull request, #967:
URL: https://github.com/apache/incubator-pegasus/pull/967
### What problem does this PR solve? <!--add issue link with summary if exists-->
https://github.com/apache/incubator-pegasus/issues/945
### What is changed and how does it work?
just merge python3 client into incubator-pegasus
### Checklist <!--REMOVE the items that are not applicable-->
##### Tests <!-- At least one of them must be included. -->
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
##### Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
##### Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
##### Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
- Need to be included in the release note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #967: chore: Merge python3 client
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #967:
URL: https://github.com/apache/incubator-pegasus/pull/967#discussion_r871042327
##########
python-client/README.md:
##########
@@ -0,0 +1,64 @@
+pegasus-python-client
+=====================
+
+This is the official python client for [xiaomi/pegasus](https://github.com/XiaoMi/pegasus).
Review Comment:
need update
##########
python-client/README.md:
##########
@@ -0,0 +1,64 @@
+pegasus-python-client
+=====================
+
+This is the official python client for [xiaomi/pegasus](https://github.com/XiaoMi/pegasus).
+
+It uses [Twisted](http://twistedmatrix.com) for the asynchronous communication with pegasus server.
+
+Installation
+------------
+Python 3.8+
+
+pypegasus can be installed via pip as follows:
+
+`git clone https://git.n.xiaomi.com/pegasus/pegasus-python-client`
Review Comment:
need update
##########
.arcconfig:
##########
@@ -0,0 +1,4 @@
+{
Review Comment:
remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 merged pull request #967: chore: Merge python3 client
Posted by GitBox <gi...@apache.org>.
acelyc111 merged PR #967:
URL: https://github.com/apache/incubator-pegasus/pull/967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #967: chore: Merge python3 client
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #967:
URL: https://github.com/apache/incubator-pegasus/pull/967#discussion_r872909607
##########
python-client/README.md:
##########
@@ -0,0 +1,83 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+pegasus-python-client
+=====================
+
+It uses [Twisted](http://twistedmatrix.com) for the asynchronous communication with pegasus server.
+
+Installation
+------------
+Python 3.8+
+
+pypegasus can be installed via pip as follows:
+
+`git clone https://github.com/apache/incubator-pegasus`
+`cd inclubator-pegasus/python-client && python setup.py install`
Review Comment:
Use `python3` to replace `python` in command line?
##########
python-client/tests/__init__.py:
##########
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#!/usr/bin/env python
+# coding: utf-8
Review Comment:
```suggestion
#!/usr/bin/env python
# coding: utf-8
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #967: chore: Merge python3 client
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #967:
URL: https://github.com/apache/incubator-pegasus/pull/967#issuecomment-1126605842
I've checked:
- [x] files lack of APLv2 header have been fixed.
- [x] `github.com/XiaoMi/pegasus-python-client` has been updated to `github.com/apache/incubator-pegasus/python-client`
- [x] `com.xiaomi.infra.pegasus` has been updated to `org.apache.pegasus`
- [x] all actions passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org