You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/12/02 11:25:28 UTC

Review Request 40863: LENS-552: Union support across storage tables in multi fact query

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-552
    https://issues.apache.org/jira/browse/LENS-552


Repository: lens


Description
-------

We need to have support for union across storage tables of one/all  facts tables taking part in multi fact query.


Diffs
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java b544a670a27f65b65a66affde55c7276438d4daa 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 0656049dafc0b974104ff1c2f79a98fac934901d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java b95595ade6120c0073c286e073715800b6cdd915 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c91f103d40c1f0fe9886b15820bb7ef7614 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java e0759b0b8894ec1d0cca41fa6f897576f8090070 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java a576f3a6720e5e4454faf0188a43091191b0c787 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 200a48cd67e6a5a381ef3723a3adb686d8347efb 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 6c442333fb42beafac1839907159d775b6f97dce 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 1385584e033abe904279a8fd6dfa299f4e48665c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 113d8deb8284443ae45151aa27852ab97570591e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java cc8e68c5ad60edeb9638216a6cc9240750e3091e 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1357035c8dfc6a5115c02d8fdc7cd8bb341eb6dd 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4cdd5f0a54d90603c1ef96282e8068f4d32 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8 

Diff: https://reviews.apache.org/r/40863/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

Posted by Rajat Khandelwal <ra...@gmail.com>.

> On Dec. 17, 2015, 6:06 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java, line 164
> > <https://reviews.apache.org/r/40863/diff/5/?file=1162551#file1162551line164>
> >
> >     I feel this code is still required for the cases of multi range quereies having where clauses.
> >     
> >     Please update multi range queries to have where clause.
> >     and  also add multi fact - multi range query.

With minimal changes, multi range queries are working. :)


> On Dec. 17, 2015, 6:06 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java, line 339
> > <https://reviews.apache.org/r/40863/diff/5/?file=1162563#file1162563line339>
> >
> >     Check if static is required?

Removed


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/#review110949
-----------------------------------------------------------


On Dec. 21, 2015, 4:40 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40863/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 4:40 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-552
>     https://issues.apache.org/jira/browse/LENS-552
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> includes LENS-851 changes, since I expect this to be merged after LENS-851
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 39bd1cccba3394539c697729063c76467be4bccc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 0656049dafc0b974104ff1c2f79a98fac934901d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 94725063c0f9f64682bc0741c409bcefdf0be8ec 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 2338ba70bbdeae90c7a0270f63f5d2c1255b5529 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java b95595ade6120c0073c286e073715800b6cdd915 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 4034a5452090e9c508f4261b3160f938427afe84 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java e0759b0b8894ec1d0cca41fa6f897576f8090070 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java a576f3a6720e5e4454faf0188a43091191b0c787 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java bcfc1f6202da5c4377cf6710525c9655a08ce4cc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 0c43d9800d27b6c343af2b200ebeff9cf20fa816 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 776021d94cfb3c724970bc81a5d03c58459c7911 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 6c442333fb42beafac1839907159d775b6f97dce 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java da74713e5656a10144a6298a2a6fea266a11e156 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7cea7d5a4491d1185cae845415d90d46cfd825c0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 1385584e033abe904279a8fd6dfa299f4e48665c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 113d8deb8284443ae45151aa27852ab97570591e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java de52b0a50b8cec580eb7807669d652a85b71e5f9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 96b1d054a3c444960c69298d878784a819defd53 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 62cc071237b84c46d69d78eea694eb9b8e9b2fd4 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java 87e4ce3768a9f7fa418484ef0f48d76cffbdda0d 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3f01dbeb1e27248071ecd78c48daea8b77c87459 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java a5886dc1420a38dee88b8798da3fa386bf713436 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 9a08735979ae9e8d75c0d0f86d705b0716c906d3 
> 
> Diff: https://reviews.apache.org/r/40863/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.211s]
> [INFO] Lens .............................................. SUCCESS [4.133s]
> [INFO] Lens API .......................................... SUCCESS [26.669s]
> [INFO] Lens API for server and extensions ................ SUCCESS [24.038s]
> [INFO] Lens Cube ......................................... SUCCESS [6:30.318s]
> [INFO] Lens DB storage ................................... SUCCESS [19.100s]
> [INFO] Lens Query Library ................................ SUCCESS [14.772s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:00.020s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [40.555s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.922s]
> [INFO] Lens Server ....................................... SUCCESS [10:23.992s]
> [INFO] Lens client ....................................... SUCCESS [40.087s]
> [INFO] Lens CLI .......................................... SUCCESS [54.969s]
> [INFO] Lens Examples ..................................... SUCCESS [11.468s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.983s]
> [INFO] Lens Distribution ................................. SUCCESS [9.764s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:31.190s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.913s]
> [INFO] Lens Regression ................................... SUCCESS [15.667s]
> [INFO] Lens UI ........................................... SUCCESS [27.084s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:39.990s
> [INFO] Finished at: Fri Dec 04 11:43:24 UTC 2015
> [INFO] Final Memory: 178M/1024M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/#review110949
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
<https://reviews.apache.org/r/40863/#comment170965>

    I feel this code is still required for the cases of multi range quereies having where clauses.
    
    Please update multi range queries to have where clause.
    and  also add multi fact - multi range query.



lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java (line 339)
<https://reviews.apache.org/r/40863/#comment170967>

    Check if static is required?


- Amareshwari Sriramadasu


On Dec. 14, 2015, 3:15 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40863/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 3:15 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-552
>     https://issues.apache.org/jira/browse/LENS-552
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> includes LENS-851 changes, since I expect this to be merged after LENS-851
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java b544a670a27f65b65a66affde55c7276438d4daa 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 0656049dafc0b974104ff1c2f79a98fac934901d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 94725063c0f9f64682bc0741c409bcefdf0be8ec 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 2338ba70bbdeae90c7a0270f63f5d2c1255b5529 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java b95595ade6120c0073c286e073715800b6cdd915 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java f75a6b9b79ee9330de05c24d8f290b2cd27fcc4a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java e0759b0b8894ec1d0cca41fa6f897576f8090070 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java a576f3a6720e5e4454faf0188a43091191b0c787 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java bcfc1f6202da5c4377cf6710525c9655a08ce4cc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 0c43d9800d27b6c343af2b200ebeff9cf20fa816 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 776021d94cfb3c724970bc81a5d03c58459c7911 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 6c442333fb42beafac1839907159d775b6f97dce 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java da74713e5656a10144a6298a2a6fea266a11e156 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7cea7d5a4491d1185cae845415d90d46cfd825c0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 1385584e033abe904279a8fd6dfa299f4e48665c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 113d8deb8284443ae45151aa27852ab97570591e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java de52b0a50b8cec580eb7807669d652a85b71e5f9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 96b1d054a3c444960c69298d878784a819defd53 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 62cc071237b84c46d69d78eea694eb9b8e9b2fd4 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3f01dbeb1e27248071ecd78c48daea8b77c87459 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java a5886dc1420a38dee88b8798da3fa386bf713436 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 802ff42cf44e2a51ac984220d57d961f68dec442 
> 
> Diff: https://reviews.apache.org/r/40863/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.211s]
> [INFO] Lens .............................................. SUCCESS [4.133s]
> [INFO] Lens API .......................................... SUCCESS [26.669s]
> [INFO] Lens API for server and extensions ................ SUCCESS [24.038s]
> [INFO] Lens Cube ......................................... SUCCESS [6:30.318s]
> [INFO] Lens DB storage ................................... SUCCESS [19.100s]
> [INFO] Lens Query Library ................................ SUCCESS [14.772s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:00.020s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [40.555s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.922s]
> [INFO] Lens Server ....................................... SUCCESS [10:23.992s]
> [INFO] Lens client ....................................... SUCCESS [40.087s]
> [INFO] Lens CLI .......................................... SUCCESS [54.969s]
> [INFO] Lens Examples ..................................... SUCCESS [11.468s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.983s]
> [INFO] Lens Distribution ................................. SUCCESS [9.764s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:31.190s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.913s]
> [INFO] Lens Regression ................................... SUCCESS [15.667s]
> [INFO] Lens UI ........................................... SUCCESS [27.084s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:39.990s
> [INFO] Finished at: Fri Dec 04 11:43:24 UTC 2015
> [INFO] Final Memory: 178M/1024M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/
-----------------------------------------------------------

(Updated Dec. 23, 2015, 10:33 a.m.)


Review request for lens.


Bugs: LENS-552
    https://issues.apache.org/jira/browse/LENS-552


Repository: lens


Description
-------

includes LENS-851 changes, since I expect this to be merged after LENS-851


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 39bd1cccba3394539c697729063c76467be4bccc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 0656049dafc0b974104ff1c2f79a98fac934901d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 94725063c0f9f64682bc0741c409bcefdf0be8ec 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 2338ba70bbdeae90c7a0270f63f5d2c1255b5529 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java b95595ade6120c0073c286e073715800b6cdd915 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 4034a5452090e9c508f4261b3160f938427afe84 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java e0759b0b8894ec1d0cca41fa6f897576f8090070 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java a576f3a6720e5e4454faf0188a43091191b0c787 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java bcfc1f6202da5c4377cf6710525c9655a08ce4cc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 0c43d9800d27b6c343af2b200ebeff9cf20fa816 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 776021d94cfb3c724970bc81a5d03c58459c7911 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 6c442333fb42beafac1839907159d775b6f97dce 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java da74713e5656a10144a6298a2a6fea266a11e156 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7cea7d5a4491d1185cae845415d90d46cfd825c0 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 1385584e033abe904279a8fd6dfa299f4e48665c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 113d8deb8284443ae45151aa27852ab97570591e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java de52b0a50b8cec580eb7807669d652a85b71e5f9 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 96b1d054a3c444960c69298d878784a819defd53 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 62cc071237b84c46d69d78eea694eb9b8e9b2fd4 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java 87e4ce3768a9f7fa418484ef0f48d76cffbdda0d 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3f01dbeb1e27248071ecd78c48daea8b77c87459 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java a5886dc1420a38dee88b8798da3fa386bf713436 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 9a08735979ae9e8d75c0d0f86d705b0716c906d3 

Diff: https://reviews.apache.org/r/40863/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.211s]
[INFO] Lens .............................................. SUCCESS [4.133s]
[INFO] Lens API .......................................... SUCCESS [26.669s]
[INFO] Lens API for server and extensions ................ SUCCESS [24.038s]
[INFO] Lens Cube ......................................... SUCCESS [6:30.318s]
[INFO] Lens DB storage ................................... SUCCESS [19.100s]
[INFO] Lens Query Library ................................ SUCCESS [14.772s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:00.020s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [40.555s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.922s]
[INFO] Lens Server ....................................... SUCCESS [10:23.992s]
[INFO] Lens client ....................................... SUCCESS [40.087s]
[INFO] Lens CLI .......................................... SUCCESS [54.969s]
[INFO] Lens Examples ..................................... SUCCESS [11.468s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.983s]
[INFO] Lens Distribution ................................. SUCCESS [9.764s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:31.190s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.913s]
[INFO] Lens Regression ................................... SUCCESS [15.667s]
[INFO] Lens UI ........................................... SUCCESS [27.084s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:39.990s
[INFO] Finished at: Fri Dec 04 11:43:24 UTC 2015
[INFO] Final Memory: 178M/1024M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal


Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/
-----------------------------------------------------------

(Updated Dec. 23, 2015, 10:32 a.m.)


Review request for lens.


Bugs: LENS-552
    https://issues.apache.org/jira/browse/LENS-552


Repository: lens


Description
-------

includes LENS-851 changes, since I expect this to be merged after LENS-851


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 39bd1cccba3394539c697729063c76467be4bccc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 0656049dafc0b974104ff1c2f79a98fac934901d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 94725063c0f9f64682bc0741c409bcefdf0be8ec 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 2338ba70bbdeae90c7a0270f63f5d2c1255b5529 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java b95595ade6120c0073c286e073715800b6cdd915 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 4034a5452090e9c508f4261b3160f938427afe84 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java e0759b0b8894ec1d0cca41fa6f897576f8090070 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java a576f3a6720e5e4454faf0188a43091191b0c787 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java bcfc1f6202da5c4377cf6710525c9655a08ce4cc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 0c43d9800d27b6c343af2b200ebeff9cf20fa816 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 776021d94cfb3c724970bc81a5d03c58459c7911 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 6c442333fb42beafac1839907159d775b6f97dce 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java da74713e5656a10144a6298a2a6fea266a11e156 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7cea7d5a4491d1185cae845415d90d46cfd825c0 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 1385584e033abe904279a8fd6dfa299f4e48665c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 113d8deb8284443ae45151aa27852ab97570591e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java de52b0a50b8cec580eb7807669d652a85b71e5f9 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 96b1d054a3c444960c69298d878784a819defd53 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 62cc071237b84c46d69d78eea694eb9b8e9b2fd4 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java 87e4ce3768a9f7fa418484ef0f48d76cffbdda0d 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3f01dbeb1e27248071ecd78c48daea8b77c87459 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java a5886dc1420a38dee88b8798da3fa386bf713436 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 9a08735979ae9e8d75c0d0f86d705b0716c906d3 

Diff: https://reviews.apache.org/r/40863/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.211s]
[INFO] Lens .............................................. SUCCESS [4.133s]
[INFO] Lens API .......................................... SUCCESS [26.669s]
[INFO] Lens API for server and extensions ................ SUCCESS [24.038s]
[INFO] Lens Cube ......................................... SUCCESS [6:30.318s]
[INFO] Lens DB storage ................................... SUCCESS [19.100s]
[INFO] Lens Query Library ................................ SUCCESS [14.772s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:00.020s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [40.555s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.922s]
[INFO] Lens Server ....................................... SUCCESS [10:23.992s]
[INFO] Lens client ....................................... SUCCESS [40.087s]
[INFO] Lens CLI .......................................... SUCCESS [54.969s]
[INFO] Lens Examples ..................................... SUCCESS [11.468s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.983s]
[INFO] Lens Distribution ................................. SUCCESS [9.764s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:31.190s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.913s]
[INFO] Lens Regression ................................... SUCCESS [15.667s]
[INFO] Lens UI ........................................... SUCCESS [27.084s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:39.990s
[INFO] Finished at: Fri Dec 04 11:43:24 UTC 2015
[INFO] Final Memory: 178M/1024M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal


Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/#review111588
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Dec. 21, 2015, 11:10 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40863/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 11:10 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-552
>     https://issues.apache.org/jira/browse/LENS-552
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> includes LENS-851 changes, since I expect this to be merged after LENS-851
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 39bd1cccba3394539c697729063c76467be4bccc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 0656049dafc0b974104ff1c2f79a98fac934901d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 94725063c0f9f64682bc0741c409bcefdf0be8ec 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 2338ba70bbdeae90c7a0270f63f5d2c1255b5529 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java b95595ade6120c0073c286e073715800b6cdd915 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 4034a5452090e9c508f4261b3160f938427afe84 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java e0759b0b8894ec1d0cca41fa6f897576f8090070 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java a576f3a6720e5e4454faf0188a43091191b0c787 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java bcfc1f6202da5c4377cf6710525c9655a08ce4cc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 0c43d9800d27b6c343af2b200ebeff9cf20fa816 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 776021d94cfb3c724970bc81a5d03c58459c7911 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 6c442333fb42beafac1839907159d775b6f97dce 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java da74713e5656a10144a6298a2a6fea266a11e156 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7cea7d5a4491d1185cae845415d90d46cfd825c0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 1385584e033abe904279a8fd6dfa299f4e48665c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 113d8deb8284443ae45151aa27852ab97570591e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java de52b0a50b8cec580eb7807669d652a85b71e5f9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 96b1d054a3c444960c69298d878784a819defd53 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 62cc071237b84c46d69d78eea694eb9b8e9b2fd4 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java 87e4ce3768a9f7fa418484ef0f48d76cffbdda0d 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3f01dbeb1e27248071ecd78c48daea8b77c87459 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java a5886dc1420a38dee88b8798da3fa386bf713436 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 9a08735979ae9e8d75c0d0f86d705b0716c906d3 
> 
> Diff: https://reviews.apache.org/r/40863/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.211s]
> [INFO] Lens .............................................. SUCCESS [4.133s]
> [INFO] Lens API .......................................... SUCCESS [26.669s]
> [INFO] Lens API for server and extensions ................ SUCCESS [24.038s]
> [INFO] Lens Cube ......................................... SUCCESS [6:30.318s]
> [INFO] Lens DB storage ................................... SUCCESS [19.100s]
> [INFO] Lens Query Library ................................ SUCCESS [14.772s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:00.020s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [40.555s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.922s]
> [INFO] Lens Server ....................................... SUCCESS [10:23.992s]
> [INFO] Lens client ....................................... SUCCESS [40.087s]
> [INFO] Lens CLI .......................................... SUCCESS [54.969s]
> [INFO] Lens Examples ..................................... SUCCESS [11.468s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.983s]
> [INFO] Lens Distribution ................................. SUCCESS [9.764s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:31.190s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.913s]
> [INFO] Lens Regression ................................... SUCCESS [15.667s]
> [INFO] Lens UI ........................................... SUCCESS [27.084s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:39.990s
> [INFO] Finished at: Fri Dec 04 11:43:24 UTC 2015
> [INFO] Final Memory: 178M/1024M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/
-----------------------------------------------------------

(Updated Dec. 21, 2015, 4:40 p.m.)


Review request for lens.


Bugs: LENS-552
    https://issues.apache.org/jira/browse/LENS-552


Repository: lens


Description
-------

includes LENS-851 changes, since I expect this to be merged after LENS-851


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 39bd1cccba3394539c697729063c76467be4bccc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 0656049dafc0b974104ff1c2f79a98fac934901d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 94725063c0f9f64682bc0741c409bcefdf0be8ec 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 2338ba70bbdeae90c7a0270f63f5d2c1255b5529 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java b95595ade6120c0073c286e073715800b6cdd915 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 4034a5452090e9c508f4261b3160f938427afe84 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java e0759b0b8894ec1d0cca41fa6f897576f8090070 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java a576f3a6720e5e4454faf0188a43091191b0c787 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java bcfc1f6202da5c4377cf6710525c9655a08ce4cc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 0c43d9800d27b6c343af2b200ebeff9cf20fa816 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 776021d94cfb3c724970bc81a5d03c58459c7911 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 6c442333fb42beafac1839907159d775b6f97dce 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java da74713e5656a10144a6298a2a6fea266a11e156 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7cea7d5a4491d1185cae845415d90d46cfd825c0 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 1385584e033abe904279a8fd6dfa299f4e48665c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 113d8deb8284443ae45151aa27852ab97570591e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java de52b0a50b8cec580eb7807669d652a85b71e5f9 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 96b1d054a3c444960c69298d878784a819defd53 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 62cc071237b84c46d69d78eea694eb9b8e9b2fd4 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java 87e4ce3768a9f7fa418484ef0f48d76cffbdda0d 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3f01dbeb1e27248071ecd78c48daea8b77c87459 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java a5886dc1420a38dee88b8798da3fa386bf713436 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 9a08735979ae9e8d75c0d0f86d705b0716c906d3 

Diff: https://reviews.apache.org/r/40863/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.211s]
[INFO] Lens .............................................. SUCCESS [4.133s]
[INFO] Lens API .......................................... SUCCESS [26.669s]
[INFO] Lens API for server and extensions ................ SUCCESS [24.038s]
[INFO] Lens Cube ......................................... SUCCESS [6:30.318s]
[INFO] Lens DB storage ................................... SUCCESS [19.100s]
[INFO] Lens Query Library ................................ SUCCESS [14.772s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:00.020s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [40.555s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.922s]
[INFO] Lens Server ....................................... SUCCESS [10:23.992s]
[INFO] Lens client ....................................... SUCCESS [40.087s]
[INFO] Lens CLI .......................................... SUCCESS [54.969s]
[INFO] Lens Examples ..................................... SUCCESS [11.468s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.983s]
[INFO] Lens Distribution ................................. SUCCESS [9.764s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:31.190s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.913s]
[INFO] Lens Regression ................................... SUCCESS [15.667s]
[INFO] Lens UI ........................................... SUCCESS [27.084s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:39.990s
[INFO] Finished at: Fri Dec 04 11:43:24 UTC 2015
[INFO] Final Memory: 178M/1024M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal


Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/
-----------------------------------------------------------

(Updated Dec. 14, 2015, 8:45 p.m.)


Review request for lens.


Bugs: LENS-552
    https://issues.apache.org/jira/browse/LENS-552


Repository: lens


Description
-------

includes LENS-851 changes, since I expect this to be merged after LENS-851


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java b544a670a27f65b65a66affde55c7276438d4daa 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 0656049dafc0b974104ff1c2f79a98fac934901d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 94725063c0f9f64682bc0741c409bcefdf0be8ec 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 2338ba70bbdeae90c7a0270f63f5d2c1255b5529 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java b95595ade6120c0073c286e073715800b6cdd915 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java f75a6b9b79ee9330de05c24d8f290b2cd27fcc4a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java e0759b0b8894ec1d0cca41fa6f897576f8090070 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java a576f3a6720e5e4454faf0188a43091191b0c787 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java bcfc1f6202da5c4377cf6710525c9655a08ce4cc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 0c43d9800d27b6c343af2b200ebeff9cf20fa816 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 776021d94cfb3c724970bc81a5d03c58459c7911 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 6c442333fb42beafac1839907159d775b6f97dce 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java da74713e5656a10144a6298a2a6fea266a11e156 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7cea7d5a4491d1185cae845415d90d46cfd825c0 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 1385584e033abe904279a8fd6dfa299f4e48665c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 113d8deb8284443ae45151aa27852ab97570591e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java de52b0a50b8cec580eb7807669d652a85b71e5f9 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 96b1d054a3c444960c69298d878784a819defd53 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 62cc071237b84c46d69d78eea694eb9b8e9b2fd4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3f01dbeb1e27248071ecd78c48daea8b77c87459 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java a5886dc1420a38dee88b8798da3fa386bf713436 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 802ff42cf44e2a51ac984220d57d961f68dec442 

Diff: https://reviews.apache.org/r/40863/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.211s]
[INFO] Lens .............................................. SUCCESS [4.133s]
[INFO] Lens API .......................................... SUCCESS [26.669s]
[INFO] Lens API for server and extensions ................ SUCCESS [24.038s]
[INFO] Lens Cube ......................................... SUCCESS [6:30.318s]
[INFO] Lens DB storage ................................... SUCCESS [19.100s]
[INFO] Lens Query Library ................................ SUCCESS [14.772s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:00.020s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [40.555s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.922s]
[INFO] Lens Server ....................................... SUCCESS [10:23.992s]
[INFO] Lens client ....................................... SUCCESS [40.087s]
[INFO] Lens CLI .......................................... SUCCESS [54.969s]
[INFO] Lens Examples ..................................... SUCCESS [11.468s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.983s]
[INFO] Lens Distribution ................................. SUCCESS [9.764s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:31.190s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.913s]
[INFO] Lens Regression ................................... SUCCESS [15.667s]
[INFO] Lens UI ........................................... SUCCESS [27.084s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:39.990s
[INFO] Finished at: Fri Dec 04 11:43:24 UTC 2015
[INFO] Final Memory: 178M/1024M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal


Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/
-----------------------------------------------------------

(Updated Dec. 14, 2015, 8:12 p.m.)


Review request for lens.


Bugs: LENS-552
    https://issues.apache.org/jira/browse/LENS-552


Repository: lens


Description
-------

includes LENS-851 changes, since I expect this to be merged after LENS-851


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java b544a670a27f65b65a66affde55c7276438d4daa 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 0656049dafc0b974104ff1c2f79a98fac934901d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 94725063c0f9f64682bc0741c409bcefdf0be8ec 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 2338ba70bbdeae90c7a0270f63f5d2c1255b5529 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java b95595ade6120c0073c286e073715800b6cdd915 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java f75a6b9b79ee9330de05c24d8f290b2cd27fcc4a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java e0759b0b8894ec1d0cca41fa6f897576f8090070 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java a576f3a6720e5e4454faf0188a43091191b0c787 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java bcfc1f6202da5c4377cf6710525c9655a08ce4cc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 0c43d9800d27b6c343af2b200ebeff9cf20fa816 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 776021d94cfb3c724970bc81a5d03c58459c7911 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 6c442333fb42beafac1839907159d775b6f97dce 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java da74713e5656a10144a6298a2a6fea266a11e156 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7cea7d5a4491d1185cae845415d90d46cfd825c0 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 1385584e033abe904279a8fd6dfa299f4e48665c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 113d8deb8284443ae45151aa27852ab97570591e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java de52b0a50b8cec580eb7807669d652a85b71e5f9 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 96b1d054a3c444960c69298d878784a819defd53 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 62cc071237b84c46d69d78eea694eb9b8e9b2fd4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3f01dbeb1e27248071ecd78c48daea8b77c87459 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java a5886dc1420a38dee88b8798da3fa386bf713436 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 802ff42cf44e2a51ac984220d57d961f68dec442 

Diff: https://reviews.apache.org/r/40863/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.211s]
[INFO] Lens .............................................. SUCCESS [4.133s]
[INFO] Lens API .......................................... SUCCESS [26.669s]
[INFO] Lens API for server and extensions ................ SUCCESS [24.038s]
[INFO] Lens Cube ......................................... SUCCESS [6:30.318s]
[INFO] Lens DB storage ................................... SUCCESS [19.100s]
[INFO] Lens Query Library ................................ SUCCESS [14.772s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:00.020s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [40.555s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.922s]
[INFO] Lens Server ....................................... SUCCESS [10:23.992s]
[INFO] Lens client ....................................... SUCCESS [40.087s]
[INFO] Lens CLI .......................................... SUCCESS [54.969s]
[INFO] Lens Examples ..................................... SUCCESS [11.468s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.983s]
[INFO] Lens Distribution ................................. SUCCESS [9.764s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:31.190s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.913s]
[INFO] Lens Regression ................................... SUCCESS [15.667s]
[INFO] Lens UI ........................................... SUCCESS [27.084s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:39.990s
[INFO] Finished at: Fri Dec 04 11:43:24 UTC 2015
[INFO] Final Memory: 178M/1024M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal


Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/#review110226
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java (line 164)
<https://reviews.apache.org/r/40863/#comment170023>

    TODO about?


- Amareshwari Sriramadasu


On Dec. 13, 2015, 10:06 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40863/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2015, 10:06 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-552
>     https://issues.apache.org/jira/browse/LENS-552
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> includes LENS-851 changes, since I expect this to be merged after LENS-851
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java b544a670a27f65b65a66affde55c7276438d4daa 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 0656049dafc0b974104ff1c2f79a98fac934901d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 94725063c0f9f64682bc0741c409bcefdf0be8ec 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 2338ba70bbdeae90c7a0270f63f5d2c1255b5529 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java b95595ade6120c0073c286e073715800b6cdd915 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c91f103d40c1f0fe9886b15820bb7ef7614 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java e0759b0b8894ec1d0cca41fa6f897576f8090070 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java a576f3a6720e5e4454faf0188a43091191b0c787 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java bcfc1f6202da5c4377cf6710525c9655a08ce4cc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 0c43d9800d27b6c343af2b200ebeff9cf20fa816 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 776021d94cfb3c724970bc81a5d03c58459c7911 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 6c442333fb42beafac1839907159d775b6f97dce 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java da74713e5656a10144a6298a2a6fea266a11e156 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7cea7d5a4491d1185cae845415d90d46cfd825c0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 1385584e033abe904279a8fd6dfa299f4e48665c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 113d8deb8284443ae45151aa27852ab97570591e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java de52b0a50b8cec580eb7807669d652a85b71e5f9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 96b1d054a3c444960c69298d878784a819defd53 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 62cc071237b84c46d69d78eea694eb9b8e9b2fd4 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3f01dbeb1e27248071ecd78c48daea8b77c87459 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 97c6d08a6d4ab53a49d9e205d1b4013b08da3658 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0f05556decc24cd5101e75b0851d1f9ff14d4b95 
> 
> Diff: https://reviews.apache.org/r/40863/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.211s]
> [INFO] Lens .............................................. SUCCESS [4.133s]
> [INFO] Lens API .......................................... SUCCESS [26.669s]
> [INFO] Lens API for server and extensions ................ SUCCESS [24.038s]
> [INFO] Lens Cube ......................................... SUCCESS [6:30.318s]
> [INFO] Lens DB storage ................................... SUCCESS [19.100s]
> [INFO] Lens Query Library ................................ SUCCESS [14.772s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:00.020s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [40.555s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.922s]
> [INFO] Lens Server ....................................... SUCCESS [10:23.992s]
> [INFO] Lens client ....................................... SUCCESS [40.087s]
> [INFO] Lens CLI .......................................... SUCCESS [54.969s]
> [INFO] Lens Examples ..................................... SUCCESS [11.468s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.983s]
> [INFO] Lens Distribution ................................. SUCCESS [9.764s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:31.190s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.913s]
> [INFO] Lens Regression ................................... SUCCESS [15.667s]
> [INFO] Lens UI ........................................... SUCCESS [27.084s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:39.990s
> [INFO] Finished at: Fri Dec 04 11:43:24 UTC 2015
> [INFO] Final Memory: 178M/1024M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/
-----------------------------------------------------------

(Updated Dec. 13, 2015, 3:36 p.m.)


Review request for lens.


Bugs: LENS-552
    https://issues.apache.org/jira/browse/LENS-552


Repository: lens


Description
-------

includes LENS-851 changes, since I expect this to be merged after LENS-851


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java b544a670a27f65b65a66affde55c7276438d4daa 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 0656049dafc0b974104ff1c2f79a98fac934901d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 94725063c0f9f64682bc0741c409bcefdf0be8ec 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 2338ba70bbdeae90c7a0270f63f5d2c1255b5529 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java b95595ade6120c0073c286e073715800b6cdd915 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c91f103d40c1f0fe9886b15820bb7ef7614 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java e0759b0b8894ec1d0cca41fa6f897576f8090070 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java a576f3a6720e5e4454faf0188a43091191b0c787 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java bcfc1f6202da5c4377cf6710525c9655a08ce4cc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 0c43d9800d27b6c343af2b200ebeff9cf20fa816 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 776021d94cfb3c724970bc81a5d03c58459c7911 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 6c442333fb42beafac1839907159d775b6f97dce 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java da74713e5656a10144a6298a2a6fea266a11e156 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7cea7d5a4491d1185cae845415d90d46cfd825c0 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 1385584e033abe904279a8fd6dfa299f4e48665c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 113d8deb8284443ae45151aa27852ab97570591e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java de52b0a50b8cec580eb7807669d652a85b71e5f9 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 96b1d054a3c444960c69298d878784a819defd53 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 62cc071237b84c46d69d78eea694eb9b8e9b2fd4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3f01dbeb1e27248071ecd78c48daea8b77c87459 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 97c6d08a6d4ab53a49d9e205d1b4013b08da3658 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0f05556decc24cd5101e75b0851d1f9ff14d4b95 

Diff: https://reviews.apache.org/r/40863/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.211s]
[INFO] Lens .............................................. SUCCESS [4.133s]
[INFO] Lens API .......................................... SUCCESS [26.669s]
[INFO] Lens API for server and extensions ................ SUCCESS [24.038s]
[INFO] Lens Cube ......................................... SUCCESS [6:30.318s]
[INFO] Lens DB storage ................................... SUCCESS [19.100s]
[INFO] Lens Query Library ................................ SUCCESS [14.772s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:00.020s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [40.555s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.922s]
[INFO] Lens Server ....................................... SUCCESS [10:23.992s]
[INFO] Lens client ....................................... SUCCESS [40.087s]
[INFO] Lens CLI .......................................... SUCCESS [54.969s]
[INFO] Lens Examples ..................................... SUCCESS [11.468s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.983s]
[INFO] Lens Distribution ................................. SUCCESS [9.764s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:31.190s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.913s]
[INFO] Lens Regression ................................... SUCCESS [15.667s]
[INFO] Lens UI ........................................... SUCCESS [27.084s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:39.990s
[INFO] Finished at: Fri Dec 04 11:43:24 UTC 2015
[INFO] Final Memory: 178M/1024M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal


Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/
-----------------------------------------------------------

(Updated Dec. 4, 2015, 5:15 p.m.)


Review request for lens.


Bugs: LENS-552
    https://issues.apache.org/jira/browse/LENS-552


Repository: lens


Description
-------

includes LENS-851 changes, since I expect this to be merged after LENS-851


Diffs
-----

  lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java b544a670a27f65b65a66affde55c7276438d4daa 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 0656049dafc0b974104ff1c2f79a98fac934901d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 94725063c0f9f64682bc0741c409bcefdf0be8ec 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java b95595ade6120c0073c286e073715800b6cdd915 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c91f103d40c1f0fe9886b15820bb7ef7614 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java e0759b0b8894ec1d0cca41fa6f897576f8090070 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java a576f3a6720e5e4454faf0188a43091191b0c787 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java bcfc1f6202da5c4377cf6710525c9655a08ce4cc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 0c43d9800d27b6c343af2b200ebeff9cf20fa816 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 200a48cd67e6a5a381ef3723a3adb686d8347efb 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 6c442333fb42beafac1839907159d775b6f97dce 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 1385584e033abe904279a8fd6dfa299f4e48665c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 113d8deb8284443ae45151aa27852ab97570591e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java cc8e68c5ad60edeb9638216a6cc9240750e3091e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1357035c8dfc6a5115c02d8fdc7cd8bb341eb6dd 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4cdd5f0a54d90603c1ef96282e8068f4d32 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8 

Diff: https://reviews.apache.org/r/40863/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.211s]
[INFO] Lens .............................................. SUCCESS [4.133s]
[INFO] Lens API .......................................... SUCCESS [26.669s]
[INFO] Lens API for server and extensions ................ SUCCESS [24.038s]
[INFO] Lens Cube ......................................... SUCCESS [6:30.318s]
[INFO] Lens DB storage ................................... SUCCESS [19.100s]
[INFO] Lens Query Library ................................ SUCCESS [14.772s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:00.020s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [40.555s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.922s]
[INFO] Lens Server ....................................... SUCCESS [10:23.992s]
[INFO] Lens client ....................................... SUCCESS [40.087s]
[INFO] Lens CLI .......................................... SUCCESS [54.969s]
[INFO] Lens Examples ..................................... SUCCESS [11.468s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.983s]
[INFO] Lens Distribution ................................. SUCCESS [9.764s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:31.190s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.913s]
[INFO] Lens Regression ................................... SUCCESS [15.667s]
[INFO] Lens UI ........................................... SUCCESS [27.084s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:39.990s
[INFO] Finished at: Fri Dec 04 11:43:24 UTC 2015
[INFO] Final Memory: 178M/1024M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal


Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/
-----------------------------------------------------------

(Updated Dec. 4, 2015, 5:15 p.m.)


Review request for lens.


Bugs: LENS-552
    https://issues.apache.org/jira/browse/LENS-552


Repository: lens


Description (updated)
-------

includes LENS-851 changes, since I expect this to be merged after LENS-851


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java b544a670a27f65b65a66affde55c7276438d4daa 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 0656049dafc0b974104ff1c2f79a98fac934901d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 94725063c0f9f64682bc0741c409bcefdf0be8ec 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java b95595ade6120c0073c286e073715800b6cdd915 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c91f103d40c1f0fe9886b15820bb7ef7614 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java e0759b0b8894ec1d0cca41fa6f897576f8090070 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java a576f3a6720e5e4454faf0188a43091191b0c787 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java bcfc1f6202da5c4377cf6710525c9655a08ce4cc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 0c43d9800d27b6c343af2b200ebeff9cf20fa816 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 200a48cd67e6a5a381ef3723a3adb686d8347efb 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 6c442333fb42beafac1839907159d775b6f97dce 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 1385584e033abe904279a8fd6dfa299f4e48665c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 113d8deb8284443ae45151aa27852ab97570591e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 418ef5a7b64f717618c3b16fe3755141c07beb76 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java cc8e68c5ad60edeb9638216a6cc9240750e3091e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java c9ba561bc8da1abb59898619620bbd47ec43028c 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1357035c8dfc6a5115c02d8fdc7cd8bb341eb6dd 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4cdd5f0a54d90603c1ef96282e8068f4d32 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8 

Diff: https://reviews.apache.org/r/40863/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

Posted by Rajat Khandelwal <ra...@gmail.com>.

> On Dec. 2, 2015, 4:31 p.m., Deepak Barr wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, line 525
> > <https://reviews.apache.org/r/40863/diff/1/?file=1150388#file1150388line525>
> >
> >     Remove this sys out

Will do. Thanks :)


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/#review108625
-----------------------------------------------------------


On Dec. 2, 2015, 3:55 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40863/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 3:55 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-552
>     https://issues.apache.org/jira/browse/LENS-552
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> We need to have support for union across storage tables of one/all  facts tables taking part in multi fact query.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java b544a670a27f65b65a66affde55c7276438d4daa 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 0656049dafc0b974104ff1c2f79a98fac934901d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java b95595ade6120c0073c286e073715800b6cdd915 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c91f103d40c1f0fe9886b15820bb7ef7614 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java e0759b0b8894ec1d0cca41fa6f897576f8090070 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java a576f3a6720e5e4454faf0188a43091191b0c787 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 200a48cd67e6a5a381ef3723a3adb686d8347efb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 6c442333fb42beafac1839907159d775b6f97dce 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 1385584e033abe904279a8fd6dfa299f4e48665c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 113d8deb8284443ae45151aa27852ab97570591e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java cc8e68c5ad60edeb9638216a6cc9240750e3091e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1357035c8dfc6a5115c02d8fdc7cd8bb341eb6dd 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4cdd5f0a54d90603c1ef96282e8068f4d32 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8 
> 
> Diff: https://reviews.apache.org/r/40863/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

Posted by Deepak Barr <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/#review108625
-----------------------------------------------------------



lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java (line 521)
<https://reviews.apache.org/r/40863/#comment168079>

    Remove this sys out


- Deepak Barr


On Dec. 2, 2015, 10:25 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40863/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 10:25 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-552
>     https://issues.apache.org/jira/browse/LENS-552
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> We need to have support for union across storage tables of one/all  facts tables taking part in multi fact query.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java b544a670a27f65b65a66affde55c7276438d4daa 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 0656049dafc0b974104ff1c2f79a98fac934901d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 7f8146158c1e2d883ee9327c4bf847883d0e1004 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java b95595ade6120c0073c286e073715800b6cdd915 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java cf114c91f103d40c1f0fe9886b15820bb7ef7614 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java e0759b0b8894ec1d0cca41fa6f897576f8090070 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java a576f3a6720e5e4454faf0188a43091191b0c787 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 200a48cd67e6a5a381ef3723a3adb686d8347efb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 6c442333fb42beafac1839907159d775b6f97dce 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 97088a146729d4d2fb6ed6c55c2d16bfa8c75339 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 9a9d1348cce1b90fa9d558cc6399d441cca9fca1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 1385584e033abe904279a8fd6dfa299f4e48665c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 113d8deb8284443ae45151aa27852ab97570591e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 60b2dde8a7e088d8712879c68cd98193bb72de03 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java cc8e68c5ad60edeb9638216a6cc9240750e3091e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1357035c8dfc6a5115c02d8fdc7cd8bb341eb6dd 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java ee84a4cdd5f0a54d90603c1ef96282e8068f4d32 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fea70b72cbde190d69d46f68d163fd9e541c53f8 
> 
> Diff: https://reviews.apache.org/r/40863/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>