[GitHub] [metron] nickwallen commented on a change in pull request #1488: METRON-2169: Upgrade Kafka/Storm

[GitBox <gi...@apache.org>]

nickwallen commented on a change in pull request #1488: METRON-2169: Upgrade Kafka/Storm
URL: https://github.com/apache/metron/pull/1488#discussion_r315793887
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -104,7 +104,7 @@
         <global_storm_kafka_version>1.2.2</global_storm_kafka_version>
         <global_flux_version>${base_flux_version}</global_flux_version>
         <global_pcap_version>1.7.1</global_pcap_version>
-        <global_kafka_version>0.10.0.1</global_kafka_version>
+        <global_kafka_version>2.0.0</global_kafka_version>
 
 Review comment:
   Should we upgrade to Kafka version 2.0.0 here?  This is the version that aligns with HDP 3.1.  
   
   Your changes are backwards compatible which gives us some flexibility. I would think we would want to continue to build against the existing HDP-2.6 version; 0.10.0.1 in this PR. We would then introduce the version bump to 2.0.0 (aligning with HDP-3.1)  in the feature branch separately.
   
   Is there a reason we wouldn't do this?  That seems the most logical to me, but maybe I am missing something.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services