You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2013/08/17 09:50:21 UTC
Review Request 13626: CLOUDSTACK-4132 current dnsmasq config does not allow
guest virtual machines(clients) to update its hostnames with a DNS server
Introducing the option dhcp-client-update fails if the version dnsmasq is
not above 2.6 (like in burbak template).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13626/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
Bugs: Cloudstack-4321
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4132 current dnsmasq config does not allow guest virtual machines(clients) to update its hostnames with a DNS server
Introducing the option dhcp-client-update fails if the version dnsmasq is not above 2.6 (like in burbak template).
Added a check for the version. will add this option in the config file only if the version is 2.6 and above.
Diffs
-----
patches/systemvm/debian/config/etc/init.d/cloud-early-config 736234c
Diff: https://reviews.apache.org/r/13626/diff/
Testing
-------
tested on 4.2.
with the burbank template by running updated cloud-early-config manually.
Thanks,
bharat kumar
Re: Review Request 13626: CLOUDSTACK-4132 current dnsmasq config does not
allow guest virtual machines(clients) to update its hostnames with a DNS
server Introducing the option dhcp-client-update fails if the version
dnsmasq is not above 2.6 (like in burbak template).
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13626/#review25267
-----------------------------------------------------------
This will fail for higher version than 2.6
- Abhinandan Prateek
On Aug. 17, 2013, 8:06 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13626/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2013, 8:06 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
>
>
> Bugs: Cloudstack-4321
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4132 current dnsmasq config does not allow guest virtual machines(clients) to update its hostnames with a DNS server
> Introducing the option dhcp-client-update fails if the version dnsmasq is not above 2.6 (like in burbak template).
> Added a check for the version. will add this option in the config file only if the version is 2.6 and above.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/etc/init.d/cloud-early-config 736234c
>
> Diff: https://reviews.apache.org/r/13626/diff/
>
>
> Testing
> -------
>
> tested on 4.2.
> with the burbank template by running updated cloud-early-config manually.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 13626: CLOUDSTACK-4132 current dnsmasq config does not
allow guest virtual machines(clients) to update its hostnames with a DNS
server Introducing the option dhcp-client-update fails if the version
dnsmasq is not above 2.6 (like in burbak template).
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13626/#review25289
-----------------------------------------------------------
Commit 66d76150657cd0e8d44e5be8307b8c59327b686d in branch refs/heads/master from Bharat Kumar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=66d7615 ]
CLOUDSTACK-4132 current dnsmasq config does not allow guest virtual machines(clients) to update its hostnames with a DNS server
Introducing the option dhcp-client-update fails if the dnsmasq version is less than 2.6 (like in older templates).
Added a check for the version in cloud-early-config. will add dhcp-client-update option in the config file only
if the dnsmasq version is 2.6 and above.
Signed-off-by: Jayapal <ja...@apache.org>
- ASF Subversion and Git Services
On Aug. 19, 2013, 5:30 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13626/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 5:30 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
>
>
> Bugs: Cloudstack-4321
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4132 current dnsmasq config does not allow guest virtual machines(clients) to update its hostnames with a DNS server
> Introducing the option dhcp-client-update fails if the version dnsmasq is not above 2.6 (like in burbak template).
> Added a check for the version. will add this option in the config file only if the version is 2.6 and above.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/etc/init.d/cloud-early-config 736234c
>
> Diff: https://reviews.apache.org/r/13626/diff/
>
>
> Testing
> -------
>
> tested on 4.2.
> with the burbank template by running updated cloud-early-config manually.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 13626: CLOUDSTACK-4132 current dnsmasq config does not
allow guest virtual machines(clients) to update its hostnames with a DNS
server Introducing the option dhcp-client-update fails if the version
dnsmasq is not above 2.6 (like in burbak template).
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13626/#review25290
-----------------------------------------------------------
Commit 8babd390d685d60c8183c7e482ce80af334f1d96 in branch refs/heads/4.2 from Bharat Kumar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8babd39 ]
CLOUDSTACK-4132 current dnsmasq config does not allow guest virtual machines(clients) to update its hostnames with a DNS server
Introducing the option dhcp-client-update fails if the dnsmasq version is less than 2.6 (like in older templates).
Added a check for the version in cloud-early-config. will add dhcp-client-update option in the config file only
if the dnsmasq version is 2.6 and above.
Signed-off-by: Jayapal <ja...@apache.org>
- ASF Subversion and Git Services
On Aug. 19, 2013, 5:30 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13626/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 5:30 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
>
>
> Bugs: Cloudstack-4321
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4132 current dnsmasq config does not allow guest virtual machines(clients) to update its hostnames with a DNS server
> Introducing the option dhcp-client-update fails if the version dnsmasq is not above 2.6 (like in burbak template).
> Added a check for the version. will add this option in the config file only if the version is 2.6 and above.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/etc/init.d/cloud-early-config 736234c
>
> Diff: https://reviews.apache.org/r/13626/diff/
>
>
> Testing
> -------
>
> tested on 4.2.
> with the burbank template by running updated cloud-early-config manually.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 13626: CLOUDSTACK-4132 current dnsmasq config does not
allow guest virtual machines(clients) to update its hostnames with a DNS
server Introducing the option dhcp-client-update fails if the version
dnsmasq is not above 2.6 (like in burbak template).
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13626/
-----------------------------------------------------------
(Updated Aug. 19, 2013, 5:30 a.m.)
Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
Bugs: Cloudstack-4321
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4132 current dnsmasq config does not allow guest virtual machines(clients) to update its hostnames with a DNS server
Introducing the option dhcp-client-update fails if the version dnsmasq is not above 2.6 (like in burbak template).
Added a check for the version. will add this option in the config file only if the version is 2.6 and above.
Diffs (updated)
-----
patches/systemvm/debian/config/etc/init.d/cloud-early-config 736234c
Diff: https://reviews.apache.org/r/13626/diff/
Testing
-------
tested on 4.2.
with the burbank template by running updated cloud-early-config manually.
Thanks,
bharat kumar
Re: Review Request 13626: CLOUDSTACK-4132 current dnsmasq config does not
allow guest virtual machines(clients) to update its hostnames with a DNS
server Introducing the option dhcp-client-update fails if the version
dnsmasq is not above 2.6 (like in burbak template).
Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13626/#review25270
-----------------------------------------------------------
Ship it!
Ship It!
- Jayapal Reddy
On Aug. 17, 2013, 11:35 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13626/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2013, 11:35 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
>
>
> Bugs: Cloudstack-4321
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4132 current dnsmasq config does not allow guest virtual machines(clients) to update its hostnames with a DNS server
> Introducing the option dhcp-client-update fails if the version dnsmasq is not above 2.6 (like in burbak template).
> Added a check for the version. will add this option in the config file only if the version is 2.6 and above.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/etc/init.d/cloud-early-config 736234c
>
> Diff: https://reviews.apache.org/r/13626/diff/
>
>
> Testing
> -------
>
> tested on 4.2.
> with the burbank template by running updated cloud-early-config manually.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 13626: CLOUDSTACK-4132 current dnsmasq config does not
allow guest virtual machines(clients) to update its hostnames with a DNS
server Introducing the option dhcp-client-update fails if the version
dnsmasq is not above 2.6 (like in burbak template).
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13626/
-----------------------------------------------------------
(Updated Aug. 17, 2013, 11:35 a.m.)
Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
Changes
-------
revised the code to accommodate versions greater than 2
Bugs: Cloudstack-4321
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4132 current dnsmasq config does not allow guest virtual machines(clients) to update its hostnames with a DNS server
Introducing the option dhcp-client-update fails if the version dnsmasq is not above 2.6 (like in burbak template).
Added a check for the version. will add this option in the config file only if the version is 2.6 and above.
Diffs (updated)
-----
patches/systemvm/debian/config/etc/init.d/cloud-early-config 736234c
Diff: https://reviews.apache.org/r/13626/diff/
Testing
-------
tested on 4.2.
with the burbank template by running updated cloud-early-config manually.
Thanks,
bharat kumar
Re: Review Request 13626: CLOUDSTACK-4132 current dnsmasq config does not
allow guest virtual machines(clients) to update its hostnames with a DNS
server Introducing the option dhcp-client-update fails if the version
dnsmasq is not above 2.6 (like in burbak template).
Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13626/#review25269
-----------------------------------------------------------
patches/systemvm/debian/config/etc/init.d/cloud-early-config
<https://reviews.apache.org/r/13626/#comment49562>
grep for 'version 2.6'.
Split the 2.6 and compare 2 and 6
In router currently it is showing 2.62
Dnsmasq version 2.62 Copyright (c) 2000-2012 Simon Kelley
- Jayapal Reddy
On Aug. 17, 2013, 8:06 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13626/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2013, 8:06 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
>
>
> Bugs: Cloudstack-4321
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4132 current dnsmasq config does not allow guest virtual machines(clients) to update its hostnames with a DNS server
> Introducing the option dhcp-client-update fails if the version dnsmasq is not above 2.6 (like in burbak template).
> Added a check for the version. will add this option in the config file only if the version is 2.6 and above.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/etc/init.d/cloud-early-config 736234c
>
> Diff: https://reviews.apache.org/r/13626/diff/
>
>
> Testing
> -------
>
> tested on 4.2.
> with the burbank template by running updated cloud-early-config manually.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 13626: CLOUDSTACK-4132 current dnsmasq config does not
allow guest virtual machines(clients) to update its hostnames with a DNS
server Introducing the option dhcp-client-update fails if the version
dnsmasq is not above 2.6 (like in burbak template).
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13626/
-----------------------------------------------------------
(Updated Aug. 17, 2013, 8:06 a.m.)
Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
Changes
-------
removed a typo from the commit message.
Bugs: Cloudstack-4321
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4132 current dnsmasq config does not allow guest virtual machines(clients) to update its hostnames with a DNS server
Introducing the option dhcp-client-update fails if the version dnsmasq is not above 2.6 (like in burbak template).
Added a check for the version. will add this option in the config file only if the version is 2.6 and above.
Diffs (updated)
-----
patches/systemvm/debian/config/etc/init.d/cloud-early-config 736234c
Diff: https://reviews.apache.org/r/13626/diff/
Testing
-------
tested on 4.2.
with the burbank template by running updated cloud-early-config manually.
Thanks,
bharat kumar