You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Jordan Zimmerman (JIRA)" <ji...@apache.org> on 2009/05/07 02:27:30 UTC
[jira] Created: (SHINDIG-1049) requestSendMessage should use the
RPC mechanism as similar features do
requestSendMessage should use the RPC mechanism as similar features do
----------------------------------------------------------------------
Key: SHINDIG-1049
URL: https://issues.apache.org/jira/browse/SHINDIG-1049
Project: Shindig
Issue Type: Improvement
Components: Javascript
Affects Versions: trunk
Reporter: Jordan Zimmerman
Fix For: trunk
Currently, in order for a container to implement requestSendMessage() it must overload Shindig internals. It would be far better to use the same method as for requestNavigateTo() etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (SHINDIG-1049) requestSendMessage should use the
RPC mechanism as similar features do
Posted by Sachin Shenoy <sa...@google.com>.
I had some doubt with changes in this patch.----
opensocial.requestSendMessage = function(recipients, message, opt_callback,
opt_params) {
gadgets.rpc.call(null, "requestSendMessage", opt_callback, recipients,
message, opt_callback,
opt_params);
};
----
The callback requestSendMessage expects opensocial.ResponseItem. How can I
form an instance of opensocial.ResponseItem at the container side and invoke
the callback that actually resides in gadget iframe? Are objects passed
across gadgets.rpc deserialized back to the right object? I thought they
would just get jsonified.
Also, With this patch we are forcing people to use the new mechanism. I
would have ideally liked the gadgets.rpc.call to be put in container.js and
have opensocial.js invoke it like,
opensocial.Container.get().requestSendMessage(recipients,
message, opt_callback, opt_params);
that way, none of the existing impl would have broken, and yet someone could
have impl. requestSendMessage without overriding any internals.
Thanks,
Sachin
On Sat, Jun 6, 2009 at 5:30 AM, Paul Lindner (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/SHINDIG-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Paul Lindner resolved SHINDIG-1049.
> -----------------------------------
>
> Resolution: Fixed
>
> nice.
>
> committed.
>
>
> > requestSendMessage should use the RPC mechanism as similar features do
> > ----------------------------------------------------------------------
> >
> > Key: SHINDIG-1049
> > URL: https://issues.apache.org/jira/browse/SHINDIG-1049
> > Project: Shindig
> > Issue Type: Improvement
> > Components: Javascript
> > Affects Versions: trunk
> > Reporter: Jordan Zimmerman
> > Fix For: trunk
> >
> > Attachments: fix-1049-bug.patch
> >
> >
> > Currently, in order for a container to implement requestSendMessage() it
> must overload Shindig internals. It would be far better to use the same
> method as for requestNavigateTo() etc.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
Re: [jira] Resolved: (SHINDIG-1049) requestSendMessage should use the
RPC mechanism as similar features do
Posted by Sachin Shenoy <sa...@google.com>.
I had some doubt with changes in this patch.----
opensocial.requestSendMessage = function(recipients, message, opt_callback,
opt_params) {
gadgets.rpc.call(null, "requestSendMessage", opt_callback, recipients,
message, opt_callback,
opt_params);
};
----
The callback requestSendMessage expects opensocial.ResponseItem. How can I
form an instance of opensocial.ResponseItem at the container side and invoke
the callback that actually resides in gadget iframe? Are objects passed
across gadgets.rpc deserialized back to the right object? I thought they
would just get jsonified.
Also, With this patch we are forcing people to use the new mechanism. I
would have ideally liked the gadgets.rpc.call to be put in container.js and
have opensocial.js invoke it like,
opensocial.Container.get().requestSendMessage(recipients,
message, opt_callback, opt_params);
that way, none of the existing impl would have broken, and yet someone could
have impl. requestSendMessage without overriding any internals.
Thanks,
Sachin
On Sat, Jun 6, 2009 at 5:30 AM, Paul Lindner (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/SHINDIG-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Paul Lindner resolved SHINDIG-1049.
> -----------------------------------
>
> Resolution: Fixed
>
> nice.
>
> committed.
>
>
> > requestSendMessage should use the RPC mechanism as similar features do
> > ----------------------------------------------------------------------
> >
> > Key: SHINDIG-1049
> > URL: https://issues.apache.org/jira/browse/SHINDIG-1049
> > Project: Shindig
> > Issue Type: Improvement
> > Components: Javascript
> > Affects Versions: trunk
> > Reporter: Jordan Zimmerman
> > Fix For: trunk
> >
> > Attachments: fix-1049-bug.patch
> >
> >
> > Currently, in order for a container to implement requestSendMessage() it
> must overload Shindig internals. It would be far better to use the same
> method as for requestNavigateTo() etc.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Resolved: (SHINDIG-1049) requestSendMessage should use the
RPC mechanism as similar features do
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1049.
-----------------------------------
Resolution: Fixed
nm, got it already..
> requestSendMessage should use the RPC mechanism as similar features do
> ----------------------------------------------------------------------
>
> Key: SHINDIG-1049
> URL: https://issues.apache.org/jira/browse/SHINDIG-1049
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Affects Versions: trunk
> Reporter: Jordan Zimmerman
> Fix For: trunk
>
> Attachments: fix-1049-bug.patch, fix-1049.patch
>
>
> Currently, in order for a container to implement requestSendMessage() it must overload Shindig internals. It would be far better to use the same method as for requestNavigateTo() etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1049) requestSendMessage should use the
RPC mechanism as similar features do
Posted by "Jordan Zimmerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jordan Zimmerman updated SHINDIG-1049:
--------------------------------------
Attachment: (was: fix-1049-bug.patch)
> requestSendMessage should use the RPC mechanism as similar features do
> ----------------------------------------------------------------------
>
> Key: SHINDIG-1049
> URL: https://issues.apache.org/jira/browse/SHINDIG-1049
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Affects Versions: trunk
> Reporter: Jordan Zimmerman
> Fix For: trunk
>
>
> Currently, in order for a container to implement requestSendMessage() it must overload Shindig internals. It would be far better to use the same method as for requestNavigateTo() etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SHINDIG-1049) requestSendMessage should use the
RPC mechanism as similar features do
Posted by "Jordan Zimmerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jordan Zimmerman reopened SHINDIG-1049:
---------------------------------------
Looks like I was wrong about the limitations. I'll continue work on this.
> requestSendMessage should use the RPC mechanism as similar features do
> ----------------------------------------------------------------------
>
> Key: SHINDIG-1049
> URL: https://issues.apache.org/jira/browse/SHINDIG-1049
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Affects Versions: trunk
> Reporter: Jordan Zimmerman
> Fix For: trunk
>
> Attachments: fix-1049-bug.patch
>
>
> Currently, in order for a container to implement requestSendMessage() it must overload Shindig internals. It would be far better to use the same method as for requestNavigateTo() etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SHINDIG-1049) requestSendMessage should use the
RPC mechanism as similar features do
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner reopened SHINDIG-1049:
-----------------------------------
reopening, sorry, missed this.
> requestSendMessage should use the RPC mechanism as similar features do
> ----------------------------------------------------------------------
>
> Key: SHINDIG-1049
> URL: https://issues.apache.org/jira/browse/SHINDIG-1049
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Affects Versions: trunk
> Reporter: Jordan Zimmerman
> Fix For: trunk
>
> Attachments: fix-1049-bug.patch, fix-1049.patch
>
>
> Currently, in order for a container to implement requestSendMessage() it must overload Shindig internals. It would be far better to use the same method as for requestNavigateTo() etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1049) requestSendMessage should use the
RPC mechanism as similar features do
Posted by "Jordan Zimmerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jordan Zimmerman updated SHINDIG-1049:
--------------------------------------
Attachment: fix-1049-bug.patch
This is a working implementation
> requestSendMessage should use the RPC mechanism as similar features do
> ----------------------------------------------------------------------
>
> Key: SHINDIG-1049
> URL: https://issues.apache.org/jira/browse/SHINDIG-1049
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Affects Versions: trunk
> Reporter: Jordan Zimmerman
> Fix For: trunk
>
> Attachments: fix-1049-bug.patch
>
>
> Currently, in order for a container to implement requestSendMessage() it must overload Shindig internals. It would be far better to use the same method as for requestNavigateTo() etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1049) requestSendMessage should use the
RPC mechanism as similar features do
Posted by "Louis Ryan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708071#action_12708071 ]
Louis Ryan commented on SHINDIG-1049:
-------------------------------------
What about having a callback makes this a problem. You can register a callback with gadgets.rpc or the implementation can can expose a separate method for the outer frame to call on completion.
> requestSendMessage should use the RPC mechanism as similar features do
> ----------------------------------------------------------------------
>
> Key: SHINDIG-1049
> URL: https://issues.apache.org/jira/browse/SHINDIG-1049
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Affects Versions: trunk
> Reporter: Jordan Zimmerman
> Fix For: trunk
>
> Attachments: fix-1049-bug.patch
>
>
> Currently, in order for a container to implement requestSendMessage() it must overload Shindig internals. It would be far better to use the same method as for requestNavigateTo() etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1049) requestSendMessage should use the
RPC mechanism as similar features do
Posted by "Sachin Shenoy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sachin Shenoy updated SHINDIG-1049:
-----------------------------------
Attachment: fix-1049.patch
Change that would make this backward compatible (allowing impl to chose to either override the requestSendMessage or use the new model).
> requestSendMessage should use the RPC mechanism as similar features do
> ----------------------------------------------------------------------
>
> Key: SHINDIG-1049
> URL: https://issues.apache.org/jira/browse/SHINDIG-1049
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Affects Versions: trunk
> Reporter: Jordan Zimmerman
> Fix For: trunk
>
> Attachments: fix-1049-bug.patch, fix-1049.patch
>
>
> Currently, in order for a container to implement requestSendMessage() it must overload Shindig internals. It would be far better to use the same method as for requestNavigateTo() etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1049) requestSendMessage should use the
RPC mechanism as similar features do
Posted by "Jordan Zimmerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jordan Zimmerman updated SHINDIG-1049:
--------------------------------------
Attachment: fix-1049-bug.patch
I've tested this with callbacks and it works correctly (assuming correct setAuthToken() and setRpcRelay() are done).
> requestSendMessage should use the RPC mechanism as similar features do
> ----------------------------------------------------------------------
>
> Key: SHINDIG-1049
> URL: https://issues.apache.org/jira/browse/SHINDIG-1049
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Affects Versions: trunk
> Reporter: Jordan Zimmerman
> Fix For: trunk
>
> Attachments: fix-1049-bug.patch
>
>
> Currently, in order for a container to implement requestSendMessage() it must overload Shindig internals. It would be far better to use the same method as for requestNavigateTo() etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1049) requestSendMessage should use the
RPC mechanism as similar features do
Posted by "Jordan Zimmerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jordan Zimmerman resolved SHINDIG-1049.
---------------------------------------
Resolution: Invalid
The callback argument makes this approach untenable.
> requestSendMessage should use the RPC mechanism as similar features do
> ----------------------------------------------------------------------
>
> Key: SHINDIG-1049
> URL: https://issues.apache.org/jira/browse/SHINDIG-1049
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Affects Versions: trunk
> Reporter: Jordan Zimmerman
> Fix For: trunk
>
> Attachments: fix-1049-bug.patch
>
>
> Currently, in order for a container to implement requestSendMessage() it must overload Shindig internals. It would be far better to use the same method as for requestNavigateTo() etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1049) requestSendMessage should use the
RPC mechanism as similar features do
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1049.
-----------------------------------
Resolution: Fixed
nice.
committed.
> requestSendMessage should use the RPC mechanism as similar features do
> ----------------------------------------------------------------------
>
> Key: SHINDIG-1049
> URL: https://issues.apache.org/jira/browse/SHINDIG-1049
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Affects Versions: trunk
> Reporter: Jordan Zimmerman
> Fix For: trunk
>
> Attachments: fix-1049-bug.patch
>
>
> Currently, in order for a container to implement requestSendMessage() it must overload Shindig internals. It would be far better to use the same method as for requestNavigateTo() etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.