You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/02/22 20:44:41 UTC

[GitHub] [helix] pkuwm opened a new issue #1654: Refactor maintenance auto enter logic

pkuwm opened a new issue #1654:
URL: https://github.com/apache/helix/issues/1654


   ### Problem
   The maintenance auto enter/`validateOfflineInstancesLimit()` logic is currently in `BestPossibleStateCalcStage`. #1650 adds a new API `enableMaintenanceMode()` to update the data cache to enable maintenance mode for the first pipeline.
   
   It's cleaner to refactor the instances validation to a stage (eg. ClusterStateValidationStage) other than `BestPossibleStateCalcStage`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org