Re: [PR] Remove unnecessary catch blocks and log statements in syncSendGrpcMessage [rocketmq-spring]

["SevenBlue2018 (via GitHub)" <gi...@apache.org>]

SevenBlue2018 commented on code in PR #711:
URL: https://github.com/apache/rocketmq-spring/pull/711#discussion_r1992623858


##########
rocketmq-v5-client-spring-boot/src/main/java/org/apache/rocketmq/client/core/RocketMQClientTemplate.java:
##########
@@ -228,12 +228,7 @@ public SendReceipt syncSendGrpcMessage(String destination, Message<?> message, D
         try {
             org.apache.rocketmq.client.apis.message.Message rocketMsg = this.createRocketMQMessage(destination, message, messageDelayTime, messageGroup);
             Producer grpcProducer = this.getProducer();
-            try {
-                sendReceipt = grpcProducer.send(rocketMsg);
-                log.info("Send message successfully, messageId={}", sendReceipt.getMessageId());
-            } catch (Throwable t) {
-                log.error("Failed to send message", t);
-            }
+            sendReceipt = grpcProducer.send(rocketMsg);
         } catch (Exception e) {
             log.error("send request message failed. destination:{}, message:{} ", destination, message);

Review Comment:
   Does this log entry serve a purpose? Should we make it configurable for users?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org