You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2011/12/15 20:14:09 UTC

Re: Review Request: HIVE-2503: create per-session HiveConf instance

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2820/#review3926
-----------------------------------------------------------


We should include a test case for regression purposes. You can achieve this by playing with test.service.standalone.server. If that doesn't work out, then you can always extend TestHiveServer and setup the test the way you want.

- Ashutosh


On 2011-11-14 08:54:00, Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2820/
> -----------------------------------------------------------
> 
> (Updated 2011-11-14 08:54:00)
> 
> 
> Review request for hive and Carl Steinbach.
> 
> 
> Summary
> -------
> 
> We uses multiple HiveClient connected to single HiveServer. After configuring connections, we've found the environment variables are different from expected. 
> Current hive server uses single instance of HiveConf and this seemed to make the problem.
> 
> 
> This addresses bug HIVE-2503.
>     https://issues.apache.org/jira/browse/HIVE-2503
> 
> 
> Diffs
> -----
> 
>   service/src/java/org/apache/hadoop/hive/service/HiveServer.java a2d599f 
> 
> Diff: https://reviews.apache.org/r/2820/diff
> 
> 
> Testing
> -------
> 
> If we use 'standAloneServer' in TestHiveServer.class, it is very simple to make the test case. But it seemed to be 'false' which makes it more complex.
> 
> 
> Thanks,
> 
> Navis
> 
>