You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/07/19 19:32:06 UTC
[GitHub] flink pull request #4372: [FLINK-7234] [docs] Fix CombineHint documentation
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4372
[FLINK-7234] [docs] Fix CombineHint documentation
## What is the purpose of the change
Update and correct the documentation for the use of CombineHint with `reduce` or `distinct`. The documentation for 1.2/1.3/1.4 has CombineHint described under `groupReduce`.
## Brief change log
Documentation was moved and slightly reworded.
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
Dependencies (does it add or upgrade a dependency): (yes / **no**)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / **no**)
The serializers: (yes / **no** / don't know)
The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know):
## Documentation
Does this pull request introduce a new feature? (yes / **no**)
If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 7234_fix_combinehint_documentation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4372.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4372
----
commit ec143c7ad08a47de96b418878efd540ec7328636
Author: Greg Hogan <co...@greghogan.com>
Date: 2017-07-19T19:24:20Z
[FLINK-7234] [docs] Fix CombineHint documentation
The CombineHint documentation applies to DataSet#reduce not
DataSet#reduceGroup and should also be note for DataSet#distinct. It is
also set with .setCombineHint(CombineHint) rather than alongside the UDF
parameter.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4372: [FLINK-7234] [docs] Fix CombineHint documentation
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4372
Thanks for trying out the discussed template @greghogan
I think for docs, you can invoke the *(The sections below can be removed for hotfixes of typos)* clause ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4372: [FLINK-7234] [docs] Fix CombineHint documentation
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4372
@StephanEwen I like the new template. I much prefer free form over checkboxes.
@fhueske I'm questioning my understanding of the the heuristic for using a hash-combine. For a fixed number of keys the hash-combine can be beneficial independent of the size of the data set. Basing the decision on the ratio of keys to values, as the size of the data set increases the likelihood of matching keys and values occurring in the same combine operation (before filling and being flushed to the reducer) decreases.
This is often the case for graphs. I'm thinking that the improvement for using hash-combine on larger data sets may have been due to hashing performing better than sort when we wanted to disable the combiner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4372: [FLINK-7234] [docs] Fix CombineHint documentation
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4372
@fhueske I started running some benchmarks on HITS with each of the combiners (sort, hash, none) and at small scales hash is fasted followed by none with sort in last. None is somewhat faster than hash for very small graphs. I've gotten stuck on scale 23 where the job is deadlocking on the first iteration for all three types. Interestingly I also see the deadlock on my laptop running from IntelliJ. I need to look more because I'm not seeing what is releasing memory buffers when all operators are seemingly waiting on acquiring a buffer from `LocalBufferPool`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4372: [FLINK-7234] [docs] Fix CombineHint documentation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4372
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4372: [FLINK-7234] [docs] Fix CombineHint documentation
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4372
One minor comment. Otherwise +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4372: [FLINK-7234] [docs] Fix CombineHint documentation
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4372#discussion_r128351347
--- Diff: docs/dev/batch/index.md ---
@@ -205,20 +205,25 @@ data.filter(new FilterFunction<Integer>() {
<td><strong>Reduce</strong></td>
<td>
<p>Combines a group of elements into a single element by repeatedly combining two elements
- into one. Reduce may be applied on a full data set, or on a grouped data set.</p>
+ into one. Reduce may be applied on a full data set or on a grouped data set.</p>
{% highlight java %}
data.reduce(new ReduceFunction<Integer> {
public Integer reduce(Integer a, Integer b) { return a + b; }
});
{% endhighlight %}
+ <p>If the reduce was applied to a grouped data set then you can specify the way that the
--- End diff --
`If the reduce was ...` -> `If the reduce transformation was ...` or `If the reduce function was ...`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4372: [FLINK-7234] [docs] Fix CombineHint documentation
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4372
I think you are right @greghogan.
It's not about the ratio of #distinct keys to size of the dataset. But it's also not only the ratio of #distinct keys to size of the memory. The skew of the key distribution has an effect as well (hash-based combiners should better handle skew than sort-based combiners).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---