You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2009/11/04 01:29:32 UTC
[jira] Created: (THRIFT-620) Compact Protocol should call readAll,
not read
Compact Protocol should call readAll, not read
----------------------------------------------
Key: THRIFT-620
URL: https://issues.apache.org/jira/browse/THRIFT-620
Project: Thrift
Issue Type: Bug
Reporter: Bryan Duxbury
Assignee: Bryan Duxbury
Fix For: 0.2
Attachments: thrift-620.patch
TCompactProtocol's current implementation is calling trans_.read instead of trans_.readAll. As a result, if you are using a buffer, or something like a GZipInputStream, you can get an underrun on your read unexpectedly, desynchronizing the stream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-620) Compact Protocol should call readAll,
not read
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-620:
---------------------------------
Attachment: thrift-620.patch
This fixes the problem.
> Compact Protocol should call readAll, not read
> ----------------------------------------------
>
> Key: THRIFT-620
> URL: https://issues.apache.org/jira/browse/THRIFT-620
> Project: Thrift
> Issue Type: Bug
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.2
>
> Attachments: thrift-620.patch
>
>
> TCompactProtocol's current implementation is calling trans_.read instead of trans_.readAll. As a result, if you are using a buffer, or something like a GZipInputStream, you can get an underrun on your read unexpectedly, desynchronizing the stream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-620) Compact Protocol should call readAll,
not read
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-620.
--------------------------------
Resolution: Fixed
I just committed this.
> Compact Protocol should call readAll, not read
> ----------------------------------------------
>
> Key: THRIFT-620
> URL: https://issues.apache.org/jira/browse/THRIFT-620
> Project: Thrift
> Issue Type: Bug
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.2
>
> Attachments: thrift-620.patch
>
>
> TCompactProtocol's current implementation is calling trans_.read instead of trans_.readAll. As a result, if you are using a buffer, or something like a GZipInputStream, you can get an underrun on your read unexpectedly, desynchronizing the stream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.