You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Chun Chen <ch...@gmail.com> on 2013/12/24 07:01:08 UTC

Review Request 16447: HIVE-2584 Alter table should accept database name

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16447/
-----------------------------------------------------------

Review request for hive.


Repository: hive-git


Description
-------

It would be nice if alter table accepts database name.
For example:
This would be more useful in certain usecases:
alter table DB.Tbl set location <location>;
rather than 2 statements.
use DB;
alter table Tbl set location <location>;


Diffs
-----

  metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 8345d70 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java ec68e7c 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 947b65c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 448dae2 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 0f60fcb 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g b34f53b 
  ql/src/test/queries/clientpositive/alter6.q PRE-CREATION 
  ql/src/test/results/clientnegative/alter_partition_coltype_2columns.q.out e1f9a27 
  ql/src/test/results/clientnegative/archive_partspec3.q.out c85e9a2 
  ql/src/test/results/clientpositive/alter6.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/drop_multi_partitions.q.out 31cd197 
  ql/src/test/results/clientpositive/input3.q.out 58231b1 
  ql/src/test/results/clientpositive/insert2_overwrite_partitions.q.out fcc551e 
  ql/src/test/results/clientpositive/show_create_table_db_table.q.out d36e8b0 

Diff: https://reviews.apache.org/r/16447/diff/


Testing
-------


Thanks,

Chun Chen


Re: Review Request 16447: HIVE-2584 Alter table should accept database name

Posted by Chun Chen <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16447/
-----------------------------------------------------------

(Updated Dec. 25, 2013, 7:30 a.m.)


Review request for hive.


Changes
-------

add check return code of rename function 


Repository: hive-git


Description
-------

It would be nice if alter table accepts database name.
For example:
This would be more useful in certain usecases:
alter table DB.Tbl set location <location>;
rather than 2 statements.
use DB;
alter table Tbl set location <location>;


Diffs (updated)
-----

  metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 8345d70 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java ec68e7c 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 947b65c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 448dae2 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 0f60fcb 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g b34f53b 
  ql/src/test/queries/clientnegative/alter_table_rename.q PRE-CREATION 
  ql/src/test/queries/clientpositive/alter6.q PRE-CREATION 
  ql/src/test/results/clientnegative/alter_partition_coltype_2columns.q.out e1f9a27 
  ql/src/test/results/clientnegative/alter_table_rename.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/archive_partspec3.q.out c85e9a2 
  ql/src/test/results/clientpositive/alter6.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/drop_multi_partitions.q.out 31cd197 
  ql/src/test/results/clientpositive/input3.q.out 58231b1 
  ql/src/test/results/clientpositive/insert2_overwrite_partitions.q.out fcc551e 
  ql/src/test/results/clientpositive/show_create_table_db_table.q.out d36e8b0 

Diff: https://reviews.apache.org/r/16447/diff/


Testing
-------


Thanks,

Chun Chen