[jira] [Commented] (WICKET-6714) Please add better getResource-Support for MockServletContext

["Sven Meier (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-6714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984255#comment-16984255 ] 

Sven Meier commented on WICKET-6714:
------------------------------------

WicketTester has constructors that allow specifying path or servletContext, why don't you use these?

> Please add better getResource-Support for MockServletContext
> ------------------------------------------------------------
>
>                 Key: WICKET-6714
>                 URL: https://issues.apache.org/jira/browse/WICKET-6714
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 8.0.0, 9.0.0-M3
>            Reporter: Hans Schäfer
>            Priority: Minor
>
> Hello!
> WicketTester does not provide a useful MockServletContext#getResource(). As WicketTester always instantiates MockServletContext passing a null-Value as path (webappRoot), the method MockServletContext#getResource always returns null, even if a resource in the classpath exists.
> My proposal for the implementation of Method MockServletContext#getResource() is:
> URL result = {color:#000080}null{color};
> {color:#000080}if {color}(name.startsWith({color:#008000}"/"{color})) {
>    name = name.substring({color:#0000ff}1{color});
> }
> if (webappRoot != null) {
>   final File f = {color:#000080}new {color}File({color:#660e7a}webappRoot{color}, name);
> {color:#000080}  if {color}(f.exists()) {
>      result = f.toURI().toURL();
> }
> {color:#000080}if {color}(result == {color:#000080}null{color}) {
>    result = getClass().getClassLoader().getResource({color:#008000}"META-INF/resources/" {color}+ name);
> }
> {color:#000080}return {color}result;
> Best regards
> Hans



--
This message was sent by Atlassian Jira
(v8.3.4#803005)