You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/07/06 04:12:11 UTC
[GitHub] carbondata pull request #2456: [CARBONDATA-2694][32k] Show longstring table ...
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2456
[CARBONDATA-2694][32k] Show longstring table property in descformatted
add longstring table property in the output of desc formantted command
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
`NO`
- [ ] Any backward compatibility impacted?
`NO`
- [ ] Document update required?
`NO`
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
`Added test`
- How it is tested? Please attach test report.
`Tested in local machine`
- Is it a performance related change? Please attach the performance test report.
`NO`
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata CARBONDATA-2694_desc_longstring
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2456.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2456
----
commit 05d917b087b736a01c9112ac84130e9fc0800b48
Author: xuchuanyin <xu...@...>
Date: 2018-07-06T04:09:23Z
Show longstring table property in descformatted
add longstring table property in the output of desc formantted command
----
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2456
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5678/
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2456
retest this please
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2456
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5669/
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2456
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5656/
---
[GitHub] carbondata pull request #2456: [CARBONDATA-2694][32k] Show longstring table ...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2456#discussion_r204616746
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDescribeFormattedCommand.scala ---
@@ -114,6 +114,13 @@ private[sql] case class CarbonDescribeFormattedCommand(
CarbonCommonConstants.CACHE_LEVEL_DEFAULT_VALUE), ""))
val isStreaming = tblProps.asScala.getOrElse("streaming", "false")
results ++= Seq(("Streaming", isStreaming, ""))
+
+ // longstring related info
+ if (tblProps.containsKey(CarbonCommonConstants.LONG_STRING_COLUMNS)) {
--- End diff --
ok~
---
[GitHub] carbondata pull request #2456: [CARBONDATA-2694][32k] Show longstring table ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2456
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2456
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6898/
---
[GitHub] carbondata pull request #2456: [CARBONDATA-2694][32k] Show longstring table ...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2456#discussion_r204612953
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDescribeFormattedCommand.scala ---
@@ -114,6 +114,13 @@ private[sql] case class CarbonDescribeFormattedCommand(
CarbonCommonConstants.CACHE_LEVEL_DEFAULT_VALUE), ""))
val isStreaming = tblProps.asScala.getOrElse("streaming", "false")
results ++= Seq(("Streaming", isStreaming, ""))
+
+ // longstring related info
+ if (tblProps.containsKey(CarbonCommonConstants.LONG_STRING_COLUMNS)) {
--- End diff --
but according to the latest discussion the final output would be the upper case of "long_string_columns".
refer to: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/Change-the-comment-content-for-column-when-execute-command-desc-formatted-table-name-td46848.html
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2456
retest sdv please
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2456
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6870/
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2456
LGTM
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2456
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5692/
---
[GitHub] carbondata pull request #2456: [CARBONDATA-2694][32k] Show longstring table ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2456#discussion_r204611831
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDescribeFormattedCommand.scala ---
@@ -114,6 +114,13 @@ private[sql] case class CarbonDescribeFormattedCommand(
CarbonCommonConstants.CACHE_LEVEL_DEFAULT_VALUE), ""))
val isStreaming = tblProps.asScala.getOrElse("streaming", "false")
results ++= Seq(("Streaming", isStreaming, ""))
+
+ // longstring related info
+ if (tblProps.containsKey(CarbonCommonConstants.LONG_STRING_COLUMNS)) {
--- End diff --
Please use a more human readable string like `Long String Columns`
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:
https://github.com/apache/carbondata/pull/2456
retest sdv please
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2456
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5722/
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2456
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5687/
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2456
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6187/
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2456
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7428/
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2456
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5653/
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2456
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7097/
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2456
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5873/
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2456
retest sdv please
---
[GitHub] carbondata issue #2456: [CARBONDATA-2694][32k] Show longstring table propert...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2456
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5979/
---
[GitHub] carbondata pull request #2456: [CARBONDATA-2694][32k] Show longstring table ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2456#discussion_r204615191
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDescribeFormattedCommand.scala ---
@@ -114,6 +114,13 @@ private[sql] case class CarbonDescribeFormattedCommand(
CarbonCommonConstants.CACHE_LEVEL_DEFAULT_VALUE), ""))
val isStreaming = tblProps.asScala.getOrElse("streaming", "false")
results ++= Seq(("Streaming", isStreaming, ""))
+
+ // longstring related info
+ if (tblProps.containsKey(CarbonCommonConstants.LONG_STRING_COLUMNS)) {
--- End diff --
ok, we should stick to that
---