You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Isabel Jimenez <co...@isabeljimenez.com> on 2015/10/07 21:15:12 UTC

Review Request 39100: Changed Credential validation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39100/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

We should validate credentials before anything else in HTTP endpoints.


Diffs
-----

  src/master/http.cpp 4b9f9ed 

Diff: https://reviews.apache.org/r/39100/diff/


Testing
-------

make check


Thanks,

Isabel Jimenez

Re: Review Request 39100: Changed Credential validation

Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39100/#review101839
-----------------------------------------------------------

Ship it!


Ship It!

- Michael Park


On Oct. 7, 2015, 7:15 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39100/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2015, 7:15 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3560
>     https://issues.apache.org/jira/browse/MESOS-3560
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We should validate credentials before anything else in HTTP endpoints.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 4b9f9ed 
> 
> Diff: https://reviews.apache.org/r/39100/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 39100: Changed Credential validation

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39100/#review102226
-----------------------------------------------------------

Ship it!


Ship It!

- Guangya Liu


On 十月 8, 2015, 6:26 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39100/
> -----------------------------------------------------------
> 
> (Updated 十月 8, 2015, 6:26 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3560
>     https://issues.apache.org/jira/browse/MESOS-3560
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We should validate credentials before anything else in HTTP endpoints.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 4b9f9ed 
> 
> Diff: https://reviews.apache.org/r/39100/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 39100: Changed Credential validation

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39100/#review101997
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39135, 39100]

All tests passed.

- Mesos ReviewBot


On Oct. 8, 2015, 6:26 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39100/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 6:26 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3560
>     https://issues.apache.org/jira/browse/MESOS-3560
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We should validate credentials before anything else in HTTP endpoints.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 4b9f9ed 
> 
> Diff: https://reviews.apache.org/r/39100/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 39100: Changed Credential validation

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39100/
-----------------------------------------------------------

(Updated Oct. 8, 2015, 6:26 p.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-3560
    https://issues.apache.org/jira/browse/MESOS-3560


Repository: mesos


Description
-------

We should validate credentials before anything else in HTTP endpoints.


Diffs
-----

  src/master/http.cpp 4b9f9ed 

Diff: https://reviews.apache.org/r/39100/diff/


Testing
-------

make check


Thanks,

Isabel Jimenez

Re: Review Request 39100: Changed Credential validation

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39100/
-----------------------------------------------------------

(Updated Oct. 7, 2015, 7:15 p.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-3560
    https://issues.apache.org/jira/browse/MESOS-3560


Repository: mesos


Description
-------

We should validate credentials before anything else in HTTP endpoints.


Diffs
-----

  src/master/http.cpp 4b9f9ed 

Diff: https://reviews.apache.org/r/39100/diff/


Testing
-------

make check


Thanks,

Isabel Jimenez