You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "john-jac (via GitHub)" <gi...@apache.org> on 2026/05/11 16:26:22 UTC

[PR] Add `BedrockCreateEvaluationJobOperator` [airflow]

john-jac opened a new pull request, #66722:
URL: https://github.com/apache/airflow/pull/66722

   Adds `BedrockCreateEvaluationJobOperator` to create an Amazon Bedrock model evaluation job.
   
   - Operator implementation using `BedrockHook`
   - Unit tests with mock assertions (including optional params)
   - System test (new `example_bedrock_evaluation.py`)
   - Docs with exampleinclude


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add `BedrockCreateEvaluationJobOperator` [airflow]

Posted by "SameerMesiah97 (via GitHub)" <gi...@apache.org>.
SameerMesiah97 commented on code in PR #66722:
URL: https://github.com/apache/airflow/pull/66722#discussion_r3230106348


##########
providers/amazon/tests/system/amazon/aws/example_bedrock_evaluation.py:
##########


Review Comment:
   Could you clarify what you mean by this:
   
   I would try to also do it for each different bedrock operator
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add `BedrockCreateEvaluationJobOperator` [airflow]

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #66722:
URL: https://github.com/apache/airflow/pull/66722


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add `BedrockCreateEvaluationJobOperator` [airflow]

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #66722:
URL: https://github.com/apache/airflow/pull/66722#discussion_r3222053942


##########
providers/amazon/tests/system/amazon/aws/example_bedrock_evaluation.py:
##########


Review Comment:
   We seem to have taken the path of having multiple bedrock system tests. I am sure we did that for good reasons but I would try to also do it for each different bedrock operator



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add `BedrockCreateEvaluationJobOperator` [airflow]

Posted by "john-jac (via GitHub)" <gi...@apache.org>.
john-jac commented on code in PR #66722:
URL: https://github.com/apache/airflow/pull/66722#discussion_r3243932249


##########
providers/amazon/tests/system/amazon/aws/example_bedrock_evaluation.py:
##########


Review Comment:
   We used a separate system test file (example_bedrock_evaluation.py) because evaluation jobs have different setup requirements (model access, datasets) than guardrails. Happy to 
   consolidate if preferred.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add `BedrockCreateEvaluationJobOperator` [airflow]

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #66722:
URL: https://github.com/apache/airflow/pull/66722#discussion_r3244051267


##########
providers/amazon/tests/system/amazon/aws/example_bedrock_evaluation.py:
##########


Review Comment:
   Let's leave it as is, we'll consolidate later if we think we should



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org