[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #2468: IGNITE-19951 Enable checks of using NotNull annotation.

["ygerzhedovich (via GitHub)" <gi...@apache.org>]

ygerzhedovich commented on code in PR #2468:
URL: https://github.com/apache/ignite-3/pull/2468#discussion_r1301775906


##########
check-rules/pmd-rules.xml:
##########
@@ -43,4 +43,23 @@
     -->
     <!--    <rule ref="category/java/bestpractices.xml/UnusedPrivateMethod" />-->
 
+    <rule name="Prohibited classes"
+      language="java"
+      message="Avoid using these classes."
+      class="net.sourceforge.pmd.lang.rule.XPathRule" >
+        <description>
+            Avoid using these classes.
+        </description>
+        <priority>3</priority>
+        <properties>
+            <property name="xpath">
+                <value>
+                    <![CDATA[
+//Name[pmd-java:typeIs('org.jetbrains.annotations.NotNull')]

Review Comment:
   we had deisabled checks for test sources. I've added commit to enable the check with fixing all checkstyle problem in tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org