You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/03/20 01:21:15 UTC

[GitHub] [incubator-mxnet] stu1130 opened a new pull request #14475: Fixes test_operator_gpu.test_multinomial_generator

stu1130 opened a new pull request #14475: Fixes test_operator_gpu.test_multinomial_generator
URL: https://github.com/apache/incubator-mxnet/pull/14475
 
 
   ## Description ##
   Fixes #14457, #14158
   success_rate of the verify_generator function was changing from 0.15 to 0.25 after the this PR (https://github.com/apache/incubator-mxnet/commit/0011ab2f4bf87619cdfe0bb928... ). Since then the test became flaky. Reassign the success_rate to 0.2
   
   Run 9606 times pass the test.
   ```
   MXNET_TEST_COUNT=10000 nosetests -v test_operator_gpu.py:test_multinomial_generator
   ^C[INFO] 9609 of 10000: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=262122728 to reproduce.
   
   ----------------------------------------------------------------------
   Ran 1 test in 95632.373s
   
   OK
   ```
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services