You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2018/12/28 14:19:31 UTC
[GitHub] wlliqipeng commented on a change in pull request #2:
docs(contributing): add CONTRIBUTING document
wlliqipeng commented on a change in pull request #2: docs(contributing): add CONTRIBUTING document
URL: https://github.com/apache/rocketmq-client-nodejs/pull/2#discussion_r244330846
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -13,4 +13,9 @@ Contributors guide: https://github.com/apache/rocketmq-client-nodejs/blob/master
- [ ] `npm test` passes
- [ ] tests and/or benchmarks are included
- [ ] documentation is changed or added
-- [ ] commit message follows [commit guidelines](https://github.com/apache/rocketmq-client-nodejs/blob/master/PULL_REQUEST.md#commit-message-guidelines)
+- [ ] commit message follows [commit guidelines](https://github.com/apache/rocketmq-client-nodejs/blob/master/CONTRIBUTING.md#commit-message-guidelines)
+
+##### Description of change
+
++ any feature?
++ Close #[AN_ISSUE_NUMBER]
Review comment:
It would be better to add another step to validate the change after description of change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services