You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/07 01:03:39 UTC
[GitHub] [beam] angoenka opened a new pull request #11071: [BEAM-9465] Fire
repeatedly in reshuffle
angoenka opened a new pull request #11071: [BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071
[BEAM-9465] Fire repeatedly in reshuffle
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11071: [cherry-pick][BEAM-9465]
Fire repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11071: [cherry-pick][BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-599678465
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11071: [BEAM-9465] Fire
repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11071: [BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-598587326
Run Python 2 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11071: [BEAM-9465] Fire
repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11071: [BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-596845610
Failure seems to be unrelated:
AssertionError: "Failed assert" does not match "Unexpected type for Value message."
Stacktrace
self = <apache_beam.runners.portability.portable_runner_test.PortableRunnerTestWithExternalEnv testMethod=test_assert_that>
def test_assert_that(self):
# TODO: figure out a way for fn_api_runner to parse and raise the
# underlying exception.
with self.assertRaisesRegex(Exception, 'Failed assert'):
with self.create_pipeline() as p:
> assert_that(p | beam.Create(['a', 'b']), equal_to(['a']))
E AssertionError: "Failed assert" does not match "Unexpected type for Value message."
apache_beam/runners/portability/fn_api_runner_test.py:105: AssertionError
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11071: [BEAM-9465] Fire
repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11071: [BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-596721142
LGTM as it's just a cherry pick PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11071: [BEAM-9465] Fire
repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11071: [BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-596025372
R: @amaliujia
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11071: [cherry-pick][BEAM-9465]
Fire repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11071: [cherry-pick][BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-599723118
Python Precommits passing: https://builds.apache.org/job/beam_PreCommit_Python_Phrase/1603/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11071: [BEAM-9465] Fire
repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11071: [BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-596892250
Please hold PR a bit if there is a failure in precommit. I am narrowing down issues in release branch now so trying to avoid introducing noise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11071: [BEAM-9465] Fire
repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11071: [BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-596721489
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11071: [cherry-pick][BEAM-9465]
Fire repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11071: [cherry-pick][BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-598901989
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11071: [BEAM-9465] Fire
repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11071: [BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-598587283
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11071: [cherry-pick][BEAM-9465]
Fire repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11071: [cherry-pick][BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-599797804
already merged in 2.20
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11071: [BEAM-9465] Fire
repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11071: [BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-596171249
R: @robertwb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11071: [BEAM-9465] Fire
repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11071: [BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-598469860
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11071: [BEAM-9465] Fire
repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11071: [BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-598351066
@amaliujia Friendly reminder to cp it :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11071: [BEAM-9465] Fire
repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11071: [BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-596956979
Sure, Please feel free to merge when issue in release branch is resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11071: [BEAM-9465] Fire
repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11071: [BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-596821140
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11071: [BEAM-9465] Fire
repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11071: [BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-598470030
Run Python 2 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka commented on issue #11071: [BEAM-9465] Fire
repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
angoenka commented on issue #11071: [BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071#issuecomment-596861227
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] angoenka closed pull request #11071:
[cherry-pick][BEAM-9465] Fire repeatedly in reshuffle
Posted by GitBox <gi...@apache.org>.
angoenka closed pull request #11071: [cherry-pick][BEAM-9465] Fire repeatedly in reshuffle
URL: https://github.com/apache/beam/pull/11071
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services